update lookup for v14.x known failures #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New global variable `FinalizationRegistry` and `WeakRef` are causing shot to consistently fail on v14.x after v14.6.0. This can be reverted when shot fixes this issue.
It is consistently failing on 14.x on all platforms
It is consistently failing with ` No tests found, exiting with code 1`
This is also failing due to jest support for aix. Skip.
This is failing due to Jest not supporting AIX
MylesBorins
changed the title
richardlau
approved these changes
Jul 21, 2020
| @@ -328,7 +328,8 @@ | |||
| }, | |||
| "path-to-regexp": { | |||
| "prefix": "v", | |||
| "maintainers": "blakeembrey" | |||
| "maintainers": "blakeembrey", | |||
| "skip": ["aix"] | |||
There was a problem hiding this comment.
FWIW I am in the (slow) process of PR'ing a fix to Jest for this (and other modules that fail on AIX that use Jest): jestjs/jest#10263
There was a problem hiding this comment.
I included reference to why it was skipping in the commit comment so we should be able to grep / identify / unskip when this is fixed
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
=======================================
Coverage 96.17% 96.17%
=======================================
Files 30 30
Lines 889 889
=======================================
Hits 855 855
Misses 34 34 Continue to review full report at Codecov.
|
targos
approved these changes
Jul 21, 2020
|
ran tests locally... landing without waiting for CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both are currently consistently flaky