Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove unmarked DEP0XXX handler #685

Merged
merged 2 commits into from Sep 24, 2023
Merged

chore!: remove unmarked DEP0XXX handler #685

merged 2 commits into from Sep 24, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 8, 2023

The deprecation numbers are linted by the test-doc test suite, and using DEP0XXX would be flagged as invalid before the PR can land.

The deprecation numbers are linted by the `test-doc` test suite, and
using `DEP0XXX` would be flagged as invalid before the PR can land.
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4c2d84e) 83.38% compared to head (0f46464) 83.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #685   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files          37       37           
  Lines        4158     4158           
=======================================
  Hits         3467     3467           
  Misses        691      691           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@richardlau
Copy link
Member

The deprecation numbers are linted by the test-doc test suite, and using DEP0XXX would be flagged as invalid before the PR can land.

Is that true on all supported release lines?

@aduh95
Copy link
Contributor Author

aduh95 commented Mar 8, 2023

The deprecation numbers are linted by the test-doc test suite, and using DEP0XXX would be flagged as invalid before the PR can land.

Is that true on all supported release lines?

It seems that nodejs/node#41992 hasn't been backported to v14.x, so I guess this should wait for v14.x to be officially EOL.

@richardlau
Copy link
Member

The deprecation numbers are linted by the test-doc test suite, and using DEP0XXX would be flagged as invalid before the PR can land.

Is that true on all supported release lines?

It seems that nodejs/node#41992 hasn't been backported to v14.x, so I guess this should wait for v14.x to be officially EOL.

Thank you for checking. I suspect it's highly unlikely we'll deprecate something new in Node.js 14 before it reaches End-of-Life. I'd be okay landing if other @nodejs/releasers agree, otherwise we can wait.

@targos
Copy link
Member

targos commented Mar 8, 2023

SGTM

Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos
Copy link
Member

targos commented Apr 17, 2023

@aduh95 there's a conflict now.

@aduh95 aduh95 changed the title chore: remove unmarked DEP0XXX handler chore!: remove unmarked DEP0XXX handler Apr 17, 2023
@aduh95 aduh95 merged commit bdb85a9 into nodejs:main Sep 24, 2023
13 checks passed
@aduh95 aduh95 deleted the DEP0XXX branch September 24, 2023 09:13
This was referenced Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants