Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: remove unmarked DEP0XXX handler #685

Merged
merged 2 commits into from
Sep 24, 2023
Merged

chore!: remove unmarked DEP0XXX handler #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
177f876
chore: remove unmarked DEP0XXX handler
aduh95 Mar 8, 2023
0f46464
Merge branch 'main' into DEP0XXX
aduh95 Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
50 changes: 0 additions & 50 deletions lib/deprecations.js
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions lib/landing_session.js
View file
Open in desktop
@@ -1,9 +1,5 @@
import os from 'node:os';

import {
getUnmarkedDeprecations,
updateDeprecations
} from './deprecations.js';
import {
runAsync, runSync, forceRunAsync
} from './run.js';
Expand Down Expand Up @@ -129,23 +125,6 @@ export default class LandingSession extends Session {
process.exit(1);
}

// Check for and maybe assign any unmarked deprecations in the codebase.
if (this.updateDeprecations !== 'yes') {
const unmarkedDeprecations = await getUnmarkedDeprecations();
const unmarkedDepCount = unmarkedDeprecations.length;
if (unmarkedDepCount > 0) {
cli.startSpinner('Assigning deprecation numbers to DEPOXXX items');

// Update items then stage files and amend the last commit.
await updateDeprecations(unmarkedDeprecations);
await runAsync('git', ['add', 'doc', 'lib', 'src', 'test']);
await runAsync('git', ['commit', '--amend', '--no-edit', ...this.gpgSign]);

cli
.stopSpinner(`Updated ${unmarkedDepCount} DEPOXXX items in codebase`);
}
}

cli.ok('Patches applied');
return commitInfo;
}
Expand Down
24 changes: 0 additions & 24 deletions lib/prepare_release.js
View file
Open in desktop
Expand Up @@ -7,10 +7,6 @@ import replace from 'replace-in-file';
import { getMergedConfig } from './config.js';
import { runAsync, runSync } from './run.js';
import { writeJson, readJson } from './file.js';
import {
getUnmarkedDeprecations,
updateDeprecations
} from './deprecations.js';
import {
getEOLDate,
getStartLTSBlurb,
Expand Down Expand Up @@ -142,26 +138,6 @@ export default class ReleasePreparation {
await this.updateREPLACEMEs();
cli.stopSpinner('Updated REPLACEME items in docs');

// Check for and maybe assign any unmarked deprecations in the codebase.
const unmarkedDeprecations = await getUnmarkedDeprecations();
const unmarkedDepCount = unmarkedDeprecations.length;
if (unmarkedDepCount > 0) {
if (unmarkedDepCount === 1) {
cli.startSpinner(
'Assigning deprecation number to DEPOXXX item');
await updateDeprecations(unmarkedDeprecations);
cli.stopSpinner('Assigned deprecation numbers to DEPOXXX items');
} else {
cli.warn(
'More than one unmarked DEPOXXX item - manual resolution required.');

await cli.prompt(
`Finished updating ${unmarkedDepCount} unmarked DEPOXXX items?`,
{ defaultAnswer: false });
cli.stopSpinner(`Finished updating ${unmarkedDepCount} DEPOXXX items`);
}
}

// Fetch date to use in release commit & changelogs.
const todayDate = new Date().toISOString().split('T')[0];
this.date = await cli.prompt('Enter release date in YYYY-MM-DD format:',
Expand Down