Always read labelling config from the master branch
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of reading the labelling config from the target branch/SHA, which for the nodejs/node project might be a staging branch. Always having to cherry-pick labelling config changes merged to the master branch, into different staging branches is very inconvenient and will be forgotten from time to time.
targos
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of reading the labelling config from the target branch/SHA, which for the nodejs/node project might be a staging branch.
As observed by @targos, always having to cherry-pick labelling config changes merged to the master branch, into different staging branches is very inconvenient and will be forgotten from time to time.
Let's instead always read the labelling config from the master branch.
Refs nodejs/node#38301 (comment)
/cc @nodejs/github-bot