fix: code repetition per code review

nodejs · Sep 24, 2022 · 1a7aae6 · 1a7aae6
1 parent 0a210f3
commit 1a7aae6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/doc/api/util.md b/doc/api/util.md
@@ -1033,7 +1033,7 @@ added:
 changes:
   - version: REPLACEME
     pr-url: https://github.com/nodejs/node/pull/44631
-    description: add support for default values in input `config`.
+    description: Add support for default values in input `config`.
   - version:
     - v18.7.0
     - v16.17.0

diff --git a/lib/internal/util/parse_args/parse_args.js b/lib/internal/util/parse_args/parse_args.js
@@ -333,15 +333,17 @@ const parseArgs = (config = kEmptyObject) => {
 
       const defaultValue = objectGetOwn(optionConfig, 'default');
       if (defaultValue !== undefined) {
-        if (optionType === 'string' && !multipleOption) {
-          validateString(defaultValue, `options.${longOption}.default`);
-        } else if (optionType === 'string' && multipleOption) {
-          validateStringArray(defaultValue, `options.${longOption}.default`);
-        } else if (optionType === 'boolean' && !multipleOption) {
-          validateBoolean(defaultValue, `options.${longOption}.default`);
-        } else if (optionType === 'boolean' && multipleOption) {
-          validateBooleanArray(defaultValue, `options.${longOption}.default`);
+        let validator;
+        switch (optionType) {
+          case 'string':
+            validator = multipleOption ? validateStringArray : validateString;
+            break;
+
+          case 'boolean':
+            validator = multipleOption ? validateBooleanArray : validateBoolean;
+            break;
         }
+        validator(defaultValue, `options.${longOption}.default`);
       }
     }
   );