http2,perf_hooks: perf state using AliasedBuffer #18300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
addaleax
approved these changes
Jan 22, 2018
addaleax
added
http2
mike-kaufman
approved these changes
Jan 23, 2018
|
CI rerun: https://ci.nodejs.org/job/node-test-pull-request/12689/ Looks like the Windows leg is hitting #18269. Everything else is passing. |
|
@jasnell do you have a moment to take a look? |
|
Final (hopefully) rerun: https://ci.nodejs.org/job/node-test-pull-request/12712/ Looks like there are a couple of unrelated issues. |
addaleax
added
the
author ready
jasnell
approved these changes
Jan 24, 2018
kfarnung
force-pushed
the
perf_buffers
branch
from
4a5187d
to
be2cbcc
Compare
|
Landed in be2cbcc |
2 tasks
|
I created a backport PR #18364 |
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Jan 25, 2018
Update performance_state to use AliasedBuffer and update usage sites. PR-URL: nodejs/node#18300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Jan 25, 2018
Update performance_state to use AliasedBuffer and update usage sites. PR-URL: nodejs/node#18300 Backport-PR-URL: nodejs#453 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mike Kaufman <mike.kaufman@microsoft.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
Update performance_state to use AliasedBuffer and update usage sites. PR-URL: #18300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
kfarnung
added a commit
to kfarnung/node
that referenced
this pull request
Feb 2, 2018
Update performance_state to use AliasedBuffer and update usage sites. PR-URL: nodejs#18300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
removed
the
author ready
kjin
pushed a commit
to kjin/node
that referenced
this pull request
May 1, 2018
This is the portion of be2cbcc that is not in dea44b9. Update performance_state to use AliasedBuffer and update usage sites. PR-URL: nodejs#18300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Update performance_state to use AliasedBuffer and update usage sites. PR-URL: nodejs#18300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update performance_state to use AliasedBuffer and update usage sites.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2, perf_hooks