Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api,test: add a new.target test to addons-napi #19236

Merged
merged 1 commit into from Mar 12, 2018
Merged

n-api,test: add a new.target test to addons-napi #19236

merged 1 commit into from Mar 12, 2018

Conversation

kfarnung
Copy link
Contributor

@kfarnung kfarnung commented Mar 8, 2018

Added a N-API test to verify new.target behavior.

Originally added to node-chakracore by @boingoing.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@kfarnung kfarnung self-assigned this Mar 8, 2018
@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Mar 8, 2018
@kfarnung
Copy link
Contributor Author

kfarnung commented Mar 8, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13595/

mhdawson
mhdawson approved these changes Mar 8, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

boingoing
boingoing approved these changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@boingoing boingoing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kfarnung
Copy link
Contributor Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/13643/

@boingoing @kfarnung
n-api,test: add a new.target test to addons-napi
a03c90b 
Added a N-API test to verify new.target behavior.

PR-URL: nodejs#19236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@kfarnung kfarnung merged commit a03c90b into nodejs:master Mar 12, 2018
@kfarnung
Copy link
Contributor Author

Landed in a03c90b

@kfarnung kfarnung deleted the napitest branch March 12, 2018 19:07
targos pushed a commit that referenced this pull request Mar 17, 2018
@boingoing @targos
n-api,test: add a new.target test to addons-napi
6c96300 
Added a N-API test to verify new.target behavior.

PR-URL: #19236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@boingoing @MylesBorins
n-api,test: add a new.target test to addons-napi
f36521b 
Added a N-API test to verify new.target behavior.

PR-URL: #19236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 12, 2018
@boingoing
n-api,test: add a new.target test to addons-napi
2cfd4fe 
Added a N-API test to verify new.target behavior.

PR-URL: nodejs#19236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
@boingoing
n-api,test: add a new.target test to addons-napi
b0e458a 
Added a N-API test to verify new.target behavior.

PR-URL: nodejs#19236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@boingoing @MylesBorins
n-api,test: add a new.target test to addons-napi
3f6d80e 
Added a N-API test to verify new.target behavior.

Backport-PR-URL: #19447
PR-URL: #19236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 1, 2018
@boingoing @MylesBorins
n-api,test: add a new.target test to addons-napi
4c1181d 
Added a N-API test to verify new.target behavior.

Backport-PR-URL: #19265
PR-URL: #19236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@boingoing @MayaLekova
n-api,test: add a new.target test to addons-napi
84e152d 
Added a N-API test to verify new.target behavior.

PR-URL: nodejs#19236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@daynin daynin daynin approved these changes

@boingoing boingoing boingoing approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

@kfarnung kfarnung

Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kfarnung @jasnell @daynin @boingoing @mhdawson @nodejs-github-bot