v9.9.0 proposal #19428
Merged
v9.9.0 proposal #19428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Separate all loose and strict functions. 2) Stronger outline the used comparison rules in (not)deepStrictEqual 3) Fix SameValue comparison info Backport-PR-URL: #19230 PR-URL: #17002 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs-github-bot
added
lib / src
|
This is the first time I prepare a release. Please tell me if something is wrong :) /cc @nodejs/release |
targos
removed
the
lib / src
Requireing the strict version will allow to use `assert.equal`, `assert.deepEqual` and there negated counterparts to be used with strict comparison instead of using e.g. `assert.strictEqual`. The API is identical to the regular assert export and only differs in the way that all functions use strict compairson. Backport-PR-URL: #19230 PR-URL: #17002 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Right now it is difficult to know what argument stands for what property. By refactoring the arguments into a object it is clear what stands for what. Backport-PR-URL: #19230 PR-URL: #17582 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Throw a TypeError in case a error message is provided in the second argument and a third argument is present as well. This is clearly a mistake and should not be done. Backport-PR-URL: #19230 PR-URL: #17585 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
It was not clear why the error name is actually also tested for when using a regular expression. This is now clarified. Backport-PR-URL: #19230 PR-URL: #17585 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
From now on it is possible to use a validation object in throws instead of the other possibilites. Backport-PR-URL: #19230 PR-URL: #17584 Refs: #17557 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Using `assert()` or `assert.ok()` resulted in a error since a refactoring. Refs: #17582 Backport-PR-URL: #19230 PR-URL: #17903 Refs: #17582 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
And make `assert.doesNotThrow()` handle it as well. Backport-PR-URL: #19230 PR-URL: #18029 Fixes: #18027 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The current default formatting is not ideal and this improves
the situation by formatting the output more intuitiv.
1) All object keys are now indented by 2 characters instead of
sometimes 2 and sometimes 3 characters.
2) Each object key will now use an individual line instead of
sharing a line potentially with multiple object keys.
3) Long strings will now be split into multiple lines in case
they exceed the "lineBreak" option length (including the
current indentation).
4) Opening braces are now directly behind a object property
instead of using a new line.
5) Switch inspect "base" order. In case the compact option is set
to `false`, inspect will now print
"[Function: foo] {\n property: 'data'\n}"
instead of
"{ [Function: foo]\n property: 'data'\n}".
Backport-PR-URL: #19230
PR-URL: #17576
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Right now it is very difficult to determine if a terminal supports colors or not. This function adds this functionality by detecting environment variables and checking process. Backport-PR-URL: #19230 PR-URL: #17615 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Right now it is not documentated that WeakMap entries are not compared. This might result in some confusion. This adds a note about the behavior in `assert.deepStrictEqual`. This documentation is also references in `util.isDeepStrictEqual`, so we do not have to document it again for that function as the underlying algorithm is the same. Backport-PR-URL: #19230 PR-URL: #18248 Fixes: #18228 Refs: #18228 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
In rare cirumstances it is possible to get a identical error diff. In such a case the advances diffing runs into a infinite loop. This fixes it by properly checking for extra entries. Backport-PR-URL: #19230 PR-URL: #18611 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Right now it is possible to get an AssertionError from input that has the customInspect function set to always return the same value. That way the error message is actually misleading because the output is going to look the same. This fixes it by deactivating the custom inspect function. Backport-PR-URL: #19230 PR-URL: #18611 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
test-performance can fail due to resource constraints. Move it from parallel to sequential so it does not compete with other tests for resources. Fixes: #19197 PR-URL: #19228 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
82bdf8f fixed an issue by silently modifying the `start` option for the case when only `end` is passed, in order to perform reads from a specified range in the file. However, that approach does not work for non-seekable files, since a numeric `start` option means that positioned reads will be used to read data from the file. This patch fixes that, and instead ends reading after a specified size by adjusting the read buffer size. This way we avoid re-introducing the bug that 82bdf8f fixed, and align behaviour with the native file stream mechanism introduced in #18936 as well. PR-URL: #19329 Fixes: #19240 Refs: #18121 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chen Gang <gangc.cxy@foxmail.com>
Did not remove ActivationsFinder from `src/runtime/runtime-compiler.cc`
as in the original commit as the Class is still being used prior to
f0acede landing
Original Commit Message:
Deoptimization and multithreading.
When using Lockers and Unlockers it is possible to create a
scenario where multiple threads point to the same optimized
code object. When that happens, if one of the threads triggers
deoptimization, then the stack replacement needs to happen in
the stacks of all threads.
With this CL, the deoptimizer visits all threads to do so.
The CL also adds three tests where V8 used to crash due to this
issue.
Bug: v8:6563
Change-Id: I74e9af472d4833aa8d13e579df45133791f6a503
Reviewed-on: https://chromium-review.googlesource.com/670783
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Juliana Patricia Vicente Franco <jupvfranco@google.com>
Cr-Commit-Position: refs/heads/master@{#48060}
PR-URL: #19477
Fixes: #19274
Refs: v8/v8@596d55a
Refs: v8/v8@f0acede
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
This commit add SetUpTestCase and TearDownTestCase functions that will be called once per test case. Currently we only have SetUp/TearDown which are called for each test. This commit moves the initialization and configuration of Node and V8 to be done on a per test case basis, but gives each test a new Isolate. Backport-PR-URL: #19504 PR-URL: #18558 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This adds puctiations to the comments, uses a capital letters for the first character, removes a few obsolete comments and switches to assert.ok when suitable. It also moves all `assert.deepEqual()` and `assert.deepStrictEqual()` tests to the appropriate file. Backport-PR-URL: #19244 PR-URL: #18610 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
There is actually no reason to use `assert.doesNotThrow()` in the tests. If a test throws, just let the error bubble up right away instead of first catching it and then rethrowing it. Backport-PR-URL: #19244 PR-URL: #18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Add punctuation and comments about code that should not throw. Also remove a obsolete test and refactor some tests. Backport-PR-URL: #19244 PR-URL: #18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Prohibit the usage of `assert.doesNotThrow()`. Backport-PR-URL: #19244 PR-URL: #18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This enables the `no-unsafe-finally` eslint rule to make sure we have a proper control flow in try / catch. Backport-PR-URL: #19244 PR-URL: #18745 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This also fixes the three entries that did not pass. Backport-PR-URL: #19244 PR-URL: #18831 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Backport-PR-URL: #19244 PR-URL: #18831 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Backport-PR-URL: #19244 PR-URL: #18831 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Backport-PR-URL: #19244 PR-URL: #18831 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This implements a function based system. Instead of passing in the error code as first argument, the error code itself is a error class. It already contains the correct error type, so while adding a new error no one has to think about the error type anymore. In case a single error code has more than one error type, the error class has properties for the non default error types. Those can be used as fallback. This prevents typos, makes the implementation easier and it is less verbose when writing the code for a new error. The implementation itself does not interfere with the old implementation. So the old and the new system can co-exist and it is possible to slowly migrate the old ones to the new system. Backport-PR-URL: #19244 PR-URL: #18857 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This updates all internal errors to the new error type. While doing so it removes unused errors. A few errors currently seem to have the wrong type. To identify them later, comments were added next to the error type. Backport-PR-URL: #19244 PR-URL: #18857 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Some error types are not properly set. This adds comments which ones are probably falty and to what they should be set instead. Backport-PR-URL: #19244 PR-URL: #18857 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Backport-PR-URL: #19244 PR-URL: #17919 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Lance Ball <lball@redhat.com>
Backport-PR-URL: #19244 PR-URL: #17919 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Lance Ball <lball@redhat.com>
There should be no default error handling when using Http2Stream. All errors will end up in `'streamError'` on the server anyway, but they are emitted on `'stream'` as well, otherwise some error conditions are impossible to debug. See: #14991 Backport-PR-URL: #19478 PR-URL: #19232 Reviewed-By: James M Snell <jasnell@gmail.com>
Notable changes:
* assert:
- From now on all error messages produced by `assert` in strict mode
will produce a error diff. (Ruben Bridgewater)
#17615
- From now on it is possible to use a validation object in throws
instead of the other possibilities. (Ruben Bridgewater)
#17584
* crypto:
- allow passing null as IV unless required (Tobias Nießen)
#18644
* fs:
- support as and as+ flags in stringToFlags() (Sarat Addepalli)
#18801
* tls:
- expose Finished messages in TLSSocket (Anton Salikhmetov)
#19102
* tty:
- Add getColorDepth function to determine if terminal supports colors
(Ruben Bridgewater) #17615
* util:
- add util.inspect compact option (Ruben Bridgewater)
#17576
* **Added new collaborators**
- [watson](https://github.com/watson) Thomas Watson
PR-URL: #19428
MylesBorins
force-pushed
the
v9.9.0-proposal
branch
from
0c54faf
to
74fb02f
Compare
MylesBorins
added a commit
that referenced
this pull request
Mar 21, 2018
Notable changes:
* assert:
- From now on all error messages produced by `assert` in strict mode
will produce a error diff. (Ruben Bridgewater)
#17615
- From now on it is possible to use a validation object in throws
instead of the other possibilities. (Ruben Bridgewater)
#17584
* crypto:
- allow passing null as IV unless required (Tobias Nießen)
#18644
* fs:
- support as and as+ flags in stringToFlags() (Sarat Addepalli)
#18801
* tls:
- expose Finished messages in TLSSocket (Anton Salikhmetov)
#19102
* tty:
- Add getColorDepth function to determine if terminal supports colors
(Ruben Bridgewater) #17615
* util:
- add util.inspect compact option (Ruben Bridgewater)
#17576
* **Added new collaborators**
- [watson](https://github.com/watson) Thomas Watson
PR-URL: #19428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-03-21, Version 9.9.0 (Current), @MylesBorins prepared by @targos
Notable Changes
assertin strict mode will produce a error diff. (Ruben Bridgewater) #17615Commits
acc86ed246] - 2018-03-XX, Version 9.9.0 (Current) (Michaël Zasso)8d33e5c214] - assert: improve error check (Ruben Bridgewater) #175745e6b42ec9c] - assert: show proper differences (Ruben Bridgewater) #186119abbb6b857] - assert: fix infinite loop (Ruben Bridgewater) #18611e9ac468146] - assert: fix throws trace (Ruben Bridgewater) #18595d3c2534bbe] - assert: use destructuring for errors (Ruben Bridgewater) #182475aa3a2d172] - (SEMVER-MINOR) assert: improve error messages (Ruben Bridgewater) #17615f96ea47cf5] - assert: fix strict regression (Ruben Bridgewater) #17903ebd60fa505] - (SEMVER-MINOR) assert: .throws accept objects (Ruben Bridgewater) #17584612ba1a3f0] - (SEMVER-MINOR) assert: improve assert.throws (Ruben Bridgewater) #1758524aeca7dd5] - assert: fix throws and doesNotThrow stack frames (Ruben Bridgewater) #17703db73d1c13b] - assert: use object argument in innerFail (Ruben Bridgewater) #17582bae5de1949] - (SEMVER-MINOR) assert: add strict functionality export (Ruben Bridgewater) #17002f0f31d080a] - async_hooks: add copyHooks function (Daniel Bevenius) #1939171b1c7f79f] - async_hooks: don't set hook_fields[kTotals] to 0 (Daniel Bevenius) #19219530b8a4077] - benchmark: fix benchmark for url (Sergey Golovin) #19084563bed00f5] - benchmark,lib,test,tools: use consistent quotes (Rich Trott) #191563f7c4eea04] - build: do not cd on vcbuild help (Vse Mozhet Byt) #192915a1437cdbd] - build: update arm64 minimum supported platform (Gibson Fahnestock) #1916407845fc19e] - console: port errors to new system (Ruben Bridgewater) #1885703c321a713] - (SEMVER-MINOR) crypto: allow passing null as IV unless required (Tobias Nießen) #18644044995e546] - crypto: use bool over int consistently (Tobias Nießen) #1923836f664ef9a] - deps: V8: backport 596d55a from upstream (Myles Borins) #194775966b8cc06] - deps: v8: cherry-pick fixes for v8:7535 (Flarna) #19333cb732aeda4] - doc: enable eslint prefer-template rule (Ruben Bridgewater) #18831ff82acb95a] - doc: update buffer examples (Ruben Bridgewater) #18758a4c28d77f7] - doc: fix deprecation removed by mistake (Michaël Zasso) #19482b229912f6f] - doc: do not announce obvious examples (Rich Trott) #19270c1fa0926e3] - doc: fix typos on n-api (Kyle Robinson Young) #1938599e6734f19] - doc: improve best practices in onboarding-extras (Rich Trott) #193155a56327e79] - doc: fix minor issues in async_hooks.md (Rich Trott) #193135da3ee7719] - doc: clarify default TLS handshake timeout (Rich Trott) #192907f652c2bcc] - doc: update username and email (Yuta Hiroto) #19338e247f19ac3] - doc: improve style guide text (Rich Trott) #19269c9b12f302a] - doc: remove superfluous text in onboarding-extras (Rich Trott) #192476c5afebf55] - doc: make caveat in stream.md more concise (Rich Trott) #192518e88a180b9] - doc: add warning to assert.doesNotThrow() (Ruben Bridgewater) #18699a04e4ae5e4] - doc: remove confusing "cats" from style guide (Rich Trott) #192467c3617558e] - doc: remove superfluous adverb from style guide (Rich Trott) #19246d117f5ff22] - doc: remove warning against readable/readable.read (Rich Trott) #191935c21d16c31] - doc: add watson to collaborators (Thomas Watson) #192349557e66ae1] - doc: update labels info in onboarding-extras.md (Rich Trott) #1916084acb9fae5] - doc: add inspector usage example (Ali Ijaz Sheikh) #1917227088cfaa7] - doc: improve onboarding instructions (Joyee Cheung) #191089ec0eab019] - doc: make suggestion more direct in stream.md (Rich Trott) #19124968b867bf2] - doc: document asserts Weak(Map|Set) behavior (Ruben Bridgewater) #18248745709396c] - (SEMVER-MINOR) doc: improve .throws RegExp info (Ruben Bridgewater) #175855a78c6c0a6] - (SEMVER-MINOR) doc: improve assert documentation (Ruben Bridgewater) #17002f4f0266bfe] - errors: add comments about falsy error types (Ruben Bridgewater) #18857ffa16aad60] - errors: update all internal errors (Ruben Bridgewater) #18857d57a2421fc] - errors: implement new error handling (Ruben Bridgewater) #18857607b33cfcc] - (SEMVER-MINOR) fs: support as and as+ flags in stringToFlags() (Sarat Addepalli) #18801b01bd800c6] - fs: fixcreateReadStream(…, {end: n})for non-seekable fds (Anna Henningsen) #193293914e97741] - http2: fixes error handling (Matteo Collina) #192323bf69cd3e7] - http2: some general code improvements (James M Snell) #194004277635bed] - http2: clean up Http2Settings (James M Snell) #1940042b6d801dc] - http2: don't aggressively inline (James M Snell) #1940089fbbc48ff] - http2: simplify timeout tracking (Anna Henningsen) #19206f06622cd56] - lib: define printErr() in script string (cjihrig) #19285b35eabb837] - lib: handlethrow undefinedin assert.throws() (Ben Noordhuis) #180290e6f720991] - n-api: separate out async_hooks test (Gabriel Schulhof) #19392528798c3f4] - n-api: add missing exception checking (Michael Dawson) #19362f679ac19e0] - n-api: resolve promise in test (Gabriel Schulhof) #1924512f19a6b86] - n-api: update documentation (Gabriel Schulhof) #190780c9577edfc] - n-api,test: add int64 bounds tests (Kyle Farnung) #19309f36521becf] - n-api,test: add a new.target test to addons-napi (Taylor Woll) #192365b12d3a58e] - net: do not inherit the no-half-open enforcer (Luigi Pinca) #18974a9bd8bff8a] - path: remove redundant function (Sergey Golovin) #1923755f7bbb0bd] - repl: refactor code for readability (Ruben Bridgewater) #179196997af7378] - repl: upper case comments first char (Ruben Bridgewater) #179193e6858e4a7] - repl: better handling of recoverable errors (Prince J Wesley) #1891549391a70e1] - src: fix util abort (Ruben Bridgewater) #192231ba1861731] - src: remove unused using declarations async_wrap (Daniel Bevenius) #188938757799d69] - src: remove unused stdlib.h include (Daniel Bevenius) #19427da62c5ca68] - src: fix minor typo in comment stream_base.h (Daniel Bevenius) #1942943c482b9c8] - src: fix indentation of params in env-inl.h (Daniel Bevenius) #19390054dd28da6] - src: make AsyncWrap constructors delegate (Daniel Bevenius) #193667a3d1d205e] - src: remove unused uv.h include from async_wrap.cc (Daniel Bevenius) #19342126a161928] - src: fix indenting of wrap->EmitTraceEventBefore (Daniel Bevenius) #1934003fb817a1d] - src: add extractPromiseWrap function (Daniel Bevenius) #19340e208282f68] - src: refactor emit before/after/promiseResolve (Daniel Bevenius) #1929549481d0e3b] - src: add convenience ctor for async trigger id scope (Anna Henningsen) #192044b9914a318] - src: avoid duplicate Before/AtExitCallback structs (Daniel Bevenius) #1922627754c5408] - src: add incr/decr operators for Reference (Daniel Bevenius) #1908364f646269a] - src: use smart pointer in AsyncWrap::WeakCallback (Daniel Bevenius) #19168152c931f53] - stream: make Duplex inherits from DuplexBase (Luigi Pinca) #189749c0c0e68ac] - stream: add no-half-open enforcer only if needed (Luigi Pinca) #189531eac1d7d85] - test: minor refactoring (Ruben Bridgewater) #18669574d061c3c] - test: remove assert.doesNotThrow() (Ruben Bridgewater) #186695478746203] - test: refactor assert test (Ruben Bridgewater) #186104e9279df5c] - test: remove NodeTestFixture from Env constructor (Daniel Bevenius) #1855822b8f9fba6] - test: introduce SetUpTestCase/TearDownTestCase (Daniel Bevenius) #18558519850f21e] - test: http2 client setNextStreamID errors (Trivikram) #18848e3ce084f7c] - test: fix flaky test-http2-ping-flood (Rich Trott) #193957df6d9ddc8] - test: rename regression tests file names (Ujjwal Sharma) #19332f49042131a] - test: use descriptive names for regression tests (Ujjwal Sharma) #1927501749f07bd] - test: fix flaky test-http2-settings-flood (Rich Trott) #193499aa5090689] - test: fix test-cluster-send-handle-large-payload (Rich Trott) #1931111a0ef566a] - test: delete test/parallel/test-regress-GH-4948 (Ujjwal Sharma) #19279be20914958] - test: shared lib build doesn't handle SIGPIPE (Yihong Wang) #19211f84f548986] - test: fix assertion argument order (Rich Trott) #1926484ae59e5f8] - test: fix path in doctool/test-doctool-json (Vse Mozhet Byt) #19287b8ca616baa] - test: fix compiler warnings in callback-scope (Daniel Bevenius) #19252d3bc72e9cc] - test: name test files appropriately (Ujjwal Sharma) #19212f0c8f6969f] - test: fix test-abort-backtrace in shared lib build (Yihong Wang) #19213e4c320e5d7] - test: Remove unnecessary asserion messages in test-crypto-hash.js (Piotr Grzesik) #18984411f3e03fe] - test: remove flaky status for test-npm-install (Rich Trott) #19216a4a4819954] - test: do not check text for engine-generated error (Rich Trott) #1921538eb432260] - test: refactor http-https-default-ports (Ken Lin) #191300ece7cc227] - test: rename test-regress-io.js remote debuging is EXTREMELY slow compared to Node.js 0.10 #877.js (Ujjwal Sharma) #19161636a5f627e] - test: rename test-regress-Chunked stdout/stderr drops writes if terminated early. #784.js (Ujjwal Sharma) #19161c0c6d5848f] - test: address nits and rename the corresponding fixture (Ujjwal Sharma) #1916122484e1fb2] - test: rename tests to remove "regress" keyword (Ujjwal Sharma) #191612262a34f0b] - test: rename test-regress-test: move ArrayStream to common #4027 (Ujjwal Sharma) #19161bdbfc0e20e] - test: rename test-regress-test: use platform-based timeout for reliability #4015 (Ujjwal Sharma) #19161da44c2ccf0] - test: rename test-regress-TSC needs to elect a board representative. #1697 (Ujjwal Sharma) #19161fa43d2f69e] - test: rename test-regress-Add more robust option parsing [WIP] #1726 (Ujjwal Sharma) #1916146b5915dab] - test: skip postmortem metadata test when nm fails (Joyee Cheung) #1910716ab3b54d1] - test: address unreliable test-performance (Rich Trott) #192281e5c7e3e47] - test: refactor common.expectsError (Ruben Bridgewater) #17703060216689a] - (SEMVER-MINOR) tls: expose Finished messages in TLSSocket (Anton Salikhmetov) #19102b04dd7b351] - tools: enable eslint one-var rule (Ruben Bridgewater) #18831d4d7df8371] - tools: enable eslint strict key-spacing (Ruben Bridgewater) #188319e10ddc215] - tools: enable eslint no-undef-init rule (Ruben Bridgewater) #188319d1e409ee3] - tools: enable no-unsafe-finally (Ruben Bridgewater) #18745d7958657d7] - tools: add assert.doesNotThrow eslint rule (Ruben Bridgewater) #1866966694e28b1] - tools: fix test-npm-package (Michaël Zasso) #192939613e02ff7] - tools,bootstrap: preprocess gypi files to json (Gus Caplan) #1914074f0d1aa60] - (SEMVER-MINOR) tty: refactor to es6 (Ruben Bridgewater) #17615ead727c274] - (SEMVER-MINOR) tty: add getColorDepth function (Ruben Bridgewater) #17615072adfea8c] - url: replace "magic" numbers by constants (Sergey Golovin) #19035c18ac52970] - (SEMVER-MINOR) util: add util.inspect compact option (Ruben Bridgewater) #17576ce3a5af69f] - (SEMVER-MINOR) util: rename util.inspect argument (Ruben Bridgewater) #17576fd4c05ab56] - (SEMVER-MINOR) util: fix custom inspect description (Ruben Bridgewater) #17576