v9.9.0 proposal

.eslintrc.yaml

@@ -137,8 +137,11 @@ rules:
   no-mixed-spaces-and-tabs: error
   no-multiple-empty-lines: [error, {max: 2, maxEOF: 0, maxBOF: 0}]
   no-restricted-syntax: [error, {
+    selector: "CallExpression[callee.object.name='assert'][callee.property.name='doesNotThrow']",
+    message: "Please replace `assert.doesNotThrow()` and add a comment next to the code instead."
+  }, {
     selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])",
-    message: "use a regular expression for second argument of assert.throws()"
+    message: "Use a regular expression for second argument of assert.throws()"
   }, {
     selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.length<2]",
     message: "assert.throws() must be invoked with at least two arguments."
@@ -154,6 +157,7 @@ rules:
   }]
   no-tabs: error
   no-trailing-spaces: error
+  no-unsafe-finally: error
   object-curly-spacing: [error, always]
   one-var-declaration-per-line: error
   operator-linebreak: [error, after]

BUILDING.md

@@ -39,7 +39,8 @@ in production.
 
 |  System      | Support type | Version                          | Architectures        | Notes            |
 |--------------|--------------|----------------------------------|----------------------|------------------|
-| GNU/Linux    | Tier 1       | kernel >= 2.6.32, glibc >= 2.12  | x64, arm, arm64      |                  |
+| GNU/Linux    | Tier 1       | kernel >= 2.6.32, glibc >= 2.12  | x64, arm             |                  |
+| GNU/Linux    | Tier 1       | kernel >= 3.10, glibc >= 2.17    | arm64                |                  |
 | macOS        | Tier 1       | >= 10.10                         | x64                  |                  |
 | Windows      | Tier 1       | >= Windows 7/2008 R2             | x86, x64             | vs2017           |
 | SmartOS      | Tier 2       | >= 15 < 16.4                     | x86, x64             | see note1        |

CHANGELOG.md

@@ -29,7 +29,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V9.md#9.8.0">9.8.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V9.md#9.9.0">9.9.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V9.md#9.7.1">9.8.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V9.md#9.7.1">9.7.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V9.md#9.7.0">9.7.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V9.md#9.6.1">9.6.1</a><br/>

COLLABORATOR_GUIDE.md

@@ -469,10 +469,11 @@ $ npm install -g node-core-utils
 $ git node land $PRID
 ```
 
-If it's the first time you ever use `node-core-utils`, you will be prompted
-to type the password of your GitHub account in the console so the tool can
-create the GitHub access token for you. If you do not want to do that, follow
-[the guide of `node-core-utils`][node-core-utils-credentials]
+If it's the first time you have used `node-core-utils`, you will be prompted
+to type the password of your GitHub account and the two-factor authentication
+code in the console so the tool can create the GitHub access token for you.
+If you do not want to do that, follow
+[the `node-core-utils` guide][node-core-utils-credentials]
 to set up your credentials manually.
 
 ### Technical HOWTO

README.md

@@ -291,8 +291,6 @@ For more information about the governance of the Node.js project, see
 
 ### Collaborators
 
-* [abouthiroppy](https://github.com/abouthiroppy) -
-**Yuta Hiroto** <hello@about-hiroppy.com> (he/him)
 * [addaleax](https://github.com/addaleax) -
 **Anna Henningsen** <anna@addaleax.net> (she/her)
 * [ak239](https://github.com/ak239) -
@@ -367,6 +365,8 @@ For more information about the governance of the Node.js project, see
 **Guy Bedford** <guybedford@gmail.com> (he/him)
 * [hashseed](https://github.com/hashseed) -
 **Yang Guo** <yangguo@chromium.org> (he/him)
+* [hiroppy](https://github.com/hiroppy) -
+**Yuta Hiroto** <hello@hiroppy.me> (he/him)
 * [iarna](https://github.com/iarna) -
 **Rebecca Turner** <me@re-becca.org>
 * [imran-iq](https://github.com/imran-iq) -
@@ -509,6 +509,8 @@ For more information about the governance of the Node.js project, see
 **Vse Mozhet Byt** <vsemozhetbyt@gmail.com> (he/him)
 * [watilde](https://github.com/watilde) -
 **Daijiro Wachi** <daijiro.wachi@gmail.com> (he/him)
+* [watson](https://github.com/watson) -
+**Thomas Watson** <w@tson.dk>
 * [whitlockjc](https://github.com/whitlockjc) -
 **Jeremy Whitlock** <jwhitlock@apache.org>
 * [XadillaX](https://github.com/XadillaX) -

benchmark/assert/throws.js

@@ -26,6 +26,7 @@ function main({ n, method }) {
     case 'doesNotThrow':
       bench.start();
       for (i = 0; i < n; ++i) {
+        // eslint-disable-next-line no-restricted-syntax
         assert.doesNotThrow(doesNotThrow);
       }
       bench.end(n);

benchmark/http/_chunky_http_client.js

@@ -5,8 +5,8 @@ const common = require('../common.js');
 const net = require('net');
 
 const bench = common.createBenchmark(main, {
-  len:  [1, 4, 8, 16, 32, 64, 128],
-  n:  [5, 50, 500, 2000],
+  len: [1, 4, 8, 16, 32, 64, 128],
+  n: [5, 50, 500, 2000],
   type: ['send'],
 });
 

benchmark/querystring/querystring-stringify.js

@@ -17,7 +17,7 @@ function main({ type, n }) {
     encodemany: {
       '\u0080\u0083\u0089': 'bar',
       '\u008C\u008E\u0099': 'quux',
-      xyzzy: '\u00A5q\u00A3r'
+      'xyzzy': '\u00A5q\u00A3r'
     },
     encodelast: {
       foo: 'bar',

benchmark/tls/tls-connect.js

@@ -1,7 +1,7 @@
 'use strict';
-var fs = require('fs'),
-  path = require('path'),
-  tls = require('tls');
+const fs = require('fs');
+const path = require('path');
+const tls = require('tls');
 
 const common = require('../common.js');
 const bench = common.createBenchmark(main, {

benchmark/url/legacy-vs-whatwg-url-searchparams-parse.js

@@ -2,10 +2,10 @@
 const common = require('../common.js');
 const { URLSearchParams } = require('url');
 const querystring = require('querystring');
-const inputs = require('../fixtures/url-inputs.js').searchParams;
+const searchParams = require('../fixtures/url-inputs.js').searchParams;
 
 const bench = common.createBenchmark(main, {
-  type: Object.keys(inputs),
+  searchParam: Object.keys(searchParams),
   method: ['legacy', 'whatwg'],
   n: [1e6]
 });
@@ -19,27 +19,27 @@ function useLegacy(n, input) {
   bench.end(n);
 }
 
-function useWHATWG(n, input) {
-  new URLSearchParams(input);
+function useWHATWG(n, param) {
+  new URLSearchParams(param);
   bench.start();
   for (var i = 0; i < n; i += 1) {
-    new URLSearchParams(input);
+    new URLSearchParams(param);
   }
   bench.end(n);
 }
 
-function main({ type, n, method }) {
-  const input = inputs[type];
-  if (!input) {
-    throw new Error(`Unknown input type "${type}"`);
+function main({ searchParam, n, method }) {
+  const param = searchParams[searchParam];
+  if (!param) {
+    throw new Error(`Unknown search parameter type "${searchParam}"`);
   }
 
   switch (method) {
     case 'legacy':
-      useLegacy(n, input);
+      useLegacy(n, param);
       break;
     case 'whatwg':
-      useWHATWG(n, input);
+      useWHATWG(n, param);
       break;
     default:
       throw new Error(`Unknown method ${method}`);

benchmark/url/legacy-vs-whatwg-url-searchparams-serialize.js

@@ -2,10 +2,10 @@
 const common = require('../common.js');
 const { URLSearchParams } = require('url');
 const querystring = require('querystring');
-const inputs = require('../fixtures/url-inputs.js').searchParams;
+const searchParams = require('../fixtures/url-inputs.js').searchParams;
 
 const bench = common.createBenchmark(main, {
-  type: Object.keys(inputs),
+  searchParam: Object.keys(searchParams),
   method: ['legacy', 'whatwg'],
   n: [1e6]
 });
@@ -20,8 +20,8 @@ function useLegacy(n, input, prop) {
   bench.end(n);
 }
 
-function useWHATWG(n, input, prop) {
-  const obj = new URLSearchParams(input);
+function useWHATWG(n, param, prop) {
+  const obj = new URLSearchParams(param);
   obj.toString();
   bench.start();
   for (var i = 0; i < n; i += 1) {
@@ -30,18 +30,18 @@ function useWHATWG(n, input, prop) {
   bench.end(n);
 }
 
-function main({ type, n, method }) {
-  const input = inputs[type];
-  if (!input) {
-    throw new Error(`Unknown input type "${type}"`);
+function main({ searchParam, n, method }) {
+  const param = searchParams[searchParam];
+  if (!param) {
+    throw new Error(`Unknown search parameter type "${searchParam}"`);
   }
 
   switch (method) {
     case 'legacy':
-      useLegacy(n, input);
+      useLegacy(n, param);
       break;
     case 'whatwg':
-      useWHATWG(n, input);
+      useWHATWG(n, param);
       break;
     default:
       throw new Error(`Unknown method ${method}`);

benchmark/url/url-searchparams-iteration.js

@@ -4,7 +4,7 @@ const assert = require('assert');
 const { URLSearchParams } = require('url');
 
 const bench = common.createBenchmark(main, {
-  method: ['forEach', 'iterator'],
+  loopMethod: ['forEach', 'iterator'],
   n: [1e6]
 });
 
@@ -44,15 +44,15 @@ function iterator(n) {
   assert.strictEqual(noDead[1], '3rd');
 }
 
-function main({ method, n }) {
-  switch (method) {
+function main({ loopMethod, n }) {
+  switch (loopMethod) {
     case 'forEach':
       forEach(n);
       break;
     case 'iterator':
       iterator(n);
       break;
     default:
-      throw new Error(`Unknown method ${method}`);
+      throw new Error(`Unknown method ${loopMethod}`);
   }
 }

benchmark/url/url-searchparams-read.js

@@ -3,21 +3,20 @@ const common = require('../common.js');
 const { URLSearchParams } = require('url');
 
 const bench = common.createBenchmark(main, {
-  method: ['get', 'getAll', 'has'],
+  accessMethod: ['get', 'getAll', 'has'],
   param: ['one', 'two', 'three', 'nonexistent'],
   n: [2e7]
 });
 
 const str = 'one=single&two=first&three=first&two=2nd&three=2nd&three=3rd';
 
-function main({ method, param, n }) {
+function main({ accessMethod, param, n }) {
   const params = new URLSearchParams(str);
-  const fn = params[method];
-  if (!fn)
-    throw new Error(`Unknown method ${method}`);
+  if (!params[accessMethod])
+    throw new Error(`Unknown method ${accessMethod}`);
 
   bench.start();
   for (var i = 0; i < n; i += 1)
-    fn(param);
+    params[accessMethod](param);
   bench.end(n);
 }

benchmark/url/whatwg-url-idna.js

@@ -2,7 +2,7 @@
 const common = require('../common.js');
 const { domainToASCII, domainToUnicode } = require('url');
 
-const inputs = {
+const domains = {
   empty: {
     ascii: '',
     unicode: ''
@@ -26,13 +26,13 @@ const inputs = {
 };
 
 const bench = common.createBenchmark(main, {
-  input: Object.keys(inputs),
+  domain: Object.keys(domains),
   to: ['ascii', 'unicode'],
   n: [5e6]
 });
 
-function main({ n, to, input }) {
-  const value = inputs[input][to];
+function main({ n, to, domain }) {
+  const value = domains[domain][to];
   const method = to === 'ascii' ? domainToASCII : domainToUnicode;
 
   bench.start();

common.gypi

@@ -27,7 +27,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.21',
+    'v8_embedder_string': '-node.22',
 
     # Enable disassembler for `--print-code` v8 options
     'v8_enable_disassembler': 1,