Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed OpenBSD node executable generation. #22663

Closed
wants to merge 1 commit into from
Closed

Fixed OpenBSD node executable generation. #22663

wants to merge 1 commit into from

Conversation

sylkat
Copy link

@sylkat sylkat commented Sep 2, 2018

There is a bug in the realpathSync object calling to the 'native' method which doesn't exist in this version of FS module.
Just removing that method is working well in OpenBSD.

Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x ] tests and/or benchmarks are included
  • [ x] commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v8.x labels Sep 2, 2018
@sylkat sylkat mentioned this pull request Sep 2, 2018
Closed
addaleax
addaleax approved these changes Sep 2, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this looks perfect!

@addaleax
Copy link
Member

addaleax commented Sep 2, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16966/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 2, 2018
@addaleax
Copy link
Member

addaleax commented Sep 3, 2018

Failures seem unrelated, resume CI: https://ci.nodejs.org/job/node-test-pull-request/16984/

@MylesBorins
Copy link
Member

BSD failure is a known flake

#22317

@MylesBorins
Copy link
Member

Can't check the windows failure due to 504 errors. Will check back soon. Would very much like to get this in the 8.12.0 release tomorrow as this is a fairly obvious error. Should be backported to v6.x as well.

@addaleax
Copy link
Member

addaleax commented Sep 3, 2018

@MylesBorins I would be okay with landing this without regard to the outcome of the CI runs, since this code path is never actually exercised by our CI.

MylesBorins
MylesBorins approved these changes Sep 3, 2018
View reviewed changes
Copy link
Member

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Member

landed in d478bc7

MylesBorins pushed a commit that referenced this pull request Sep 3, 2018
@sylkat @MylesBorins
src: fix bootstrap_node on bsd
d478bc7 
Currently makes a call to `realpathSync.native` which doesn't exist
on 8.x or lower

PR-URL: #22663
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins closed this Sep 3, 2018
@MylesBorins MylesBorins mentioned this pull request Sep 3, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Sep 3, 2018
@sylkat @MylesBorins
src: fix bootstrap_node on bsd
dcc3e4b 
Currently makes a call to `realpathSync.native` which doesn't exist
on 8.x or lower

PR-URL: #22663
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@sylkat
Copy link
Author

sylkat commented Sep 3, 2018

I think the failures in other system compilation have nothing to do with this patch since the code check for openbsd host before call that method..

rvagg pushed a commit that referenced this pull request Nov 24, 2018
@sylkat @rvagg
src: fix bootstrap_node on bsd
cc3045a 
Currently makes a call to `realpathSync.native` which doesn't exist
on 8.x or lower

PR-URL: #22663
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@sylkat @rvagg
src: fix bootstrap_node on bsd
2dbb0ce 
Currently makes a call to `realpathSync.native` which doesn't exist
on 8.x or lower

PR-URL: #22663
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@sylkat @MylesBorins
src: fix bootstrap_node on bsd
74d3f0b 
Currently makes a call to `realpathSync.native` which doesn't exist
on 8.x or lower

PR-URL: #22663
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@sylkat @rvagg
src: fix bootstrap_node on bsd
b27038f 
Currently makes a call to `realpathSync.native` which doesn't exist
on 8.x or lower

PR-URL: #22663
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
BethGriggs pushed a commit that referenced this pull request Mar 7, 2019
@sylkat @BethGriggs
src: fix bootstrap_node on bsd
aedc712 
Currently makes a call to `realpathSync.native` which doesn't exist
on 8.x or lower

PR-URL: #22663
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Mar 15, 2019
Merged
@beevelop beevelop mentioned this pull request Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sylkat @addaleax @MylesBorins @nodejs-github-bot