Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6.17.1 proposal #26684

Merged
merged 8 commits into from Apr 3, 2019
Merged

v6.17.1 proposal #26684

merged 8 commits into from Apr 3, 2019

Conversation

BethGriggs
Copy link
Member

@BethGriggs BethGriggs commented Mar 15, 2019 •
edited

2019-04-02, Version 6.17.1'Boron' (LTS), @BethGriggs

Node 6 is due to go End-of-Life on 2019-04-30.

Notable Changes

  • http:
    • fix error check in Execute() (Brian White) #25939

Commits

This is the last planned release for Node 6.

sylkat and others added 7 commits March 7, 2019 11:26
@sylkat @BethGriggs
src: fix bootstrap_node on bsd
aedc712 
Currently makes a call to `realpathSync.native` which doesn't exist
on 8.x or lower

PR-URL: #22663
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@jasnell @BethGriggs
doc: document that addMembership must be called once in a cluster
ad62971 
Fixes: #12572
Refs: #16240

PR-URL: #23746
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott @BethGriggs
doc: simplify CODE_OF_CONDUCT.md
1371a6f 
PR-URL: #23989
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvagg @BethGriggs
build: only check REPLACEME & DEP...X for releases
9ba5fd6 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@addaleax @BethGriggs
test: fix test-repl-envvars
b5d4649 
In 180f865, the test was changed
so that the `env` argument of `createInternalRepl()` also contained
external environment variables, because keeping them can be necessary
for spawning processes on some systems.

However, this test does not spawn new processes, and relies on the
fact that the environment variables it tests are not already set
(and fails otherwise); therefore, reverting to the original state
should fix this.

Fixes: #21451
Fixes: nodejs/build#1377
Refs: #25219

PR-URL: #25226
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mscdex @BethGriggs
http: fix error check in Execute()
8080a9b 
Refs: #24738
Fixes: #25858

PR-URL: #25939
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@richardlau @BethGriggs
build: set -blibpath: for AIX
c9d21a0 
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

Backport-PR-URL: #26478
PR-URL: #25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@nodejs-github-bot
Copy link
Collaborator

@BethGriggs build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2922/pipeline

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v6.x labels Mar 15, 2019
@refack
Copy link
Contributor

refack commented Mar 15, 2019

Running CI test preemptively: https://ci.nodejs.org/job/node-test-pull-request/21566/ to make sure the CI infra is still compatible with v6

@richardlau richardlau mentioned this pull request Mar 17, 2019
Closed
2 tasks
BridgeAR
BridgeAR approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just the notable change in the release commit message should be reformatted for plain-text.

@BethGriggs
Copy link
Member Author

There's just one open PR for v6.x that would be good to get into this release

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22119/

@BethGriggs
Copy link
Member Author

BethGriggs commented Apr 2, 2019 •
edited

CITGM against v6.x: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1792/
CITGM on v6.17.1: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1793

@BethGriggs
Copy link
Member Author

Seeing addons failures on Windows on the latest CI (https://ci.nodejs.org/job/node-test-binary-windows-2/53/), I'm assuming it is the same issue as @richardlau mentioned in nodejs/reliability#22 (comment)
/cc @nodejs/build

@richardlau richardlau mentioned this pull request Apr 2, 2019
Closed
@refack
Copy link
Contributor

refack commented Apr 2, 2019

Seeing addons failures on Windows on the latest CI

It's my fault. I'm on it.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 2, 2019 •
edited by refack

CI: https://ci.nodejs.org/job/node-test-pull-request/22121/

Failed https://ci.nodejs.org/job/node-test-binary-windows/25039/COMPILED_BY=vs2015,RUNNER=win2008r2-vs2013,RUN_SUBSET=2/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 2, 2019 •
edited by refack

CI: https://ci.nodejs.org/job/node-test-pull-request/22123/

Failed with:

09:19:48 not ok 365 sequential/test-child-process-pass-fd
09:19:48   ---
09:19:48   duration_ms: 66.383
09:19:48   severity: fail
09:19:48   stack: |-
09:19:48     timeout
09:19:48   ...

https://ci.nodejs.org/job/node-test-binary-windows/25041/COMPILED_BY=vs2015,RUNNER=win2008r2-vs2013,RUN_SUBSET=2/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 2, 2019 •
edited by refack

CI: https://ci.nodejs.org/job/node-test-pull-request/22126/

Failed:
https://ci.nodejs.org/job/node-test-binary-windows/25043/COMPILED_BY=vs2015,RUNNER=win2008r2-vs2013,RUN_SUBSET=2

@BethGriggs
Copy link
Member Author

Still trying to work out where the sequential/test-child-process-pass-fd failure on one Windows distribution is coming from 🤔 It seems to also be failing on v6.x - (https://ci.nodejs.org/job/node-test-commit/27415/)

@refack
Copy link
Contributor

refack commented Apr 2, 2019

So it seems like the issue is related to this OS issue (it causes node to start slow and hog 100% cpu for ~1 second). This specific test creates 80 sub-processes in a tight loop, and it just times out at 60 seconds (when it needs ~77).

I'm cleaning the update cache on https://ci.nodejs.org/computer/test-azure_msft-win2008r2-x64-1/ to see if that solves the issue.

@refack refack added the windows Issues and PRs related to the Windows platform. label Apr 2, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 2, 2019 •
edited by BethGriggs

CI: https://ci.nodejs.org/job/node-test-pull-request/22135/ ✅

BethGriggs added a commit that referenced this pull request Apr 3, 2019
@BethGriggs
2019-04-03, Version 6.17.1 'Boron' (LTS)
94b3b03 
Notable changes:

- http:
  - fix error check in `Execute()` (Brian White)
    [#25939](#25939)

PR-URL: #26684
@BethGriggs
2019-04-03, Version 6.17.1 'Boron' (LTS)
576c2bf 
Notable changes:

- http:
  - fix error check in `Execute()` (Brian White)
    [#25939](#25939)

PR-URL: #26684
@BethGriggs BethGriggs merged commit 576c2bf into v6.x Apr 3, 2019
BethGriggs added a commit that referenced this pull request Apr 3, 2019
@BethGriggs
Working on v6.17.2
f223bba 
PR-URL: #26684
BethGriggs added a commit that referenced this pull request Apr 3, 2019
@BethGriggs
2019-04-03, Version 6.17.1 'Boron' (LTS)
883a0d5 
Notable changes:

- http:
  - fix error check in `Execute()` (Brian White)
    [#25939](#25939)

PR-URL: #26684
BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Apr 3, 2019
@BethGriggs
Blog: v6.17.1 release post
2e708ed 
Refs: nodejs/node#26684
@BethGriggs BethGriggs mentioned this pull request Apr 3, 2019
Merged
BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Apr 3, 2019
@BethGriggs
Blog: v6.17.1 release post (#2168)
0d17c5f 
Refs: nodejs/node#26684
BethGriggs added a commit that referenced this pull request Apr 4, 2019
@BethGriggs
2019-04-03, Version 6.17.1 'Boron' (LTS)
4005f22 
Notable changes:

- http:
  - fix error check in `Execute()` (Brian White)
    [#25939](#25939)

PR-URL: #26684
@targos targos deleted the v6.17.1-proposal branch June 4, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack left review comments

@richardlau richardlau richardlau left review comments

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet