Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update prerequisites on progress towards Python 3 #25766

Closed
wants to merge 5 commits into from
Closed

build: update prerequisites on progress towards Python 3 #25766

wants to merge 5 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 28, 2019 •
edited

As recommended at #25759 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@cclauss
build: update prerequisites on progress towards Python 3
2401b0d 
As recommended at nodejs#25759 (comment)
* Python 2.6 end of life statement in 2013: https://www.python.org/dev/peps/pep-0361/#release-lifespan
* Python 2.7 end of life statement in 2019: https://www.python.org/dev/peps/pep-0373/#update
* Python 3.4 reaches it end of life in < 50 days so it should not be a target: https://devguide.python.org/#branchstatus
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jan 28, 2019
@cclauss cclauss mentioned this pull request Jan 28, 2019
Closed
4 tasks
gengjiawen
gengjiawen requested changes Jan 28, 2019
View reviewed changes
BUILDING.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Jan 28, 2019
View reviewed changes
BUILDING.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Jan 28, 2019

@nodejs/build @nodejs/documentation

@Trott
Copy link
Member

Trott commented Jan 28, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2424/

@Trott @cclauss
Link up to Prerequisites
7f9f32c 
Co-Authored-By: cclauss <cclauss@me.com>
@Trott
Copy link
Member

Trott commented Jan 28, 2019

@nodejs/python

@Trott
Copy link
Member

Trott commented Jan 28, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2425/

@cclauss cclauss mentioned this pull request Jan 29, 2019
Closed
63 tasks
@refack refack added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 29, 2019
@refack
Copy link
Contributor

refack commented Jan 29, 2019

LGTM as a semver-major move for node12

@refack refack added the python PRs and issues that require attention from people who are familiar with Python. label Jan 29, 2019
@Trott
Copy link
Member

Trott commented Jan 29, 2019

@nodejs/tsc

@ofrobots
Copy link
Contributor

This is a FYI doc-only change. Why is this semver-major?

@refack
Copy link
Contributor

refack commented Jan 30, 2019

Why is this semver-major?

I think that a formal change in supported toolchains (i.e. no longer supporting Python2.6) should be semver-major.
Effectively this frees us to break compatibility with 2.6, and to stop testing with 2.6.

ofrobots
ofrobots approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. I missed the 2.6 drop the first time around. Sorry about that.

LGTM.

@refack
Copy link
Contributor

refack commented Jan 30, 2019

I think semver-major/"breaking change" should be applied only to things that might break stuff for the end user.

FWIW, some end users do compile their own binary, and some users are downstream consumers in some way (embedders / tinkerers), so in that sense a change in the toolchain could break their usage.

@refack refack self-assigned this Jan 30, 2019
@Trott
Copy link
Member

Trott commented Jan 30, 2019

Even though this is going in as semver-major, I imagine we don't need a CITGM run for this, so I'll add the author ready label.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 30, 2019
@addaleax
Copy link
Member

Landed in bb564a3

@addaleax addaleax closed this Jan 30, 2019
addaleax pushed a commit that referenced this pull request Jan 30, 2019
@cclauss @addaleax
build: update prerequisites on progress towards Python 3
bb564a3 
As recommended at #25759 (comment)
* Python 2.6 end of life statement in 2013: https://www.python.org/dev/peps/pep-0361/#release-lifespan
* Python 2.7 end of life statement in 2019: https://www.python.org/dev/peps/pep-0373/#update
* Python 3.4 reaches it end of life in < 50 days so it should not be a target: https://devguide.python.org/#branchstatus

PR-URL: #25766
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@cclauss cclauss deleted the patch-3 branch January 30, 2019 23:50
@refack refack removed their assignment Mar 11, 2019
@BethGriggs BethGriggs mentioned this pull request Mar 26, 2019
Merged
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen requested changes

@ofrobots ofrobots ofrobots approved these changes

@refack refack refack approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. python PRs and issues that require attention from people who are familiar with Python. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cclauss @Trott @refack @ofrobots @addaleax @thefourtheye @gengjiawen @nodejs-github-bot