Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.17.1 proposal #26684

Merged
merged 8 commits into from Apr 3, 2019
Merged

v6.17.1 proposal #26684

merged 8 commits into from Apr 3, 2019

Commits on Mar 7, 2019

  1. src: fix bootstrap_node on bsd

    Currently makes a call to `realpathSync.native` which doesn't exist
    on 8.x or lower
    
    PR-URL: #22663
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    sylkat authored and BethGriggs committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    aedc712 View commit details
    Browse the repository at this point in the history
  2. doc: document that addMembership must be called once in a cluster

    Fixes: #12572
    Refs: #16240
    
    PR-URL: #23746
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    jasnell authored and BethGriggs committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    ad62971 View commit details
    Browse the repository at this point in the history
  3. doc: simplify CODE_OF_CONDUCT.md

    PR-URL: #23989
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and BethGriggs committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    1371a6f View commit details
    Browse the repository at this point in the history
  4. build: only check REPLACEME & DEP...X for releases

    PR-URL: #24575
    Refs: #24551
    Refs: #12958
    Refs: #12957
    Refs: #8325
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    rvagg authored and BethGriggs committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    9ba5fd6 View commit details
    Browse the repository at this point in the history
  5. test: fix test-repl-envvars

    In 180f865, the test was changed
    so that the `env` argument of `createInternalRepl()` also contained
    external environment variables, because keeping them can be necessary
    for spawning processes on some systems.
    
    However, this test does not spawn new processes, and relies on the
    fact that the environment variables it tests are not already set
    (and fails otherwise); therefore, reverting to the original state
    should fix this.
    
    Fixes: #21451
    Fixes: nodejs/build#1377
    Refs: #25219
    
    PR-URL: #25226
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    addaleax authored and BethGriggs committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    b5d4649 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. http: fix error check in Execute()

    Refs: #24738
    Fixes: #25858
    
    PR-URL: #25939
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    mscdex authored and BethGriggs committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    8080a9b View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2019

  1. build: set -blibpath: for AIX

    #17604 refactored the gyp files
    so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
    Restore the setting for non-shared builds.
    
    Fixes: #25444
    
    Backport-PR-URL: #26478
    PR-URL: #25447
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    richardlau authored and BethGriggs committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    c9d21a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2019

  1. 2019-04-03, Version 6.17.1 'Boron' (LTS)

    Notable changes:
    
    - http:
      - fix error check in `Execute()` (Brian White)
        [#25939](#25939)
    
    PR-URL: #26684
    BethGriggs committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    576c2bf View commit details
    Browse the repository at this point in the history