Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x] Backport update to V8 7.7 #29241

Closed
wants to merge 21 commits into from
Closed

[v12.x] Backport update to V8 7.7 #29241

wants to merge 21 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Aug 21, 2019

Shouldn't land before V8 7.7 is stable (around September 10th).

/cc @nodejs/v8-update @addaleax

Here's the current headers diff: https://gist.github.com/ee79b943316ea502a538145531f76dfa

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v12.x v8 engine Issues and PRs related to the V8 dependency. labels Aug 21, 2019
@targos targos mentioned this pull request Aug 21, 2019
Closed
@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 21, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 21, 2019 •
edited by targos

CI: https://ci.nodejs.org/job/node-test-pull-request/25140/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2472/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25161/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25180/

@addaleax
Copy link
Member

I think we need to undo the public parts of v8/v8@e423f00, too.

@targos
Copy link
Member Author

targos commented Aug 25, 2019

I was not sur because I saw that the old methods are deprecated and not removed, but I'll check that everything is still here

@targos
Copy link
Member Author

targos commented Aug 28, 2019

@addaleax I checked, and all ResourceConstraints methods are still there.

@addaleax
Copy link
Member

@targos Yes, but the layout of the fields changed, affecting the class’s size and the way that the inline getters/setters access the fields. And from the research on Workers I know that there are native modules that create new Isolates, so I think we need to keep the class ABI-stable.

@targos
Copy link
Member Author

targos commented Aug 28, 2019

I see. Could you help me a bit on the compatibility patch? I don't really know what to do.

@targos targos mentioned this pull request Aug 30, 2019
Closed
@bcoe
Copy link
Contributor

bcoe commented Aug 30, 2019

👋 @targos once this lands, could we also backport 8f33053 to 12.x, it should address a fairly significant bug with coverage (I will be confirming this with Node's nightly build ASAP).

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25303/

@addaleax
Copy link
Member

Pushed changes to hopefully take care of ResourceConstraints.

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2486/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25307/

@bnoordhuis
Copy link
Member

In v8-inspector.h, the addition of V8StackTrace::buildInspectorObject() changes the vtable and the removal of V8InspectorSession::stateJSON() breaks API. Do we assume that's alright because add-ons aren't expected to use those classes?

@targos
Copy link
Member Author

targos commented Aug 31, 2019

@bnoordhuis the v8-inspector.h header is not exposed by Node.js: #22586

@BridgeAR BridgeAR mentioned this pull request Sep 4, 2019
Merged
@addaleax addaleax mentioned this pull request Sep 7, 2019
Closed
@bricss
Copy link

bricss commented Sep 15, 2019 •
edited

Does this backport includes fix from? -> #29472 🤔

targos and others added 6 commits September 17, 2019 11:16
@targos
deps: update V8 to 7.7.299.4
e2d7149
@targos
build: reset embedder string to "-node.0"
ce858cb
@refack @targos
deps: V8: fix filename manipulation for Windows
ae7744c 
PR-URL: nodejs#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@refack @targos
deps: V8: un-cherry-pick bd019bd
f4b28d1 
Original commit message:

    [testrunner] delete ancient junit compatible format support

    Testrunner has ancient support for JUnit compatible XML output.

    This CL removes this old feature.

    R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
    CC=​machenbach@chromium.org

    Bug: v8:8728
    Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
    Reviewed-on: https://chromium-review.googlesource.com/c/1430065
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Tamer Tas <tmrts@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59045}

Refs: v8/v8@bd019bd

PR-URL: nodejs#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@targos
deps: V8: silence irrelevant warning
71cd94c 
PR-URL: nodejs#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@cjihrig @targos
deps: V8: update postmortem metadata generation script
e3a902d 
Update postmortem metadata constants for V8 7.7 in Node.js.

PR-URL: nodejs#28918
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@beevelop beevelop mentioned this pull request Sep 26, 2019
Closed
targos added a commit that referenced this pull request Oct 8, 2019
@targos
deps: patch V8 to be API/ABI compatible with 7.4 (from 7.5)
c0c22a3 
Reverts v8/v8@1b51dca
Reverts v8/v8@1ab717d
Partially reverts v8/v8@b0077b3

Backport-PR-URL: #29241
Backport-PR-URL: #28955
PR-URL: #28005
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
targos added a commit that referenced this pull request Oct 8, 2019
@targos @addaleax
deps: patch V8 to be API/ABI compatible with 7.4 (from 7.6)
efd1934 
Reverts v8/v8@4214933.
Reverts v8/v8@c76f377.
Reverts v8/v8@e0d7f81.

Co-authored-by: Anna Henningsen <anna@addaleax.net>
Backport-PR-URL: #29241
PR-URL: #28955
targos added a commit that referenced this pull request Oct 8, 2019
@targos @addaleax
deps: patch V8 to be API/ABI compatible with 7.4 (from 7.7)
861a7eb 
Co-authored-by: Anna Henningsen <anna@addaleax.net>
PR-URL: #29241
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos added a commit to targos/node that referenced this pull request Oct 25, 2019
@targos
deps: patch V8 to be API/ABI compatible with 7.4 (from 7.5)
9ece07c 
Reverts v8/v8@1b51dca
Reverts v8/v8@1ab717d
Partially reverts v8/v8@b0077b3

Backport-PR-URL: nodejs#29241
Backport-PR-URL: nodejs#28955
PR-URL: nodejs#28005
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
targos added a commit to targos/node that referenced this pull request Oct 25, 2019
@targos @addaleax
deps: patch V8 to be API/ABI compatible with 7.4 (from 7.6)
9f06e03 
Reverts v8/v8@4214933.
Reverts v8/v8@c76f377.
Reverts v8/v8@e0d7f81.

Co-authored-by: Anna Henningsen <anna@addaleax.net>
Backport-PR-URL: nodejs#29241
PR-URL: nodejs#28955
targos added a commit to targos/node that referenced this pull request Oct 25, 2019
@targos @addaleax
deps: patch V8 to be API/ABI compatible with 7.4 (from 7.7)
5245a6b 
Co-authored-by: Anna Henningsen <anna@addaleax.net>
PR-URL: nodejs#29241
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit to targos/node that referenced this pull request Jan 7, 2020
@targos @MylesBorins
deps: patch V8 to be API/ABI compatible with 7.4 (from 7.5)
6b04ae9 
Reverts v8/v8@1b51dca
Reverts v8/v8@1ab717d
Partially reverts v8/v8@b0077b3

Backport-PR-URL: nodejs#29241
Backport-PR-URL: nodejs#28955
PR-URL: nodejs#28005
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
MylesBorins pushed a commit to targos/node that referenced this pull request Jan 7, 2020
@targos @addaleax @MylesBorins
deps: patch V8 to be API/ABI compatible with 7.4 (from 7.6)
7305a2d 
Reverts v8/v8@4214933.
Reverts v8/v8@c76f377.
Reverts v8/v8@e0d7f81.

Co-authored-by: Anna Henningsen <anna@addaleax.net>
Backport-PR-URL: nodejs#29241
PR-URL: nodejs#28955
MylesBorins pushed a commit to targos/node that referenced this pull request Jan 7, 2020
@targos @addaleax @MylesBorins
deps: patch V8 to be API/ABI compatible with 7.4 (from 7.7)
dbb2088 
Co-authored-by: Anna Henningsen <anna@addaleax.net>
PR-URL: nodejs#29241
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2020
@targos @MylesBorins
deps: patch V8 to be API/ABI compatible with 7.4 (from 7.5)
da3459b 
Reverts v8/v8@1b51dca
Reverts v8/v8@1ab717d
Partially reverts v8/v8@b0077b3

Backport-PR-URL: #30109
Backport-PR-URL: #29241
Backport-PR-URL: #28955
PR-URL: #28005
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2020
@targos @addaleax @MylesBorins
deps: patch V8 to be API/ABI compatible with 7.4 (from 7.6)
887ca3b 
Reverts v8/v8@4214933.
Reverts v8/v8@c76f377.
Reverts v8/v8@e0d7f81.

Co-authored-by: Anna Henningsen <anna@addaleax.net>
Backport-PR-URL: #30109
Backport-PR-URL: #29241
PR-URL: #28955
MylesBorins pushed a commit that referenced this pull request Jan 8, 2020
@targos @addaleax @MylesBorins
deps: patch V8 to be API/ABI compatible with 7.4 (from 7.7)
e60dc1d 
Co-authored-by: Anna Henningsen <anna@addaleax.net>
Backport-PR-URL: #30109
PR-URL: #29241
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@targos @BethGriggs
deps: patch V8 to be API/ABI compatible with 7.4 (from 7.5)
bb616bb 
Reverts v8/v8@1b51dca
Reverts v8/v8@1ab717d
Partially reverts v8/v8@b0077b3

Backport-PR-URL: #30109
Backport-PR-URL: #29241
Backport-PR-URL: #28955
PR-URL: #28005
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@targos @addaleax @BethGriggs
deps: patch V8 to be API/ABI compatible with 7.4 (from 7.6)
499ccdc 
Reverts v8/v8@4214933.
Reverts v8/v8@c76f377.
Reverts v8/v8@e0d7f81.

Co-authored-by: Anna Henningsen <anna@addaleax.net>
Backport-PR-URL: #30109
Backport-PR-URL: #29241
PR-URL: #28955
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@targos @addaleax @BethGriggs
deps: patch V8 to be API/ABI compatible with 7.4 (from 7.7)
b335529 
Co-authored-by: Anna Henningsen <anna@addaleax.net>
Backport-PR-URL: #30109
PR-URL: #29241
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. semver-minor PRs that contain new features and should be released in the next minor version. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@targos @nodejs-github-bot @addaleax @bcoe @bnoordhuis @bricss @refack @cjihrig @cclauss