Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12.x] Backport update to V8 7.7 #29241

Closed
wants to merge 21 commits into from

Commits on Sep 17, 2019

  1. deps: update V8 to 7.7.299.4

    targos committed Sep 17, 2019
    Copy the full SHA
    e2d7149 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    ce858cb View commit details
    Browse the repository at this point in the history
  3. deps: V8: fix filename manipulation for Windows

    PR-URL: nodejs#28016
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    refack authored and targos committed Sep 17, 2019
    Copy the full SHA
    ae7744c View commit details
    Browse the repository at this point in the history
  4. deps: V8: un-cherry-pick bd019bd

    Original commit message:
    
        [testrunner] delete ancient junit compatible format support
    
        Testrunner has ancient support for JUnit compatible XML output.
    
        This CL removes this old feature.
    
        R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
        CC=​machenbach@chromium.org
    
        Bug: v8:8728
        Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
        Reviewed-on: https://chromium-review.googlesource.com/c/1430065
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
        Commit-Queue: Tamer Tas <tmrts@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#59045}
    
    Refs: v8/v8@bd019bd
    
    PR-URL: nodejs#26685
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    refack authored and targos committed Sep 17, 2019
    Copy the full SHA
    f4b28d1 View commit details
    Browse the repository at this point in the history
  5. deps: V8: silence irrelevant warning

    PR-URL: nodejs#26685
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    targos committed Sep 17, 2019
    Copy the full SHA
    71cd94c View commit details
    Browse the repository at this point in the history
  6. deps: V8: update postmortem metadata generation script

    Update postmortem metadata constants for V8 7.7 in Node.js.
    
    PR-URL: nodejs#28918
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cjihrig authored and targos committed Sep 17, 2019
    Copy the full SHA
    e3a902d View commit details
    Browse the repository at this point in the history
  7. deps: V8: patch register-arm64.h

    Fixes a compilation issue on some platforms
    
    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    refack authored and targos committed Sep 17, 2019
    Copy the full SHA
    b018525 View commit details
    Browse the repository at this point in the history
  8. deps: V8: forward declaration of Rtl*FunctionTable

    This should be semver-patch since actual invocation is version
    conditional.
    
    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    refack authored and targos committed Sep 17, 2019
    Copy the full SHA
    eb820e2 View commit details
    Browse the repository at this point in the history
  9. deps: V8: use ATOMIC_VAR_INIT instead of std::atomic_init

    `std::atomic_init<size_t>` is not implemented on all platforms.
    
    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    refack authored and targos committed Sep 17, 2019
    Copy the full SHA
    921ced8 View commit details
    Browse the repository at this point in the history
  10. deps: V8: add workaround for MSVC optimizer bug

    Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html
    
    PR-URL: nodejs#28016
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    refack authored and targos committed Sep 17, 2019
    Copy the full SHA
    2052e77 View commit details
    Browse the repository at this point in the history
  11. deps: V8: fix BUILDING_V8_SHARED issues

    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    refack authored and targos committed Sep 17, 2019
    Copy the full SHA
    1e573fb View commit details
    Browse the repository at this point in the history
  12. deps: V8: fix linking issue for MSVS

    PR-URL: nodejs#28016
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    refack authored and targos committed Sep 17, 2019
    Copy the full SHA
    065e087 View commit details
    Browse the repository at this point in the history
  13. deps: V8: cherry-pick e3d7f8a

    Original commit message:
    
        [build] update gen-postmortem-metadata for Python 3
    
        This change makes the code compatible with both Python 2 and Python 3.
    
        Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331
        Commit-Queue: Yang Guo <yangguo@chromium.org>
        Reviewed-by: Yang Guo <yangguo@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#63207}
    
    Refs: v8/v8@e3d7f8a
    
    PR-URL: nodejs#29105
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cclauss authored and targos committed Sep 17, 2019
    Copy the full SHA
    7759de6 View commit details
    Browse the repository at this point in the history
  14. tools: sync gypfiles with V8 7.7

    Co-authored-by: Ujjwal Sharma <usharma1998@gmail.com>
    
    PR-URL: nodejs#28918
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    targos committed Sep 17, 2019
    Copy the full SHA
    29f85e7 View commit details
    Browse the repository at this point in the history
  15. lib,test: fix error message check after V8 update

    PR-URL: nodejs#28918
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    targos committed Sep 17, 2019
    Copy the full SHA
    28e9a6f View commit details
    Browse the repository at this point in the history
  16. test: update postmortem metadata test for V8 7.7

    The following metadata has changed:
    
    - v8dbg_class_ConsString__first__String
      - Class is now generated via torque.
      - Postmortem tools should use v8dbg_class_ConsString__first_offset__int
      - Refs: v8/v8@14274bb
    
    - v8dbg_class_ConsString__second__String
      - Class is now generated via torque.
      - Postmortem tools should use v8dbg_class_ConsString__second_offset__int
      - Refs: v8/v8@14274bb
    
    - v8dbg_class_SlicedString__offset__SMI
      - Class is now generated via torque.
      - Postmortem tools should use v8dbg_class_SlicedString__offset_offset__int
      - Refs: v8/v8@14274bb
    
    - v8dbg_class_ThinString__actual__String
      - Class is now generated via torque.
      - Postmortem tools should use v8dbg_class_ThinString__actual_offset__int
      - Refs: v8/v8@14274bb
    
    PR-URL: nodejs#28918
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cjihrig authored and targos committed Sep 17, 2019
    Copy the full SHA
    9d7b464 View commit details
    Browse the repository at this point in the history
  17. src: update v8abbr.h for V8 7.7

    PR-URL: nodejs#28918
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cjihrig authored and targos committed Sep 17, 2019
    Copy the full SHA
    db98fac View commit details
    Browse the repository at this point in the history
  18. deps: patch V8 to be API/ABI compatible with 7.4 (from 7.5)

    Reverts v8/v8@1b51dca
    Reverts v8/v8@1ab717d
    Partially reverts v8/v8@b0077b3
    
    Backport-PR-URL: nodejs#28955
    PR-URL: nodejs#28005
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    targos committed Sep 17, 2019
    Copy the full SHA
    9c7c8db View commit details
    Browse the repository at this point in the history
  19. deps: patch V8 to be API/ABI compatible with 7.4 (from 7.6)

    Reverts v8/v8@4214933.
    Reverts v8/v8@c76f377.
    Reverts v8/v8@e0d7f81.
    
    Co-authored-by: Anna Henningsen <anna@addaleax.net>
    PR-URL: nodejs#28955
    targos and addaleax committed Sep 17, 2019
    Copy the full SHA
    d26a3d1 View commit details
    Browse the repository at this point in the history
  20. deps: patch V8 to be API/ABI compatible with 7.4 (from 7.7)

    Co-authored-by: Anna Henningsen <anna@addaleax.net>
    targos and addaleax committed Sep 17, 2019
    Copy the full SHA
    2d96ab7 View commit details
    Browse the repository at this point in the history
  21. deps: patch V8 to 7.7.299.8

    PR-URL: nodejs#29336
    Refs: v8/v8@7.7.299.4...7.7.299.8
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    targos committed Sep 17, 2019
    Copy the full SHA
    ef84cee View commit details
    Browse the repository at this point in the history