Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.11.0 proposal #29695

Merged
merged 143 commits into from Sep 25, 2019
Merged

v12.11.0 proposal #29695

merged 143 commits into from Sep 25, 2019

Commits on Sep 19, 2019

  1. deps: update V8 to 7.7.299.4

    Backport-PR-URL: #29241
    PR-URL: #28918
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    targos committed Sep 19, 2019
    Copy the full SHA
    80ccae0 View commit details
    Browse the repository at this point in the history
  2. build: reset embedder string to "-node.0"

    Backport-PR-URL: #29241
    PR-URL: #28918
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    targos committed Sep 19, 2019
    Copy the full SHA
    fe46054 View commit details
    Browse the repository at this point in the history
  3. deps: V8: fix filename manipulation for Windows

    Backport-PR-URL: #29241
    PR-URL: #28016
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    refack authored and targos committed Sep 19, 2019
    Copy the full SHA
    5df55c2 View commit details
    Browse the repository at this point in the history
  4. deps: V8: un-cherry-pick bd019bd

    Original commit message:
    
        [testrunner] delete ancient junit compatible format support
    
        Testrunner has ancient support for JUnit compatible XML output.
    
        This CL removes this old feature.
    
        R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
        CC=​machenbach@chromium.org
    
        Bug: v8:8728
        Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
        Reviewed-on: https://chromium-review.googlesource.com/c/1430065
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
        Commit-Queue: Tamer Tas <tmrts@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#59045}
    
    Refs: v8/v8@bd019bd
    
    Backport-PR-URL: #29241
    PR-URL: #26685
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    refack authored and targos committed Sep 19, 2019
    Copy the full SHA
    c6f97bb View commit details
    Browse the repository at this point in the history
  5. deps: V8: silence irrelevant warning

    Backport-PR-URL: #29241
    PR-URL: #26685
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    targos committed Sep 19, 2019
    Copy the full SHA
    b54ee21 View commit details
    Browse the repository at this point in the history
  6. deps: V8: update postmortem metadata generation script

    Update postmortem metadata constants for V8 7.7 in Node.js.
    
    Backport-PR-URL: #29241
    PR-URL: #28918
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cjihrig authored and targos committed Sep 19, 2019
    Copy the full SHA
    63093e9 View commit details
    Browse the repository at this point in the history
  7. deps: V8: patch register-arm64.h

    Fixes a compilation issue on some platforms
    
    Backport-PR-URL: #29241
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    refack authored and targos committed Sep 19, 2019
    Copy the full SHA
    242f617 View commit details
    Browse the repository at this point in the history
  8. deps: V8: forward declaration of Rtl*FunctionTable

    This should be semver-patch since actual invocation is version
    conditional.
    
    Backport-PR-URL: #29241
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    refack authored and targos committed Sep 19, 2019
    Copy the full SHA
    1ed3909 View commit details
    Browse the repository at this point in the history
  9. deps: V8: use ATOMIC_VAR_INIT instead of std::atomic_init

    `std::atomic_init<size_t>` is not implemented on all platforms.
    
    Backport-PR-URL: #29241
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    refack authored and targos committed Sep 19, 2019
    Copy the full SHA
    07ed874 View commit details
    Browse the repository at this point in the history
  10. deps: V8: add workaround for MSVC optimizer bug

    Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html
    
    Backport-PR-URL: #29241
    PR-URL: #28016
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    refack authored and targos committed Sep 19, 2019
    Copy the full SHA
    8aaa0ab View commit details
    Browse the repository at this point in the history
  11. deps: V8: fix BUILDING_V8_SHARED issues

    Backport-PR-URL: #29241
    PR-URL: #27375
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    refack authored and targos committed Sep 19, 2019
    Copy the full SHA
    19e38e0 View commit details
    Browse the repository at this point in the history
  12. deps: V8: fix linking issue for MSVS

    Backport-PR-URL: #29241
    PR-URL: #28016
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    refack authored and targos committed Sep 19, 2019
    Copy the full SHA
    d1bedbe View commit details
    Browse the repository at this point in the history
  13. deps: V8: cherry-pick e3d7f8a

    Original commit message:
    
        [build] update gen-postmortem-metadata for Python 3
    
        This change makes the code compatible with both Python 2 and Python 3.
    
        Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331
        Commit-Queue: Yang Guo <yangguo@chromium.org>
        Reviewed-by: Yang Guo <yangguo@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#63207}
    
    Refs: v8/v8@e3d7f8a
    
    Backport-PR-URL: #29241
    PR-URL: #29105
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cclauss authored and targos committed Sep 19, 2019
    Copy the full SHA
    60efc5f View commit details
    Browse the repository at this point in the history
  14. tools: sync gypfiles with V8 7.7

    Co-authored-by: Ujjwal Sharma <usharma1998@gmail.com>
    
    Backport-PR-URL: #29241
    PR-URL: #28918
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    targos committed Sep 19, 2019
    Copy the full SHA
    027dcff View commit details
    Browse the repository at this point in the history
  15. lib,test: fix error message check after V8 update

    Backport-PR-URL: #29241
    PR-URL: #28918
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    targos committed Sep 19, 2019
    Copy the full SHA
    91d99ce View commit details
    Browse the repository at this point in the history
  16. test: update postmortem metadata test for V8 7.7

    The following metadata has changed:
    
    - v8dbg_class_ConsString__first__String
      - Class is now generated via torque.
      - Postmortem tools should use v8dbg_class_ConsString__first_offset__int
      - Refs: v8/v8@14274bb
    
    - v8dbg_class_ConsString__second__String
      - Class is now generated via torque.
      - Postmortem tools should use v8dbg_class_ConsString__second_offset__int
      - Refs: v8/v8@14274bb
    
    - v8dbg_class_SlicedString__offset__SMI
      - Class is now generated via torque.
      - Postmortem tools should use v8dbg_class_SlicedString__offset_offset__int
      - Refs: v8/v8@14274bb
    
    - v8dbg_class_ThinString__actual__String
      - Class is now generated via torque.
      - Postmortem tools should use v8dbg_class_ThinString__actual_offset__int
      - Refs: v8/v8@14274bb
    
    Backport-PR-URL: #29241
    PR-URL: #28918
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cjihrig authored and targos committed Sep 19, 2019
    Copy the full SHA
    f056d55 View commit details
    Browse the repository at this point in the history
  17. src: update v8abbr.h for V8 7.7

    Backport-PR-URL: #29241
    PR-URL: #28918
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cjihrig authored and targos committed Sep 19, 2019
    Copy the full SHA
    59b4640 View commit details
    Browse the repository at this point in the history
  18. deps: patch V8 to be API/ABI compatible with 7.4 (from 7.5)

    Reverts v8/v8@1b51dca
    Reverts v8/v8@1ab717d
    Partially reverts v8/v8@b0077b3
    
    Backport-PR-URL: #29241
    Backport-PR-URL: #28955
    PR-URL: #28005
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    targos committed Sep 19, 2019
    Copy the full SHA
    4eeb2a9 View commit details
    Browse the repository at this point in the history
  19. deps: patch V8 to be API/ABI compatible with 7.4 (from 7.6)

    Reverts v8/v8@4214933.
    Reverts v8/v8@c76f377.
    Reverts v8/v8@e0d7f81.
    
    Co-authored-by: Anna Henningsen <anna@addaleax.net>
    Backport-PR-URL: #29241
    PR-URL: #28955
    targos and addaleax committed Sep 19, 2019
    Copy the full SHA
    e95f866 View commit details
    Browse the repository at this point in the history
  20. deps: patch V8 to be API/ABI compatible with 7.4 (from 7.7)

    Co-authored-by: Anna Henningsen <anna@addaleax.net>
    PR-URL: #29241
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    targos and addaleax committed Sep 19, 2019
    Copy the full SHA
    90713c6 View commit details
    Browse the repository at this point in the history
  21. deps: patch V8 to 7.7.299.8

    PR-URL: #29336
    Refs: v8/v8@7.7.299.4...7.7.299.8
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    targos committed Sep 19, 2019
    Copy the full SHA
    7957b39 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2019

  1. build: remove experimental Python 3 tests

    These tests do not help us to get closer to Python 3 compatibility and
    they take up valuable time yet they always fail.
    
    PR-URL: #29413
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    cclauss authored and targos committed Sep 20, 2019
    Copy the full SHA
    ee18238 View commit details
    Browse the repository at this point in the history
  2. test: remove flaky status for test-statwatcher

    test-statwatcher does not appear to be failing anymore in CI. Remove
    "flaky" status for the test.
    
    Closes: #21425
    
    PR-URL: #29392
    Fixes: #21425
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Trott authored and targos committed Sep 20, 2019
    Copy the full SHA
    75c559d View commit details
    Browse the repository at this point in the history
  3. policy: minor perf opts and cleanup

    PR-URL: #29322
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bmeck authored and targos committed Sep 20, 2019
    Copy the full SHA
    95431ea View commit details
    Browse the repository at this point in the history
  4. gyp: make StringIO work in ninja.py

    Allow both Python 2 and 3 to access StringIO.
    
    This fixes `./configure --ninja`, which was broken by
    #29371.
    
    See: #29371 (comment)
    
    PR-URL: #29414
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    cclauss authored and targos committed Sep 20, 2019
    Copy the full SHA
    a20a8f4 View commit details
    Browse the repository at this point in the history
  5. doc: change the 'txt' to 'console' for a command

    This is the document formation, because `node` is a command to be
    executed, we should reguard it as a command prompt instead of a command
    txt type.
    
    PR-URL: #29389
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Maledong authored and targos committed Sep 20, 2019
    Copy the full SHA
    8023e43 View commit details
    Browse the repository at this point in the history
  6. doc: start unorded lists at start of line

    Address Markdownlint MD006 rule.
    Can flag when list items aren't indented far enough.
    
    PR-URL: #29390
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nschonni authored and targos committed Sep 20, 2019
    Copy the full SHA
    835d1ca View commit details
    Browse the repository at this point in the history
  7. doc: use consistent indenting for unordered list items

    Address Markdownlint MD007 rule.
    Default suggestion is 2 space indenting for unordered list items.
    
    PR-URL: #29390
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nschonni authored and targos committed Sep 20, 2019
    Copy the full SHA
    4374d28 View commit details
    Browse the repository at this point in the history
  8. http2: do not start reading after write if new write is on wire

    Don’t start reading more input data if we’re still busy writing output.
    This was overlooked in 8a4a193.
    
    Fixes: #29353
    Fixes: #29393
    
    PR-URL: #29399
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    addaleax authored and targos committed Sep 20, 2019
    Copy the full SHA
    d6ba106 View commit details
    Browse the repository at this point in the history
  9. src: fix ValidateDSAParameters when fips is enabled

    Currently, the following compilation errors are generated when
    configuring --openssl-is-fips:
    
    ../src/node_crypto.cc: In function ‘bool
    node::crypto::ValidateDSAParameters(EVP_PKEY*)’:
    ../src/node_crypto.cc:4886:55: error: ‘pkey’ was not declared in this
    scope
       if (FIPS_mode() && EVP_PKEY_DSA == EVP_PKEY_base_id(pkey.get())) {
                                                           ^~~~
    ../src/node_crypto.cc:4886:55: note: suggested alternative: ‘key’
       if (FIPS_mode() && EVP_PKEY_DSA == EVP_PKEY_base_id(pkey.get())) {
                                                           ^~~~
                                                           key
    ../src/node_crypto.cc:4898:35: error: expected ‘;’ before ‘}’ token
                (L == 3072 && N == 256)
                                       ^
                                       ;
       }
    
    This commit fixes the errors, and after this compilation is successful.
    
    PR-URL: #29407
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    danbev authored and targos committed Sep 20, 2019
    Copy the full SHA
    010d29d View commit details
    Browse the repository at this point in the history
  10. tools: fix GYP ninja generator for Python 3

    PR-URL: #29416
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    targos committed Sep 20, 2019
    Copy the full SHA
    2f81d59 View commit details
    Browse the repository at this point in the history
  11. n-api: mark version 5 N-APIs as stable

    PR-URL: #29401
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Gabriel Schulhof authored and targos committed Sep 20, 2019
    Copy the full SHA
    50d7c39 View commit details
    Browse the repository at this point in the history
  12. tools: delete v8_external_snapshot.gypi

    Delete the v8_external_snapshot target from gyp and disable the
    v8_use_external_startup_data option since it is never used anyway.
    
    Refs: #29363 (comment)
    Fixes: #28964
    
    PR-URL: #29369
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    ryzokuken authored and targos committed Sep 20, 2019
    Copy the full SHA
    9de417a View commit details
    Browse the repository at this point in the history
  13. build,win: fix Python detection on localized OS

    This code previously assumed the default value was always printed to
    the console by reg.exe as "(default)", but this is not true on
    localized versions of Windows and can contain spaces.
    
    Fixes: #29417
    
    PR-URL: #29423
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    joaocgreis authored and targos committed Sep 20, 2019
    Copy the full SHA
    42fd139 View commit details
    Browse the repository at this point in the history
  14. doc: change urls directly from 'http' to 'https'

    There're some URLs with old links, change them together from 'http' to
    'https'.
    
    Notice:
    1. Since files of CHANGELOG may be generated through tools, I don't
    intend to change them together as the history track.
    2. All the files in the 'deps' are of 3-rd parties, they will be
    overwritten for the next update, so avoid modifications for them.
    
    PR-URL: #29422
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Maledong authored and targos committed Sep 20, 2019
    Copy the full SHA
    844b45b View commit details
    Browse the repository at this point in the history
  15. perf_hooks: import http2 only once

    Import http2 internal bindings on each collectHttp2Stats call is not
    required.
    
    PR-URL: #29419
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    fanatid authored and targos committed Sep 20, 2019
    Copy the full SHA
    b30c40b View commit details
    Browse the repository at this point in the history
  16. doc: async_hooks.createHook promiseResolve option

    Document the `promiseResolve` option to `async_hooks.createHook()`.
    
    This seems to have been overlooked in commit b605b15 ("async_hooks:
    support promise resolve hook") from September 2017.
    
    It is documented elsewhere in the async_hooks API documentation, except
    where you actually pass it in.
    
    PR-URL: #29405
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bnoordhuis authored and targos committed Sep 20, 2019
    Copy the full SHA
    735ef8b View commit details
    Browse the repository at this point in the history
  17. doc: fix unsafe writable stream code example

    Update writable stream code example using async iterator to use safer
    `finished()` method instead of a `finish` event to avoid uncaught
    exceptions
    
    Fixes: #29397
    
    PR-URL: #29425
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    ckarande authored and targos committed Sep 20, 2019
    Copy the full SHA
    32bb58b View commit details
    Browse the repository at this point in the history
  18. doc: indent ordered list child content

    Markdownlint flags this with MD029 rule.
    Markdown renders will usually use list continuation number if it can.
    Explicitly adding it to the list item child scope makes it clearer.
    
    PR-URL: #29332
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    nschonni authored and targos committed Sep 20, 2019
    Copy the full SHA
    a7331da View commit details
    Browse the repository at this point in the history
  19. worker: make transfer list behave like web MessagePort

    Allow generic iterables as transfer list arguments, as well
    as an options object with a `transfer` option, for web compatibility.
    
    PR-URL: #29319
    Refs: #28033 (comment)
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and targos committed Sep 20, 2019
    Copy the full SHA
    d2b0568 View commit details
    Browse the repository at this point in the history
  20. src: check microtasks before running them

    PR-URL: #29434
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    codebytere authored and targos committed Sep 20, 2019
    Copy the full SHA
    5c3d484 View commit details
    Browse the repository at this point in the history
  21. esm: make dynamic import work in the REPL

    PR-URL: #29437
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    bfarias-godaddy authored and targos committed Sep 20, 2019
    Copy the full SHA
    b9c082d View commit details
    Browse the repository at this point in the history
  22. doc: update release guide with notes for major releases

    Co-Authored-By: jasnell <jasnell@gmail.com>
    Co-Authored-By: Rich Trott <rtrott@gmail.com>
    Co-Authored-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    
    PR-URL: #25497
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    jasnell authored and targos committed Sep 20, 2019
    Copy the full SHA
    c95e9ca View commit details
    Browse the repository at this point in the history
  23. http2: send out pending data earlier

    If there’s a lot of data waiting on a given stream, send
    it out early, if possible. This helps trigger the backpressure
    mechanism introduced in 8a4a193 at a better time.
    
    PR-URL: #29398
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and targos committed Sep 20, 2019
    Copy the full SHA
    fa949ca View commit details
    Browse the repository at this point in the history
  24. doc: simplify wording in n-api doc

    Simplify/clarify wording documenting n-api execute
    callback.
    
    PR-URL: #29441
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    mhdawson authored and targos committed Sep 20, 2019
    Copy the full SHA
    a9d16b5 View commit details
    Browse the repository at this point in the history
  25. perf_hooks: remove GC callbacks on zero observers count

    When all existed PerformanceObserver instances removed for type `gc` GC
    callbacks should be removed.
    
    PR-URL: #29444
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    fanatid authored and targos committed Sep 20, 2019
    Copy the full SHA
    9b4a49c View commit details
    Browse the repository at this point in the history
  26. perf_hooks: ignore duplicated entries in observer

    PerformanceObserver should add to observing only unique entry types.
    
    PR-URL: #29442
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    fanatid authored and targos committed Sep 20, 2019
    Copy the full SHA
    c146fff View commit details
    Browse the repository at this point in the history
  27. doc: prepare markdown files for more stringent blank-line linting

    PR-URL: #29447
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Sep 20, 2019
    Copy the full SHA
    7dd897f View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2019

  1. src: make ELDHistogram a HandleWrap

    This simplifies the implementation of ELDHistogram a bit,
    and more generally allows us to have weak JS references
    associated with `HandleWrap`s.
    
    PR-URL: #29317
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    67aa5ef View commit details
    Browse the repository at this point in the history
  2. http2: do not crash on stream listener removal w/ destroyed session

    Do not crash when the session is no longer available.
    
    Fixes: #29457
    
    PR-URL: #29459
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    6a7d24b View commit details
    Browse the repository at this point in the history
  3. test: permit test-signalwrap to work without test runner

    test/async-hooks/test-signalwrap.js passes with the test.py test runner
    but fails if run directly with the `node` executable. Modify the test so
    it passes in both cases.
    
    PR-URL: #28306
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Trott authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    561d504 View commit details
    Browse the repository at this point in the history
  4. build: update minimum AIX OS level

    Update minimum AIX OS level to 7.2 TL2. Looks like this
    will be the version we can get into the CI so should be the
    base level for 13.X and above and will be in support for the life
    of 13.X.
    
    PR-URL: #29476
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mhdawson authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    6f50c3f View commit details
    Browse the repository at this point in the history
  5. doc: remove wrong escapes

    PR-URL: #29452
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    XhmikosR authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    b1509e8 View commit details
    Browse the repository at this point in the history
  6. n-api: delete callback bundle via reference

    We should strive to use weak persistent references consistently
    throughout the code, since using `v8::Persistent` directly results
    in having to change many sites in the code when the way we use it
    changes.
    
    N-API uses `v8impl::Reference` internally when maintaining a weak
    persistent reference is necessary. So far, `v8impl::CallbackBundle` was
    using `v8::Persistent` directly in order to weakly reference the JS
    function backed by a N-API callback.
    
    The change introduced here reduces `v8impl::CallbackBundle` to a simple
    structure and uses a `v8impl::Reference` to weakly reference the N-API
    callback with which it is associated. The structure is freed by the
    `napi_finalize` callback of the `v8impl::Reference`. This brings
    N-API use of `v8::Persistent` completely under the `v8impl::Reference`
    umbrella, rendering our use of weak references consistent.
    
    PR-URL: #29479
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Gabriel Schulhof authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    8474b82 View commit details
    Browse the repository at this point in the history
  7. doc: exitedAfterDisconnect value can be false

    Fixed the documentation to reflect the changes in the default value
    of worker.exitedAfterDisconnect
    
    PR-URL: #29404
    Fixes: #28837
    Refs: #3743
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    nimit95 authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    9e63f91 View commit details
    Browse the repository at this point in the history
  8. test: disable core dumps before running crash test

    The test spawns a subprocess with the `--abort-on-uncaught-exception`
    flag and expects it to terminate with a SIGABRT signal.
    
    On systems where core dumps are enabled, that actually generates an
    unnecessary core dump. Set `ulimit -c 0` before spawning the subprocess.
    
    Fixes: #29286
    
    PR-URL: #29478
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    bnoordhuis authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    909c669 View commit details
    Browse the repository at this point in the history
  9. worker: prevent event loop starvation through MessagePorts

    Limit the number of messages processed without interruption on a
    given `MessagePort` to prevent event loop starvation, but still
    make sure that all messages are emitted that were already in the
    queue when emitting began.
    
    This aligns the behaviour better with the web.
    
    Refs: #28030
    
    PR-URL: #29315
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    53f2371 View commit details
    Browse the repository at this point in the history
  10. test: improve test-worker-message-port-message-before-close

    Replace a wrong comment with a correct assertion and await all async
    operations inside the async function.
    
    PR-URL: #29483
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    79a277e View commit details
    Browse the repository at this point in the history
  11. worker: make terminate() resolve for unref’ed Workers

    Once `worker.terminate()` is called, the Worker instance will be
    destroyed as soon as possible anyway, so in order to make
    the Promise returned by `worker.terminate()` resolve always,
    it should be okay to just call `.ref()` on it and keep the main
    event loop alive temporarily.
    
    PR-URL: #29484
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    fa77dc5 View commit details
    Browse the repository at this point in the history
  12. build: add comment to .travis.yml on how to test Py3

    PR-URL: #29473
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cclauss authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    c1695c6 View commit details
    Browse the repository at this point in the history
  13. doc: space around lists

    Address markdownlint rule MD032.
    Flagged a few mixed list styles.
    
    PR-URL: #29467
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    nschonni authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    2a53401 View commit details
    Browse the repository at this point in the history
  14. doc: indent child list items for remark-lint

    Child items not aligned to parent are flagged by list-item-bullet-indent
    
    PR-URL: #29488
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    nschonni authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    a262e2f View commit details
    Browse the repository at this point in the history
  15. build: improve make coverage

    Run cleanup for all relevant subdirectories, and exclude generated
    source files (e.g. `out/Release/...`) from coverage reporting.
    Also enable running `make cctest` again (It’s unclear to me why this
    was disabled, as it does reduce coverage unnecessarily).
    
    PR-URL: #29487
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    f622771 View commit details
    Browse the repository at this point in the history
  16. worker: mark as stable

    This feature is not expected to receive breaking changes to its API
    and is used in real-world applications.
    
    As discussed at the last collaborator summit (Berlin May 2019),
    the `worker_threads` module can be considered stable once our
    Web Messaging implementation is compatible with Web Platform Tests.
    As of b34f05e, that is the case.
    
    Fixes: #22940
    
    PR-URL: #29512
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    97d8b33 View commit details
    Browse the repository at this point in the history
  17. src,lib: expose memory file mapping flag

    Support for UV_FS_O_FILEMAP was added in libuv in version 1.31.0.
    This exposes the flag in fs.constants.
    
    Refs: libuv/libuv#2295
    PR-URL: #29260
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ron Korving <ron@ronkorving.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joaocgreis authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    78af92d View commit details
    Browse the repository at this point in the history
  18. test: unmark test-worker-prof as flaky

    This has no longer been flaky since V8 7.5.
    
    Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9333
    Fixes: #26401
    
    PR-URL: #29511
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    87fd55c View commit details
    Browse the repository at this point in the history
  19. deps: upgrade to libuv 1.32.0

    Notable changes:
    
    - `uv_tcp_close_reset()` has been added.
    - `uv_udp_set_source_membership()` has been added.
    - A double free in `uv_free_cpu_info()` on OpenBSD
      has been fixed.
    - Defined, but empty environment variables can now
      be read on Windows.
    - Several improvements to the cmake build process.
    - The `EILSEQ` error code is now mapped by libuv.
    
    PR-URL: #29508
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    f5f238d View commit details
    Browse the repository at this point in the history
  20. doc: add documentation for stream readableFlowing

    PR-URL: #29506
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ckarande authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    3aea277 View commit details
    Browse the repository at this point in the history
  21. stream: simplify isUint8Array helper

    The fallback code is no longer used when exporting to readable-stream.
    
    Refs: #29475
    
    PR-URL: #29514
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    2dc52ad View commit details
    Browse the repository at this point in the history
  22. tools: python3 compat for inspector code generator

    The code generator takes a dict and turns it into a namedtuple. The dict
    contains the key "async", which is a keyword in python 3.7, and rejected
    by the namedtuple constructor. Rename it to "async_" to avoid the clash.
    
    Fixes: #29326
    
    PR-URL: #29340
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    bnoordhuis authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    bc7cc34 View commit details
    Browse the repository at this point in the history
  23. build: re-run configure on node_version.h change

    Fixes: #29509
    
    PR-URL: #29510
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    c304594 View commit details
    Browse the repository at this point in the history
  24. src: modified RealEnvStore methods to use libuv functions

    Modified RealEnvStore::Get, Set, Query and Delete methods
    to use libuv methods environment variables operations instead
    of using os specific logic and switches.
    
    Fixes: #27211
    Refs: http://docs.libuv.org/en/v1.x/misc.html
    
    PR-URL: #27310
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    devasci authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    4a5ba60 View commit details
    Browse the repository at this point in the history
  25. doc: mention unit for process.hrtime.bigint()

    The example states this already, but I would have expected this to be
    part of the description, too.
    
    PR-URL: #29482
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    9abee07 View commit details
    Browse the repository at this point in the history
  26. tools: fix iculslocs to support ICU 65.1

    The ICU alias table format changed in
    https://unicode-org.atlassian.net/browse/ICU-20627
    
    Because of this, iculslocs.cc needs to handle URES_TABLE format
    contents in the res_index.txt file.
    
    PR-URL: #29523
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    srl295 authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    0db7ebe View commit details
    Browse the repository at this point in the history
  27. doc: add Tobias to the TSC

    refs: nodejs/TSC#746
    
    PR-URL: #29545
    Refs: nodejs/TSC#746
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    mhdawson authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    aa541bb View commit details
    Browse the repository at this point in the history
  28. doc: add Bethany to TSC

    Refs: nodejs/TSC#718
    
    PR-URL: #29546
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    mhdawson authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    ca8e87a View commit details
    Browse the repository at this point in the history
  29. crypto: add oaepLabel option

    The label acts as the "L" input to the RSA-OAEP algorithm.
    
    PR-URL: #29489
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    54f327b View commit details
    Browse the repository at this point in the history
  30. crypto: fix OpenSSL return code handling

    PR-URL: #29489
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    dd5d944 View commit details
    Browse the repository at this point in the history
  31. util: add encodeInto to TextEncoder

    Add function encodeInto to TextEncoder, and add MessageChannel
    to the encodeInto.any.js test.
    
    Fixes: #28851
    Fixes: #26904
    Refs: #28862
    Co-authored-by: AtticusYang <yyongtai@163.com>
    
    PR-URL: #29524
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    772a5e0 View commit details
    Browse the repository at this point in the history
  32. perf_hooks: remove non-existent entries from inspect

    Some of the milestones was removed in PR #21247 but entries not removed
    from function for inspect PerformanceNodeTiming.
    
    PR-URL: #29528
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    fanatid authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    6b30802 View commit details
    Browse the repository at this point in the history
  33. process: use public readableFlowing property

    PR-URL: #29502
    Refs: #445
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    ckarande authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    03a3468 View commit details
    Browse the repository at this point in the history
  34. repl: add missing variable declaration

    * Adds `let` to a variable declaration in a for loop
      that wasn't using anything.
    
    * Declare the for initial expression in the for loop.
    
    * Remove hoisted variables for loops.
    
    PR-URL: #29535
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    lholmquist authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    70a0c17 View commit details
    Browse the repository at this point in the history
  35. build: allow clang 10+ in configure.py

    Detected on NetBSD/amd64.
    
    Fixes: #29536
    
    PR-URL: #29541
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    krytarowski authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    f90740d View commit details
    Browse the repository at this point in the history
  36. src: print exceptions from PromiseRejectCallback

    Previously, leaving the exception lying around would leave the JS
    engine in an invalid state, as it was not expecting exceptions to
    be thrown from the C++ `PromiseRejectCallback`, and lead to hard
    crashes under some conditions (e.g. with coverage enabled).
    
    PR-URL: #29513
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    51a1dfa View commit details
    Browse the repository at this point in the history
  37. tools: update ESLint to 6.4.0

    PR-URL: #29553
    Refs: https://github.com/eslint/eslint/releases/tag/v6.4.0
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    ZYSzys authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    7bc2f06 View commit details
    Browse the repository at this point in the history
  38. repl: add autocomplete support for fs.promises

    PR-URL: #29400
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    antsmartian authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    596dd9f View commit details
    Browse the repository at this point in the history
  39. http: refactor responseKeepAlive()

    This tries to simplify the code and make it easier to understand. Took
    me a while to get my head around the previous implementation.
    
    Also minor perf improvement.
    
    PR-URL: #28700
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ronag authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    31b0b52 View commit details
    Browse the repository at this point in the history
  40. tty: add color support for mosh

    PR-URL: #27843
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    aditya1906 authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    bbf209b View commit details
    Browse the repository at this point in the history
  41. inspector: new API - Session.connectToMainThread

    This API is designed to enable worker threads use Inspector protocol
    on main thread (and other workers through NodeWorker domain).
    
    Note that worker can cause dead lock by suspending itself. I will
    work on a new API that will allow workers to be hidden from the
    inspector.
    
    Fixes: #28828
    PR-URL: #28870
    Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    eugeneo authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    a268658 View commit details
    Browse the repository at this point in the history
  42. doc: use consistent unordered list style

    Convert to asterisks when there are mixed styles in document.
    Addresses Markdownlint MD004 rule
    
    PR-URL: #29516
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    nschonni authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    bf08c08 View commit details
    Browse the repository at this point in the history
  43. doc: update experimental loader hooks example code

    It fix 2 issues in provided Loader hooks examples:
    1. Original ``new URL(`${process.cwd()}/`, 'file://');``
    is not cross-platform, it gives wrong URL on windows
    2. Based on `CHECK` in ModuleWrap::Resolve (node 12.9.1,
    https://github.com/nodejs/node/blob/v12.9.1/src/module_wrap.cc#L1132)
    the 2nd parameter should be a `string`, not an `URL` object
    
    PR-URL: #29373
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    zaverden authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    f2217cd View commit details
    Browse the repository at this point in the history
  44. test: fix flaky test-inspector-connect-main-thread

    Using `console.log()` likely interferes with the functionality of the
    test, which also checks the interaction between inspector
    and `console.log()` as part of the test. Using `process._rawDebug()`
    solves that issue.
    
    Refs: #28870
    Refs: #29582
    
    PR-URL: #29588
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    78ee065 View commit details
    Browse the repository at this point in the history
  45. doc: explain esm options for package authors

    * organize sections more hierarchically
    
    * recommend always including "type" field, per 2019-06-19 meeting
    
    Refs: nodejs/modules#342 (comment)
    
    * expand discussion of publishing cjs/esm packages
    
    PR-URL: #29497
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    GeoffreyBooth authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    7fd3261 View commit details
    Browse the repository at this point in the history
  46. doc: add leap second behavior notes for napi methods

    napi_create_date and napi_get_date_value ignore leap seconds as per
    ECMAScript spec that follows POSIX spec for time, comments added to the
    documentation where added fo clarify it.
    
    PR-URL: #29569
    Fixes: #29439
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    levhita authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    55631f4 View commit details
    Browse the repository at this point in the history
  47. lib: remove the use of util.isFunction

    PR-URL: #29566
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    himself65 authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    144aeea View commit details
    Browse the repository at this point in the history
  48. deps: update npm to 6.11.3

    PR-URL: #29430
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    claudiahdz authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    fa7de9b View commit details
    Browse the repository at this point in the history
  49. module: reintroduce package exports dot main

    This reintroduces the dot main in exports as discussed in the previous
    Node.js modules meeting.
    
    The implementation includes both CommonJS and ES module resolution with
    the associated documentation and resolver specification changes.
    
    In addition to the dot main, "exports" as a string or direct fallback
    array is supported as well.
    
    Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
    PR-URL: #29494
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    2 people authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    ce45aae View commit details
    Browse the repository at this point in the history
  50. repl: fix bug in fs module autocompletion

    PR-URL: #29555
    Fixes: #29424
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ZYSzys authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    7eae707 View commit details
    Browse the repository at this point in the history
  51. doc: add missing complete property to http2 docs

    PR-URL: #29571
    Fixes: #28622
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    javleds authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    38028ef View commit details
    Browse the repository at this point in the history
  52. doc: update list style in misc README docs

    To confirm with upcoming markdown lint rule, use `*` for unordered
    lists.
    
    PR-URL: #29594
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    0074c8a View commit details
    Browse the repository at this point in the history
  53. doc: correct trivial misspelling in AUTHORS

    my legal name changed, so i'm removing lingering references
    to my old name from the Internet.
    
    PR-URL: #29597
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    gcr authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    4954792 View commit details
    Browse the repository at this point in the history
  54. bootstrap: provide usable error on missing internal module

    Due to how bootstrap/loaders.js itself is loaded and invoked,
    stacktraces from it are munged and no longer point back to the error
    source.
    
    That resulted in the following unhelpful error if an internal module
    was missing or misnamed:
    
    ```
    internal/bootstrap/loaders.js:190
      return mod.compile();
                 ^
    
    TypeError: Cannot read property 'compile' of undefined
    ```
    
    This changes that to at least print the id that was attempted to be
    loaded:
    
    ```
    internal/bootstrap/loaders.js:189
      if (!mod) throw new TypeError(`Missing internal module '${id}'`);
                ^
    
    TypeError: Missing internal module 'internal/a'
    ```
    
    PR-URL: #29593
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Fishrock123 authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    c052967 View commit details
    Browse the repository at this point in the history
  55. doc: fix nits in net.md

    * Add missing types.
    * Fix function signatures.
    * Fix typos.
    * Unify comment style.
    * Fix ASCII sorting of bottom references.
    
    PR-URL: #29577
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    vsemozhetbyt authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    50b5ad1 View commit details
    Browse the repository at this point in the history
  56. src: re-delete Atomics.wake

    PR-URL: #29586
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    devsnek authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    3a6bc90 View commit details
    Browse the repository at this point in the history
  57. benchmark: improve process.env benchmarks

    Benchmark different types of operations and make results comparable
    by normalizing process.env for enumeartion.
    
    PR-URL: #29188
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    b9c7c90 View commit details
    Browse the repository at this point in the history
  58. src: use libuv to get env vars

    This allows us to remove OS-dependent code.
    
                                                               confidence improvement accuracy (*)    (**)   (***)
         process/bench-env.js operation='delete' n=1000000                    3.57 %      ±10.86% ±14.46% ±18.85%
         process/bench-env.js operation='enumerate' n=1000000        ***    -14.06 %       ±7.46%  ±9.94% ±12.96%
         process/bench-env.js operation='get' n=1000000                      -7.97 %      ±11.80% ±15.70% ±20.45%
         process/bench-env.js operation='query' n=1000000                    -1.32 %       ±8.38% ±11.17% ±14.58%
         process/bench-env.js operation='set' n=1000000                      -0.98 %       ±9.63% ±12.81% ±16.68%
    
    The drop in enumeration performance is likely due to the large
    number of extra allocations that libuv performs. However, enumerating
    process.env should generally not be a hot path in most applications.
    
    PR-URL: #29188
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    6284b49 View commit details
    Browse the repository at this point in the history
  59. deps: V8: cherry-pick 35c6d4d

    Original commit message:
    
        Make code generator python3.7 compatible (async keyword).
    
        Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109
    
    Fixes: #29548
    Refs:
    - #29548 (comment)
    - #29520
    - #29340
    - https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351
    - https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a
    
    PR-URL: #29585
    Refs: #29520
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    sam-github authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    bc3c0b2 View commit details
    Browse the repository at this point in the history
  60. repl: convert var to let and const

    Refs: #29535
    
    This PR replaces the instances of var with let/const.
    
    PR-URL: #29575
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    lholmquist authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    a5bd7e3 View commit details
    Browse the repository at this point in the history
  61. module: error for CJS .js load within type: module

    PR-URL: #29492
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    guybedford authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    13fa966 View commit details
    Browse the repository at this point in the history
  62. deps: patch V8 to 7.7.299.10

    Refs: v8/v8@7.7.299.8...7.7.299.10
    
    PR-URL: #29472
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Hakerh400 authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    e4a51ad View commit details
    Browse the repository at this point in the history
  63. deps: V8: cherry-pick deac757

    Original commit message:
    
        [debugger] Fix code coverage for break/return inside switch-case
    
        Case statements have a list of statements associated with them, but are
        not blocks, and were hence not fixed-up correctly for code coverage.
        This CL also applies the fix-up to the "body" of case statements,
        in this way removing ranges reported as uncovered between the final
        break/return in a case and the next case (or end of function).
    
        Drive-by: Add optional pretty printing to code coverage test results.
    
        Change-Id: I5f4002d4e17b7253ed516d99f7c389ab2264be10
        Bug: v8:9705
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798426
        Reviewed-by: Toon Verwaest <verwaest@chromium.org>
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#63719}
    
    Refs: v8/v8@deac757
    
    PR-URL: #29626
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    bcoe authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    c718c60 View commit details
    Browse the repository at this point in the history
  64. src: fix closing weak HandleWraps on GC

    In 0af62aa, this was overlooked, with it
    possibly leading to hard crashes.
    
    Refs: #29317
    
    PR-URL: #29640
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    f84f1db View commit details
    Browse the repository at this point in the history
  65. process: initial SourceMap support via NODE_V8_COVERAGE

    PR-URL: #28960
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    bcoe authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    6ba39d4 View commit details
    Browse the repository at this point in the history
  66. console: skip/strip %c formatting

    Fixes: #29605
    Refs: https://console.spec.whatwg.org
    PR-URL: #29606
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    devsnek authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    f61c509 View commit details
    Browse the repository at this point in the history
  67. stream: optimize creation

    PR-URL: #29135
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    ronag authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    78cbdf3 View commit details
    Browse the repository at this point in the history
  68. doc: make minor improvements to stream.md

    PR-URL: #28970
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    ronag authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    39b1770 View commit details
    Browse the repository at this point in the history
  69. doc: fix require call for spawn() in code example

    PR-URL: #29621
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    marian-r authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    84b353c View commit details
    Browse the repository at this point in the history
  70. doc: explain stream.finished cleanup

    PR-URL: #28935
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    ronag authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    3ba6464 View commit details
    Browse the repository at this point in the history
  71. crypto: use BoringSSL-compatible flag getter

    PR-URL: #29604
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    codebytere authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    99c2cd8 View commit details
    Browse the repository at this point in the history
  72. doc: remove the suffix number of the anchor link

    Remove the number '11' as the suffix anchor id for the 'Developer's
    Certificate of Origin 1.1'.
    
    PR-URL: #29468
    Refs: #6257
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Maledong authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    13d173f View commit details
    Browse the repository at this point in the history
  73. stream: do not call _read() after destroy()

    PR-URL: #29491
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    ronag authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    322bc6f View commit details
    Browse the repository at this point in the history
  74. timers: set _destroyed even if there are no destroy-hooks

    Required for other potential changes.
    
    This should make it so we can always just check _destroyed to
    check if a timer has been ended.
    
    PR-URL: #29595
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Fishrock123 authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    b43d2dd View commit details
    Browse the repository at this point in the history
  75. fs: remove unnecessary argument check

    Writable already assures that only Buffer's are passed to _write. Also
    this is not the "correct" way to handle errors inside _write.
    
    PR-URL: #29043
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    ronag authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    67f5de9 View commit details
    Browse the repository at this point in the history
  76. build: do not indent assignments in Makefile

    Indented assignment in a Makefile can be interpreted
    as a command in e.g. GNU Make 3.81 which results in the
    following error:
    
    ```
    make: CPPLINT_QUIET: No such file or directory
    ```
    
    PR-URL: #29623
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    joyeecheung authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    5c24bc6 View commit details
    Browse the repository at this point in the history
  77. doc: fix some signatures of .end() methods

    In `.end()` methods, an optional `encoding` parameter makes sense
    only if the `data` (`chunk`) parameter is provided.
    
    PR-URL: #29615
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    vsemozhetbyt authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    edaa2ee View commit details
    Browse the repository at this point in the history
  78. src: discard remaining foreground tasks on platform shutdown

    While V8 itself should not have any remaining tasks on the queue
    during platform shutdown, our inspector implementation may do so.
    Thus, the checks verifying that no tasks are queued at that point
    make some of the inspector tasks flaky.
    Remove the checks and replace them by explicitly destroying all
    tasks that are left.
    
    Refs: #25653
    Refs: #28870 (comment)
    
    PR-URL: #29587
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    addaleax authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    6f8ef2c View commit details
    Browse the repository at this point in the history
  79. events: add support for EventTarget in once

    PR-URL: #29498
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    jeniabrook authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    9150c4d View commit details
    Browse the repository at this point in the history
  80. stream: apply special logic in removeListener for readable.off()

    We have special logic in removeListener() which must apply
    to off() as well.
    
    PR-URL: #29486
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ronag authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    123437b View commit details
    Browse the repository at this point in the history
  81. doc: add code example to process.throwDeprecation property

    PR-URL: #29495
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    juanarbol authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    2707beb View commit details
    Browse the repository at this point in the history
  82. stream: make _write() optional when _writev() is implemented

    When implementing _writev, _write should be optional.
    
    PR-URL: #29639
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ronag authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    e71bdad View commit details
    Browse the repository at this point in the history
  83. src: perform check before running in runMicrotasks()

    This is a continuation of #29434,
    rewriting the last remaining call to RunMicrotasks.
    
    PR-URL: #29581
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    nornagon authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    3878e1e View commit details
    Browse the repository at this point in the history
  84. bootstrap: add exception handling for profiler bootstrap

    Add exception handling for the case when profile is
    not bootstrapped when coverage is enabled.
    
    Fixes: #29542
    
    PR-URL: #29552
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Shobhit Chittora authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    6b89512 View commit details
    Browse the repository at this point in the history
  85. deps: patch V8 to 7.7.299.11

    Refs: v8/v8@7.7.299.10...7.7.299.11
    
    PR-URL: #29628
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    targos authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    5d60adf View commit details
    Browse the repository at this point in the history
  86. tools: cleanup getnodeversion.py for readability

    PR-URL: #29648
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    cclauss authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    b7488c2 View commit details
    Browse the repository at this point in the history
  87. stream: cleanup use of internal ended state

    PR-URL: #29645
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ckarande authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    b100897 View commit details
    Browse the repository at this point in the history
  88. stream: add test for multiple .push(null)

    PR-URL: #29645
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ckarande authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    f016823 View commit details
    Browse the repository at this point in the history
  89. tls: add option to override signature algorithms

    Passes the list down to SSL_CTX_set1_sigalgs_list.
    
    Option to get the list of shared signature algorithms
    from a TLS socket added as well for testing.
    
    Signed-off-by: Anton Gerasimov <agerasimov@twilio.com>
    
    PR-URL: #29598
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    OYTIS authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    6272f82 View commit details
    Browse the repository at this point in the history
  90. console,util: fix missing recursion end while inspecting prototypes

    This makes sure prototypes won't be inspected infinitely for some
    obscure object creations. The depth is now taken into account and
    the recursion ends when the depth limit is reached.
    
    PR-URL: #29647
    Fixes: #29646
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    BridgeAR committed Sep 25, 2019
    Copy the full SHA
    68630c5 View commit details
    Browse the repository at this point in the history
  91. events: improve performance of EventEmitter.emit

    This restore some performance we lost when we introduced primordialias.
    Improvements are up to +100%.
    
    PR-URL: #29633
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    mcollina authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    0a47d06 View commit details
    Browse the repository at this point in the history
  92. doc: update N-API version matrix

    PR-URL: #29461
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Gabriel Schulhof authored and BridgeAR committed Sep 25, 2019
    Copy the full SHA
    325de43 View commit details
    Browse the repository at this point in the history
  93. test: fix race condition in test-worker-process-cwd.js

    This simplifies the test logic and fixes the race condition that
    could happen right now.
    
    PR-URL: #28609
    Refs: #28193
    Closes: #28477
    Fixes: #27669
    Fixes: #28477
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR committed Sep 25, 2019
    Copy the full SHA
    5605119 View commit details
    Browse the repository at this point in the history
  94. util: include reference anchor for circular structures

    This adds a reference anchor to circular structures when using
    `util.inspect`. That way it's possible to identify with what object
    the circular reference corresponds too.
    
    PR-URL: #27685
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    BridgeAR committed Sep 25, 2019
    Copy the full SHA
    ced89ad View commit details
    Browse the repository at this point in the history
  95. 2019-09-24, Version 12.11.0 (Current)

    Notable changes:
    
    * crypto:
      * Add `oaepLabel` option #29489
    * deps:
      * Update V8 to 7.7.299.11 #28918
        * More efficient memory handling
        * Stack trace serialization got faster
        * The `Intl.NumberFormat` API gained new functionality
        * For more information: https://v8.dev/blog/v8-release-77
    * events:
      * Add support for `EventTarget` in `once`
        #29498
    * fs:
      * Expose memory file mapping flag `UV_FS_O_FILEMAP`
        #29260
    * inspector:
      * New API - `Session.connectToMainThread`
        #28870
    * process:
      * Initial SourceMap support via `env.NODE_V8_COVERAGE`
        #28960
    * stream:
      * Make `_write()` optional when `_writev()` is implemented
        #29639
    * tls:
      * Add option to override signature algorithms
        #29598
    * util:
      * Add `encodeInto` to `TextEncoder`
        #29524
    * worker:
      * The `worker_thread` module is now stable
        #29512
    
    PR-URL: #29695
    BridgeAR committed Sep 25, 2019
    Copy the full SHA
    b50c01c View commit details
    Browse the repository at this point in the history