v12.11.0 proposal

.gitattributes

@@ -1,2 +1,3 @@
 test/fixtures/* -text
 vcbuild.bat text eol=crlf
+tools/msvs/find_python.cmd text eol=crlf

.mailmap

@@ -218,6 +218,8 @@ Kelsey Breseman <ifoundthemeaningoflife@gmail.com>
 Ke Ding <dingkework@hotmail.com>
 Khaidi Chu <admin@xcoder.in> XadillaX <admin@xcoder.in>
 Khaidi Chu <admin@xcoder.in> <i@2333.moe>
+Kimberly Wilber <gcr@sneakygcr.net>
+Kimberly Wilber <gcr@sneakygcr.net> <gcr@users.noreply.github.com>
 Kiyoshi Nomo <tokyoincidents.g@gmail.com> kysnm <tokyoincidents.g@gmail.com>
 Koichi Kobayashi <koichik@improvement.jp>
 Kostiantyn Wandalen <wandalen.me@gmail.com>
@@ -255,7 +257,6 @@ Matthew Turner <matty_t47@hotmail.com> <ramesius@users.noreply.github.com>
 Maurice Hayward <mauricehayward1@gmail.com> maurice_hayward <mauricehayward1@gmail.com>
 Michael Bernstein <michaelrbernstein@gmail.com>
 Michael Dawson <michael_dawson@ca.ibm.com> <mdawson@devrus.com>
-Michael Wilber <gcr@sneakygcr.net>
 Michaël Zasso <targos@protonmail.com> <mic.besace@gmail.com>
 Michael-Rainabba Richardson <rainabba@gmail.com> rainabba <rainabba@gmail.com>
 Michał Gołębiowski-Owczarek <m.goleb@gmail.com>

.travis.yml

@@ -6,9 +6,13 @@ x-ccache-setup-steps: &ccache-setup-steps
 
 os: linux
 language: cpp
+# Currently this file can only support one PYTHON_VERSION.
+# To experiment with Python 3, comment out Python 2.7 and uncomment one of the Python 3 versions.
 env:
   global:
     - PYTHON_VERSION="2.7.15"
+    # - PYTHON_VERSION="3.6.7"
+    # - PYTHON_VERSION="3.7.1"
 jobs:
   include:
     - stage: "Compile"
@@ -87,31 +91,3 @@ jobs:
         - if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then
             bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST};
           fi
-
-    - name: "Python 3 is EXPERIMENTAL (Py36)"
-      language: node_js
-      node_js: "node"
-      install:
-        - pyenv global 3.6.7
-        - python3.6 -m pip install --upgrade pip
-        - make lint-py-build
-      script:
-        - NODE=$(which node) make lint lint-py
-        - python3.6 ./configure.py
-        - NODE=$(which node) make test
-
-    - name: "Python 3 is EXPERIMENTAL (Py37)"
-      language: node_js
-      node_js: "node"
-      install:
-        - pyenv global 3.7.1
-        - python3.7 -m pip install --upgrade pip
-        - make lint-py-build
-      script:
-        - NODE=$(which node) make lint lint-py
-        - python3.7 ./configure.py
-        - NODE=$(which node) make test
-
-  allow_failures:
-    - name: "Python 3 is EXPERIMENTAL (Py36)"
-    - name: "Python 3 is EXPERIMENTAL (Py37)"

AUTHORS

@@ -141,7 +141,7 @@ Daniel Gröber <darklord@darkboxed.org>
 Travis Swicegood <development@domain51.com>
 Oleg Slobodskoi <oleg008@gmail.com>
 Jeremy Martin <jmar777@gmail.com>
-Michael Wilber <gcr@sneakygcr.net>
+Kimberly Wilber <gcr@sneakygcr.net>
 Sean Braithwaite <brapse@gmail.com>
 Anders Conbere <aconbere@gmail.com>
 Devin Torres <devin@devintorres.com>

BUILDING.md

@@ -116,7 +116,7 @@ platforms. This is true regardless of entries in the table below.
 | Windows          | arm64            | >= Windows 10                   | Experimental |                                   |
 | macOS            | x64              | >= 10.11                        | Tier 1       |                                   |
 | SmartOS          | x64              | >= 18                           | Tier 2       |                                   |
-| AIX              | ppc64be >=power7 | >= 7.1 TL05                     | Tier 2       |                                   |
+| AIX              | ppc64be >=power7 | >= 7.2 TL02                     | Tier 2       |                                   |
 | FreeBSD          | x64              | >= 11                           | Experimental | Downgraded as of Node.js 12       |
 
 <em id="fn1">1</em>: GCC 6 is not provided on the base platform, users will
@@ -243,8 +243,8 @@ transition before the year-end deadline.
 * `gcc` and `g++` >= 6.3 or newer, or
 * GNU Make 3.81 or newer
 * Python (see note above)
-    * Python 2.7
-    * Python 3.5, 3.6, and 3.7 are experimental.
+  * Python 2.7
+  * Python 3.5, 3.6, and 3.7 are experimental.
 
 Installation via Linux package manager can be achieved with:
 
@@ -259,8 +259,8 @@ FreeBSD and OpenBSD users may also need to install `libexecinfo`.
 
 * Xcode Command Line Tools >= 8 for macOS
 * Python (see note above)
-    * Python 2.7
-    * Python 3.5, 3.6, and 3.7 are experimental.
+  * Python 2.7
+  * Python 3.5, 3.6, and 3.7 are experimental.
 
 macOS users can install the `Xcode Command Line Tools` by running
 `xcode-select --install`. Alternatively, if you already have the full Xcode
@@ -501,16 +501,16 @@ $ backtrace
   [Build Tools](https://www.visualstudio.com/downloads/#build-tools-for-visual-studio-2017),
   with the default optional components.
 * Basic Unix tools required for some tests,
-  [Git for Windows](http://git-scm.com/download/win) includes Git Bash
+  [Git for Windows](https://git-scm.com/download/win) includes Git Bash
   and tools which can be included in the global `PATH`.
-* The [NetWide Assembler](http://www.nasm.us/), for OpenSSL assembler modules.
+* The [NetWide Assembler](https://www.nasm.us/), for OpenSSL assembler modules.
   If not installed in the default location, it needs to be manually added
   to `PATH`. A build with the `openssl-no-asm` option does not need this, nor
   does a build targeting ARM64 Windows.
 
 Optional requirements to build the MSI installer package:
 
-* The [WiX Toolset v3.11](http://wixtoolset.org/releases/) and the
+* The [WiX Toolset v3.11](https://wixtoolset.org/releases/) and the
   [Wix Toolset Visual Studio 2017 Extension](https://marketplace.visualstudio.com/items?itemName=RobMensching.WixToolsetVisualStudio2017Extension).
 
 Optional requirements for compiling for Windows 10 on ARM (ARM64):
@@ -527,7 +527,7 @@ Optional requirements for compiling for Windows 10 on ARM (ARM64):
 ##### Option 2: Automated install with Boxstarter
 <a name="boxstarter"></a>
 
-A [Boxstarter](http://boxstarter.org/) script can be used for easy setup of
+A [Boxstarter](https://boxstarter.org/) script can be used for easy setup of
 Windows systems with all the required prerequisites for Node.js development.
 This script will install the following [Chocolatey](https://chocolatey.org/)
 packages:
@@ -541,16 +541,16 @@ packages:
 * [NetWide Assembler](https://chocolatey.org/packages/nasm)
 
 To install Node.js prerequisites using
-[Boxstarter WebLauncher](http://boxstarter.org/WebLauncher), open
-<http://boxstarter.org/package/nr/url?https://raw.githubusercontent.com/nodejs/node/master/tools/bootstrap/windows_boxstarter>
+[Boxstarter WebLauncher](https://boxstarter.org/WebLauncher), open
+<https://boxstarter.org/package/nr/url?https://raw.githubusercontent.com/nodejs/node/master/tools/bootstrap/windows_boxstarter>
 with Internet Explorer or Edge browser on the target machine.
 
 Alternatively, you can use PowerShell. Run those commands from an elevated
 PowerShell terminal:
 
 ```powershell
 Set-ExecutionPolicy Unrestricted -Force
-iex ((New-Object System.Net.WebClient).DownloadString('http://boxstarter.org/bootstrapper.ps1'))
+iex ((New-Object System.Net.WebClient).DownloadString('https://boxstarter.org/bootstrapper.ps1'))
 get-boxstarter -Force
 Install-BoxstarterPackage https://raw.githubusercontent.com/nodejs/node/master/tools/bootstrap/windows_boxstarter -DisableReboots
 ```

CHANGELOG.md

@@ -28,7 +28,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V12.md#12.10.0">12.10.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V12.md#12.11.0">12.11.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V12.md#12.10.0">12.10.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.9.1">12.9.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.9.0">12.9.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.8.1">12.8.1</a><br/>

COLLABORATOR_GUIDE.md

@@ -3,35 +3,35 @@
 ## Contents
 
 * [Issues and Pull Requests](#issues-and-pull-requests)
-  - [Welcoming First-Time Contributors](#welcoming-first-time-contributors)
-  - [Closing Issues and Pull Requests](#closing-issues-and-pull-requests)
-  - [Author ready pull requests](#author-ready-pull-requests)
-  - [Handling own pull requests](#handling-own-pull-requests)
+  * [Welcoming First-Time Contributors](#welcoming-first-time-contributors)
+  * [Closing Issues and Pull Requests](#closing-issues-and-pull-requests)
+  * [Author ready pull requests](#author-ready-pull-requests)
+  * [Handling own pull requests](#handling-own-pull-requests)
 * [Accepting Modifications](#accepting-modifications)
-  - [Code Reviews](#code-reviews)
-  - [Consensus Seeking](#consensus-seeking)
-  - [Waiting for Approvals](#waiting-for-approvals)
-  - [Testing and CI](#testing-and-ci)
-    - [Useful CI Jobs](#useful-ci-jobs)
-  - [Internal vs. Public API](#internal-vs-public-api)
-  - [Breaking Changes](#breaking-changes)
-    - [Breaking Changes and Deprecations](#breaking-changes-and-deprecations)
-    - [Breaking Changes to Internal Elements](#breaking-changes-to-internal-elements)
-    - [Unintended Breaking Changes](#unintended-breaking-changes)
-      - [Reverting commits](#reverting-commits)
-  - [Introducing New Modules](#introducing-new-modules)
-  - [Additions to N-API](#additions-to-n-api)
-  - [Deprecations](#deprecations)
-  - [Involving the TSC](#involving-the-tsc)
+  * [Code Reviews](#code-reviews)
+  * [Consensus Seeking](#consensus-seeking)
+  * [Waiting for Approvals](#waiting-for-approvals)
+  * [Testing and CI](#testing-and-ci)
+    * [Useful CI Jobs](#useful-ci-jobs)
+  * [Internal vs. Public API](#internal-vs-public-api)
+  * [Breaking Changes](#breaking-changes)
+    * [Breaking Changes and Deprecations](#breaking-changes-and-deprecations)
+    * [Breaking Changes to Internal Elements](#breaking-changes-to-internal-elements)
+    * [Unintended Breaking Changes](#unintended-breaking-changes)
+      * [Reverting commits](#reverting-commits)
+  * [Introducing New Modules](#introducing-new-modules)
+  * [Additions to N-API](#additions-to-n-api)
+  * [Deprecations](#deprecations)
+  * [Involving the TSC](#involving-the-tsc)
 * [Landing Pull Requests](#landing-pull-requests)
-  - [Using `git-node`](#using-git-node)
-  - [Technical HOWTO](#technical-howto)
-  - [Troubleshooting](#troubleshooting)
-  - [I Made a Mistake](#i-made-a-mistake)
-  - [Long Term Support](#long-term-support)
-    - [What is LTS?](#what-is-lts)
-    - [How are LTS Branches Managed?](#how-are-lts-branches-managed)
-    - [How can I help?](#how-can-i-help)
+  * [Using `git-node`](#using-git-node)
+  * [Technical HOWTO](#technical-howto)
+  * [Troubleshooting](#troubleshooting)
+  * [I Made a Mistake](#i-made-a-mistake)
+  * [Long Term Support](#long-term-support)
+    * [What is LTS?](#what-is-lts)
+    * [How are LTS Branches Managed?](#how-are-lts-branches-managed)
+    * [How can I help?](#how-can-i-help)
 * [Who to CC in the issue tracker](#who-to-cc-in-the-issue-tracker)
 
 This document explains how Collaborators manage the Node.js project.
@@ -371,10 +371,10 @@ deprecation level of an API.
 Collaborators may opt to elevate pull requests or issues to the [TSC][].
 Do this if a pull request or issue:
 
-- is labeled `semver-major`, or
-- has a significant impact on the codebase, or
-- is controversial, or
-- is at an impasse among Collaborators who are participating in the discussion.
+* is labeled `semver-major`, or
+* has a significant impact on the codebase, or
+* is controversial, or
+* is at an impasse among Collaborators who are participating in the discussion.
 
 @-mention the `@nodejs/tsc` GitHub team if you want to elevate an issue to the
 [TSC][]. Do not use the GitHub UI on the right-hand side to assign to
@@ -542,9 +542,7 @@ Save the file and close the editor. When prompted, enter a new commit message
 for that commit. This is an opportunity to fix commit messages.
 
 * The commit message text must conform to the [commit message guidelines][].
-
-<a name="metadata"></a>
-* Change the original commit message to include metadata. (The
+* <a name="metadata"></a>Change the original commit message to include metadata. (The
   [`git node metadata`][git-node-metadata] command can generate the metadata
   for you.)
 

CONTRIBUTING.md

@@ -3,7 +3,7 @@
 * [Code of Conduct](#code-of-conduct)
 * [Issues](#issues)
 * [Pull Requests](#pull-requests)
-* [Developer's Certificate of Origin 1.1](#developers-certificate-of-origin-11)
+* [Developer's Certificate of Origin 1.1](#developers-certificate-of-origin)
 
 ## [Code of Conduct](./doc/guides/contributing/coc.md)
 

CPP_STYLE_GUIDE.md

@@ -36,6 +36,7 @@ features and idioms, as well as have some specific guidelines for the use of
 runtime features.
 
 Coding guidelines are based on the following guides (highest priority first):
+
 1. This document
 2. The [Google C++ Style Guide][]
 3. The ISO [C++ Core Guidelines][]
@@ -190,8 +191,8 @@ class FancyContainer {
 
 ### Memory allocation
 
-- `Malloc()`, `Calloc()`, etc. from `util.h` abort in Out-of-Memory situations
-- `UncheckedMalloc()`, etc. return `nullptr` in OOM situations
+* `Malloc()`, `Calloc()`, etc. from `util.h` abort in Out-of-Memory situations
+* `UncheckedMalloc()`, etc. return `nullptr` in OOM situations
 
 ### Use `nullptr` instead of `NULL` or `0`
 
@@ -277,13 +278,14 @@ data[0] = 12345;
 
 ### Type casting
 
-- Use `static_cast<T>` if casting is required, and it is valid
-- Use `reinterpret_cast` only when it is necessary
-- Avoid C-style casts (`(type)value`)
-- `dynamic_cast` does not work because Node.js is built without
+* Use `static_cast<T>` if casting is required, and it is valid
+* Use `reinterpret_cast` only when it is necessary
+* Avoid C-style casts (`(type)value`)
+* `dynamic_cast` does not work because Node.js is built without
   [Run Time Type Information][]
 
 Further reading:
+
 * [ES.48]: Avoid casts
 * [ES.49]: If you must use a cast, use a named cast
 

GOVERNANCE.md

@@ -2,13 +2,13 @@
 
 <!-- TOC -->
 
-- [Collaborators](#collaborators)
-  - [Collaborator Activities](#collaborator-activities)
-- [Technical Steering Committee](#technical-steering-committee)
-  - [TSC Meetings](#tsc-meetings)
-- [Collaborator Nominations](#collaborator-nominations)
-  - [Onboarding](#onboarding)
-- [Consensus Seeking Process](#consensus-seeking-process)
+* [Collaborators](#collaborators)
+  * [Collaborator Activities](#collaborator-activities)
+* [Technical Steering Committee](#technical-steering-committee)
+  * [TSC Meetings](#tsc-meetings)
+* [Collaborator Nominations](#collaborator-nominations)
+  * [Onboarding](#onboarding)
+* [Consensus Seeking Process](#consensus-seeking-process)
 
 <!-- /TOC -->
 

Makefile

@@ -146,7 +146,9 @@ out/Makefile: config.gypi common.gypi node.gyp \
 	tools/v8_gypfiles/inspector.gypi tools/v8_gypfiles/v8.gyp
 	$(PYTHON) tools/gyp_node.py -f make
 
-config.gypi: configure configure.py
+# node_version.h is listed because the N-API version is taken from there
+# and included in config.gypi
+config.gypi: configure configure.py src/node_version.h
 	@if [ -x config.status ]; then \
 		./config.status; \
 	else \
@@ -240,17 +242,15 @@ coverage-build-js:
 
 .PHONY: coverage-test
 coverage-test: coverage-build
-	$(RM) out/$(BUILDTYPE)/obj.target/node/gen/*.gcda
 	$(RM) out/$(BUILDTYPE)/obj.target/node/src/*.gcda
-	$(RM) out/$(BUILDTYPE)/obj.target/node/src/tracing/*.gcda
-	$(RM) out/$(BUILDTYPE)/obj.target/node_lib/gen/*.gcda
+	$(RM) out/$(BUILDTYPE)/obj.target/node/src/*/*.gcda
 	$(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/*.gcda
-	$(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/tracing/*.gcda
+	$(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/*/*.gcda
 	-NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage \
 								TEST_CI_ARGS="$(TEST_CI_ARGS) --type=coverage" $(MAKE) $(COVTESTS)
 	$(MAKE) coverage-report-js
-	-(cd out && "../gcovr/scripts/gcovr" --gcov-exclude='.*deps' \
-		--gcov-exclude='.*usr' -v -r Release/obj.target \
+	-(cd out && "../gcovr/scripts/gcovr" \
+		--gcov-exclude='.*\b(deps|usr|out|cctest)\b' -v -r Release/obj.target \
 		--html --html-detail -o ../coverage/cxxcoverage.html \
 		--gcov-executable="$(GCOV)")
 	@echo -n "Javascript coverage %: "
@@ -335,7 +335,7 @@ test-cov: all
 	$(MAKE) build-addons
 	$(MAKE) build-js-native-api-tests
 	$(MAKE) build-node-api-tests
-	# $(MAKE) cctest
+	$(MAKE) cctest
 	CI_SKIP_TESTS=$(COV_SKIP_TESTS) $(MAKE) jstest
 
 test-parallel: all
@@ -1312,9 +1312,9 @@ else
 endif
 
 ifeq ($(V),1)
-	CPPLINT_QUIET =
+CPPLINT_QUIET =
 else
-	CPPLINT_QUIET = --quiet
+CPPLINT_QUIET = --quiet
 endif
 .PHONY: lint-cpp
 # Lints the C++ code with cpplint.py and check-imports.py.

README.md

@@ -154,6 +154,8 @@ For information about the governance of the Node.js project, see
 **Anna Henningsen** <anna@addaleax.net> (she/her)
 * [apapirovski](https://github.com/apapirovski) -
 **Anatoli Papirovski** <apapirovski@mac.com> (he/him)
+* [BethGriggs](https://github.com/BethGriggs) -
+**Beth Griggs** <Bethany.Griggs@uk.ibm.com> (she/her)
 * [ChALkeR](https://github.com/ChALkeR) -
 **Сковорода Никита Андреевич** <chalkerx@gmail.com> (he/him)
 * [cjihrig](https://github.com/cjihrig) -
@@ -184,6 +186,8 @@ For information about the governance of the Node.js project, see
 **Michaël Zasso** <targos@protonmail.com> (he/him)
 * [thefourtheye](https://github.com/thefourtheye) -
 **Sakthipriyan Vairamani** <thechargingvolcano@gmail.com> (he/him)
+* [tniessen](https://github.com/tniessen) -
+**Tobias Nießen** <tniessen@tnie.de>
 * [Trott](https://github.com/Trott) -
 **Rich Trott** <rtrott@gmail.com> (he/him)