v13.1.0 release proposal

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,8 @@
+blank_issues_enabled: false
+contact_links:
+  - name: ⁉️ Need help with Node.js?
+    url: https://github.com/nodejs/help
+    about: Please file an issue in our help repo.
+  - name: 🌐 Found a problem with nodejs.org?
+    url: https://github.com/nodejs/nodejs.org/issues/new/choose
+    about: Please file an issue in the Node.js website repo.

.mailmap

@@ -270,6 +270,7 @@ Miguel Angel Asencio Hurtado <maasencioh@gmail.com> maasencioh <maasencioh@gmail
 Mikael Bourges-Sevenier <mikeseven@gmail.com> <msevenier@motorola.com>
 Mike Kaufman <mike.kaufman@microsoft.com> <mkaufman@microsoft.com>
 Minqi Pan <pmq2001@gmail.com> P.S.V.R <pmq2001@gmail.com>
+Minuk Park <parkm86@gmail.com>
 Minwoo Jung <nodecorelab@gmail.com> JungMinu <jmwsoft@gmail.com>
 Minwoo Jung <nodecorelab@gmail.com> <jmwsoft@gmail.com>
 Minwoo Jung <nodecorelab@gmail.com> <minwoo@nodesource.com>
@@ -338,6 +339,7 @@ Santiago Gimeno <santiago.gimeno@gmail.com> <santiago.gimeno@ionide.es>
 Sarah Meyer <sarahsaltrick@gmail.com> sarahmeyer <sarahsaltrick@gmail.com>
 Sartrey Lee <sartrey@163.com> sartrey <sartrey@163.com>
 Saúl Ibarra Corretgé <s@saghul.net> <saghul@gmail.com>
+Shobhit Chittora <chittorashobhit@gmail.com> <schittora@paypal.com>
 Scott Blomquist <github@scott.blomqui.st> <sblom@microsoft.com>
 Segu Riluvan <rilwan22@hotmail.com> <riluvan@gmail.com>
 Sergey Kryzhanovsky <skryzhanovsky@gmail.com> <another@dhcp199-223-red.yandex.net>
@@ -384,6 +386,7 @@ Takahiro ANDO <takahiro.ando@gmail.com>
 Tarun Batra <tarun.batra00@gmail.com> Tarun <tarun.batra00@gmail.com>
 Ted Young <ted@radicaldesigns.org>
 Teppei Sato <teppeis@gmail.com>
+Theotime Poisseau <theotime.poisseau@gmail.com>
 Thomas Hunter II <me@thomashunter.name> <tom@intrinsic.com>
 Thomas Lee <thomas.lee@shinetech.com> <tom@tom-debian.sensis.com.au>
 Thomas Reggi <thomas@reggi.com>

.travis.yml

@@ -88,3 +88,15 @@ jobs:
         - if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then
             bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST};
           fi
+
+    - name: "Find syntax errors in our Python dependencies"
+      language: python
+      python: 3.8
+      install:
+        - mv .flake8 disabled.flake8  # take the blinders off of flake8
+        - python3.8 -m pip install --upgrade pip
+        - python3.8 -m pip install flake8
+      script:
+        - flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
+  allow_failures:  # TODO (cclauss): remove this when dependencies are clean
+    - name: "Find syntax errors in our Python dependencies"

AUTHORS

@@ -773,7 +773,7 @@ Minqi Pan <pmq2001@gmail.com>
 Jacob Edelman <edelman.jd@gmail.com>
 Mike Atkins <mike.atkins@lanetix.com>
 hackerjs <4141095@qq.com>
-Minwoo Jung <jmwsoft@gmail.com>
+Minwoo Jung <nodecorelab@gmail.com>
 Marcin Cieślak <saper@marcincieslak.com>
 Anne-Gaelle Colom <coloma@wmin.ac.uk>
 Oleksandr Chekhovskyi <oleksandr.chekhovskyi@hansoft.com>
@@ -2653,7 +2653,6 @@ Furqan Shaikh <furqan_shaikh_1999@hotmail.com>
 Roy Sommer <roy@sommer.co.il>
 James Bunton <jbunton@atlassian.com>
 Kevin Smith <Kevin.Smith@microsoft.com>
-Minwoo Jung <minwoo@nodesource.com>
 H1Gdev <h1g.z.ouroboros+github@gmail.com>
 Julian Alimin <dmastag@yahoo.com>
 Lakshmi Swetha Gopireddy <lakshmigopireddy@in.ibm.com>
@@ -2847,5 +2846,25 @@ Levhita <levhita@gmail.com>
 claudiahdz <cghr1990@gmail.com>
 Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
 Javier Ledezma <juls0593@gmail.com>
+Marian Rusnak <4215517+marian-r@users.noreply.github.com>
+Jenia <jeniabrook@gmail.com>
+Anton Gerasimov <agerasimov@twilio.com>
+rickyes <mail@zhoumq.cn>
+Simon A. Eugster <simon.eu@gmail.com>
+TATSUNO Yasuhiro <ytatsuno.jp@gmail.com>
+Robert Jensen <rjensen@butterflynetwork.com>
+dokugo <dokugo@users.noreply.github.com>
+Jakob Krigovsky <jakob@krigovsky.com>
+Sergei Osipov <cubisto@ya.ru>
+themez <themezeng@gmail.com>
+Maria Paktiti <maria.paktiti@gmail.com>
+Unlocked <10186337+TheUnlocked@users.noreply.github.com>
+Huachao Mao <huachaomao@gmail.com>
+Lucas Pardue <lucas.pardue@bbc.co.uk>
+Nicolas Thumann <46975855+n-thumann@users.noreply.github.com>
+akitsu-sanae <akitsu.sanae@gmail.com>
+Minuk Park <parkm86@gmail.com>
+Jim Schlight <jim@inspiredware.com>
+Theotime Poisseau <theotime.poisseau@gmail.com>
 
 # Generated by tools/update-authors.js

BUILDING.md

@@ -246,7 +246,7 @@ transition before the year-end deadline.
 * GNU Make 3.81 or newer
 * Python (see note above)
   * Python 2.7
-  * Python 3.5, 3.6, and 3.7 are experimental.
+  * Python 3.5, 3.6, 3.7, and 3.8 are experimental.
 
 Installation via Linux package manager can be achieved with:
 
@@ -262,7 +262,7 @@ FreeBSD and OpenBSD users may also need to install `libexecinfo`.
 * Xcode Command Line Tools >= 10 for macOS
 * Python (see note above)
   * Python 2.7
-  * Python 3.5, 3.6, and 3.7 are experimental.
+  * Python 3.5, 3.6, 3.7, and 3.8 are experimental.
 
 macOS users can install the `Xcode Command Line Tools` by running
 `xcode-select --install`. Alternatively, if you already have the full Xcode
@@ -282,6 +282,11 @@ $ ./configure
 $ make -j4
 ```
 
+If you run into a `No module named 'distutils.spawn'` error when executing
+`./configure`, please try `python3 -m pip install --upgrade setuptools` or
+`sudo apt install python3-distutils -y`.
+For more information, see https://github.com/nodejs/node/issues/30189.
+
 The `-j4` option will cause `make` to run 4 simultaneous compilation jobs which
 may reduce build time. For more information, see the
 [GNU Make Documentation](https://www.gnu.org/software/make/manual/html_node/Parallel.html).

CHANGELOG.md

@@ -30,7 +30,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V13.md#13.0.1">13.0.1</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V13.md#13.1.0">13.1.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V13.md#13.0.1">13.0.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.0.0">13.0.0</a><br/>
     </td>
     <td valign="top">

COLLABORATOR_GUIDE.md

@@ -341,6 +341,9 @@ Runtime Deprecations and End-of-Life APIs (internal or public) are breaking
 changes (`semver-major`). The TSC may make exceptions, deciding that one of
 these deprecations is not a breaking change.
 
+Avoid Runtime Deprecations when an alias or a stub/no-op will suffice. An alias
+or stub will have lower maintenance costs for end users and Node.js core.
+
 All deprecations receive a unique and immutable identifier. Documentation,
 warnings, and errors use the identifier when referring to the deprecation. The
 documentation for the deprecation identifier must always remain in the API

README.md

@@ -338,8 +338,6 @@ For information about the governance of the Node.js project, see
 **Jan Krems** <jan.krems@gmail.com> (he/him)
 * [joaocgreis](https://github.com/joaocgreis) -
 **João Reis** <reis@janeasystems.com>
-* [joshgav](https://github.com/joshgav) -
-**Josh Gavant** <josh.gavant@outlook.com>
 * [joyeecheung](https://github.com/joyeecheung) -
 **Joyee Cheung** <joyeec9h3@gmail.com> (she/her)
 * [julianduque](https://github.com/julianduque) -
@@ -348,16 +346,14 @@ For information about the governance of the Node.js project, see
 **Minwoo Jung** <nodecorelab@gmail.com> (he/him)
 * [kfarnung](https://github.com/kfarnung) -
 **Kyle Farnung** <kfarnung@microsoft.com> (he/him)
-* [kunalspathak](https://github.com/kunalspathak) -
-**Kunal Pathak** <kunal.pathak@microsoft.com>
 * [lance](https://github.com/lance) -
 **Lance Ball** <lball@redhat.com> (he/him)
+* [legendecas](https://github.com/legendecas) -
+**Chengzhong Wu** <legendecas@gmail.com> (he/him)
 * [Leko](https://github.com/Leko) -
 **Shingo Inoue** <leko.noor@gmail.com> (he/him)
 * [lpinca](https://github.com/lpinca) -
 **Luigi Pinca** <luigipinca@gmail.com> (he/him)
-* [lucamaraschi](https://github.com/lucamaraschi) -
-**Luca Maraschi** <luca.maraschi@gmail.com> (he/him)
 * [lundibundi](https://github.com/lundibundi) -
 **Denys Otrishko** <shishugi@gmail.com> (he/him)
 * [maclover7](https://github.com/maclover7) -
@@ -430,8 +426,6 @@ For information about the governance of the Node.js project, see
 **Sakthipriyan Vairamani** <thechargingvolcano@gmail.com> (he/him)
 * [thekemkid](https://github.com/thekemkid) -
 **Glen Keane** <glenkeane.94@gmail.com> (he/him)
-* [thlorenz](https://github.com/thlorenz) -
-**Thorsten Lorenz** <thlorenz@gmx.de>
 * [TimothyGu](https://github.com/TimothyGu) -
 **Tiancheng "Timothy" Gu** <timothygu99@gmail.com> (he/him)
 * [tniessen](https://github.com/tniessen) -
@@ -479,6 +473,12 @@ For information about the governance of the Node.js project, see
 **Isaac Z. Schlueter** <i@izs.me>
 * [jhamhader](https://github.com/jhamhader) -
 **Yuval Brik** <yuval@brik.org.il>
+* [joshgav](https://github.com/joshgav) -
+**Josh Gavant** <josh.gavant@outlook.com>
+* [kunalspathak](https://github.com/kunalspathak) -
+**Kunal Pathak** <kunal.pathak@microsoft.com>
+* [lucamaraschi](https://github.com/lucamaraschi) -
+**Luca Maraschi** <luca.maraschi@gmail.com> (he/him)
 * [lxe](https://github.com/lxe) -
 **Aleksey Smolenchuk** <lxe@lxe.co>
 * [matthewloring](https://github.com/matthewloring) -
@@ -515,6 +515,8 @@ For information about the governance of the Node.js project, see
 **Stefan Budeanu** <stefan@budeanu.com>
 * [tellnes](https://github.com/tellnes) -
 **Christian Tellnes** <christian@tellnes.no>
+* [thlorenz](https://github.com/thlorenz) -
+**Thorsten Lorenz** <thlorenz@gmx.de>
 * [tunniclm](https://github.com/tunniclm) -
 **Mike Tunnicliffe** <m.j.tunnicliffe@gmail.com>
 * [vsemozhetbyt](https://github.com/vsemozhetbyt) -

benchmark/fs/bench-opendir.js

@@ -7,22 +7,24 @@ const path = require('path');
 const bench = common.createBenchmark(main, {
   n: [100],
   dir: [ 'lib', 'test/parallel'],
-  mode: [ 'async', 'sync', 'callback' ]
+  mode: [ 'async', 'sync', 'callback' ],
+  bufferSize: [ 4, 32, 1024 ]
 });
 
-async function main({ n, dir, mode }) {
+async function main({ n, dir, mode, bufferSize }) {
   const fullPath = path.resolve(__dirname, '../../', dir);
 
   bench.start();
 
   let counter = 0;
   for (let i = 0; i < n; i++) {
     if (mode === 'async') {
+      const dir = await fs.promises.opendir(fullPath, { bufferSize });
       // eslint-disable-next-line no-unused-vars
-      for await (const entry of await fs.promises.opendir(fullPath))
+      for await (const entry of dir)
         counter++;
     } else if (mode === 'callback') {
-      const dir = await fs.promises.opendir(fullPath);
+      const dir = await fs.promises.opendir(fullPath, { bufferSize });
       await new Promise((resolve, reject) => {
         function read() {
           dir.read((err, entry) => {
@@ -40,7 +42,7 @@ async function main({ n, dir, mode }) {
         read();
       });
     } else {
-      const dir = fs.opendirSync(fullPath);
+      const dir = fs.opendirSync(fullPath, { bufferSize });
       while (dir.readSync() !== null)
         counter++;
       dir.closeSync();

common.gypi

@@ -39,7 +39,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.14',
+    'v8_embedder_string': '-node.19',
 
     ##### V8 defaults for Node.js #####
 

configure

@@ -7,10 +7,11 @@
 # pyenv will alert which shims are available and then will fail the build.
 _=[ 'exec' '/bin/sh' '-c' '''
 test ${TRAVIS} && exec python "$0" "$@"  # workaround for pyenv on Travis CI
-which python2.7 >/dev/null && exec python2.7 "$0" "$@"
+which python3.8 >/dev/null && exec python3.8 "$0" "$@"
 which python3.7 >/dev/null && exec python3.7 "$0" "$@"
 which python3.6 >/dev/null && exec python3.6 "$0" "$@"
 which python3.5 >/dev/null && exec python3.5 "$0" "$@"
+which python2.7 >/dev/null && exec python2.7 "$0" "$@"
 exec python "$0" "$@"
 ''' "$0" "$@"
 ]
@@ -20,7 +21,7 @@ import sys
 from distutils.spawn import find_executable
 
 print('Node configure: Found Python {0}.{1}.{2}...'.format(*sys.version_info))
-acceptable_pythons = ((2, 7), (3, 7), (3, 6), (3, 5))
+acceptable_pythons = ((3, 8), (3, 7), (3, 6), (3, 5), (2, 7))
 if sys.version_info[:2] in acceptable_pythons:
   import configure
 else:

configure.py

@@ -12,6 +12,7 @@
 import subprocess
 import shutil
 import bz2
+import io
 
 from distutils.spawn import find_executable as which
 from distutils.version import StrictVersion
@@ -297,23 +298,23 @@
 
 shared_optgroup.add_option('--shared-cares',
     action='store_true',
-    dest='shared_libcares',
+    dest='shared_cares',
     help='link to a shared cares DLL instead of static linking')
 
 shared_optgroup.add_option('--shared-cares-includes',
     action='store',
-    dest='shared_libcares_includes',
+    dest='shared_cares_includes',
     help='directory containing cares header files')
 
 shared_optgroup.add_option('--shared-cares-libname',
     action='store',
-    dest='shared_libcares_libname',
+    dest='shared_cares_libname',
     default='cares',
     help='alternative lib name to link to [default: %default]')
 
 shared_optgroup.add_option('--shared-cares-libpath',
     action='store',
-    dest='shared_libcares_libpath',
+    dest='shared_cares_libpath',
     help='a directory to search for the shared cares DLL')
 
 parser.add_option_group(shared_optgroup)
@@ -1137,12 +1138,13 @@ def configure_napi(output):
   version = getnapibuildversion.get_napi_version()
   output['variables']['napi_build_version'] = version
 
-def configure_library(lib, output):
+def configure_library(lib, output, pkgname=None):
   shared_lib = 'shared_' + lib
   output['variables']['node_' + shared_lib] = b(getattr(options, shared_lib))
 
   if getattr(options, shared_lib):
-    (pkg_libs, pkg_cflags, pkg_libpath, pkg_modversion) = pkg_config(lib)
+    (pkg_libs, pkg_cflags, pkg_libpath, pkg_modversion) = (
+        pkg_config(pkgname or lib))
 
     if options.__dict__[shared_lib + '_includes']:
       output['include_dirs'] += [options.__dict__[shared_lib + '_includes']]
@@ -1497,10 +1499,11 @@ def write_config(data, name):
   icu_ver_major = None
   matchVerExp = r'^\s*#define\s+U_ICU_VERSION_SHORT\s+"([^"]*)".*'
   match_version = re.compile(matchVerExp)
-  for line in open(uvernum_h).readlines():
-    m = match_version.match(line)
-    if m:
-      icu_ver_major = m.group(1)
+  with io.open(uvernum_h, encoding='utf8') as in_file:
+    for line in in_file:
+      m = match_version.match(line)
+      if m:
+        icu_ver_major = str(m.group(1))
   if not icu_ver_major:
     error('Could not read U_ICU_VERSION_SHORT version from %s' % uvernum_h)
   elif int(icu_ver_major) < icu_versions['minimum_icu']:
@@ -1652,11 +1655,8 @@ def make_bin_override():
 configure_library('zlib', output)
 configure_library('http_parser', output)
 configure_library('libuv', output)
-configure_library('libcares', output)
-configure_library('nghttp2', output)
-# stay backwards compatible with shared cares builds
-output['variables']['node_shared_cares'] = \
-    output['variables'].pop('node_shared_libcares')
+configure_library('cares', output, pkgname='libcares')
+configure_library('nghttp2', output, pkgname='libnghttp2')
 configure_v8(output)
 configure_openssl(output)
 configure_intl(output)

deps/npm/AUTHORS

@@ -662,3 +662,4 @@ Ben Blank <ben.blank+github@gmail.com>
 Christian Clauss <cclauss@me.com>
 Nikita Lebedev <bloomber111@gmail.com>
 Henrik Gemal <henrik@gemal.dk>
+Philip Harrison <philip@mailharrison.com>