Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13.5.0 proposal #31010

Merged
merged 70 commits into from Dec 18, 2019
Merged

v13.5.0 proposal #31010

merged 70 commits into from Dec 18, 2019

Commits on Dec 17, 2019

  1. build,win: support building MSI with VS2019

    Explicitly pass the WiX SDK directory when building the MSI. WiX
    doesn't (yet?) have a directory for VS2019, so use the one for VS2017
    which should be compatible.
    
    PR-URL: #30895
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    joaocgreis authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    f371562 View commit details
    Browse the repository at this point in the history
  2. util: fix built-in detection

    This makes sure that the regular expression matches all built-in
    objects properly. So far a couple where missed.
    
    PR-URL: #30768
    Fixes: #30183
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    BridgeAR authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    453be95 View commit details
    Browse the repository at this point in the history
  3. util: inspect (user defined) prototype properties

    This is only active if the `showHidden` option is truthy.
    
    The implementation is a trade-off between accuracy and performance.
    This will miss properties such as properties added to built-in data
    types.
    
    The goal is mainly to visualize prototype getters and setters such as:
    
    class Foo {
      ownProperty = true
      get bar() {
        return 'Hello world!'
      }
    }
    
    const a = new Foo()
    
    The `bar` property is a non-enumerable property on the prototype while
    `ownProperty` will be set directly on the created instance.
    
    The output is similar to the one of Chromium when inspecting objects
    closer. The output from Firefox is difficult to compare, since it's
    always a structured interactive output and was therefore not taken
    into account.
    
    PR-URL: #30768
    Fixes: #30183
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    BridgeAR authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    8dec909 View commit details
    Browse the repository at this point in the history
  4. lib: update Symbol.toStringTag by SymbolToStringTag primordial

    PR-URL: #30908
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Sebastien-Ahkrin authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    0d2172f View commit details
    Browse the repository at this point in the history
  5. doc: improve doc writable streams: 'finish' event

    doc change for stream.md that 'finish' event should be before
    writer.end
    
    fixes: #30759
    
    PR-URL: #30889
    Fixes: #30759
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    dev-script authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    b53e2a8 View commit details
    Browse the repository at this point in the history
  6. lib: replace Symbol.toPrimitive to SymbolToPrimitive primordials

    PR-URL: #30905
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Sebastien-Ahkrin authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    a326309 View commit details
    Browse the repository at this point in the history
  7. repl: fix autocomplete when useGlobal is false

    This fixes two issues in the REPL when it is started with a new context
    (useGlobal option set to `false`):
    - The `primordials` object does not contain all builtins, so the
      filtering based on property names from `primordials` was wrong.
    - The autocompleter did not take builtin names into account because
      they are not properties of the context object.
    
    A list of all global builtin names is created lazily when needed. It is
    used for filtering for the copy and for adding those names to the
    autocompleter list.
    
    Fixes: #30792
    
    PR-URL: #30883
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    targos authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    e11acc5 View commit details
    Browse the repository at this point in the history
  8. build: fix missing x64 arch suffix in binary tar name

    PR-URL: #30877
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    legendecas authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    60225c1 View commit details
    Browse the repository at this point in the history
  9. lib: refactor NativeModule

    Refactor the internal NativeModule class to a JS class and add
    more documentation about its properties.
    
    PR-URL: #30856
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    joyeecheung authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    30d3249 View commit details
    Browse the repository at this point in the history
  10. build: auto-load ICU data from --with-icu-default-data-dir

    When compiled with `--with-intl=small` and
    `--with-icu-default-data-dir=PATH`, Node.js will use PATH as a
    fallback location for the ICU data.
    
    We will first perform an access check using fopen(PATH, 'r') to
    ensure that the file is readable. If it is, we'll set the
    icu_data_directory and proceed. There's a slight overhead for the
    fopen() check, but it should be barely measurable.
    
    This will be useful for Linux distribution packagers who want to
    be able to ship a minimal node binary in a container image but
    also be able to add on the full i18n support where needed. With
    this patch, it becomes possible to ship the interpreter as
    /usr/bin/node in one package for the distribution and to ship the
    data files in another package (without a strict dependency
    between the two). This means that users of the distribution will
    not need to explicitly direct Node.js to locate the ICU data. It
    also means that in environments where full internationalization is
    not required, they do not need to carry the extra content (with
    the associated storage costs).
    
    Refs: #3460
    
    Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
    
    PR-URL: #30825
    Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    sgallagher authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    00cbf5b View commit details
    Browse the repository at this point in the history
  11. console: unregister temporary error listener

    PR-URL: #30852
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    ronag authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    4f3eca5 View commit details
    Browse the repository at this point in the history
  12. lib: use strict equality comparison

    Change '==' to '===' in v8_prof_polyfill.js, punycode.js.
    
    PR-URL: #30898
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    PW486 authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    2430dd8 View commit details
    Browse the repository at this point in the history
  13. http,https: increase server headers timeout

    Fixes: #24980
    Refs: eb43bc04b1
    
    PR-URL: #30071
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    timcosta authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    1722280 View commit details
    Browse the repository at this point in the history
  14. http: remove unnecessary bind

    process.nextTick accepts additional parameters which
    are passed through to the callback. Use that instead
    of binding the function to a context.
    
    PR-URL: #28131
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    apapirovski authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    7a756cb View commit details
    Browse the repository at this point in the history
  15. perf_hooks: remove unnecessary bind

    Pass through parameters using setImmediate rather
    than using Function.prototype.bind to bind the
    provided context.
    
    PR-URL: #28131
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    apapirovski authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    4e67d38 View commit details
    Browse the repository at this point in the history
  16. fs: remove unnecessary bind

    Don't use Function.prototype.bind where it isn't
    necessary. Rely on event emitter context instead
    and on arrow function as class property.
    
    PR-URL: #28131
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    apapirovski authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    ad5b715 View commit details
    Browse the repository at this point in the history
  17. http2: remove unnecessary bind from setImmediate

    PR-URL: #28131
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    apapirovski authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    52aab47 View commit details
    Browse the repository at this point in the history
  18. cluster: remove unnecessary bind

    PR-URL: #28131
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    apapirovski authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    30e2d28 View commit details
    Browse the repository at this point in the history
  19. src: make debug_options getters public

    This simplifies requires for those using DebugOptions,
    since debug_options was defined in src/node_options-inl.h  and thus
    embedders would need to require an extra file to do what could
    trivially be consolidated into one.
    
    PR-URL: #30494
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    codebytere authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    c43461a View commit details
    Browse the repository at this point in the history
  20. stream: make all streams error in a pipeline

    This changes makes all stream in a pipeline emit 'error' in
    case of an abnormal termination of the pipeline. If the last stream
    is currently being async iterated, this change will make the iteration
    reject accordingly.
    
    See: #30861
    Fixes: #28194
    
    PR-URL: #30869
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mcollina authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    663a6b4 View commit details
    Browse the repository at this point in the history
  21. crypto: cast oaepLabel to unsigned char*

    OpenSSL uses a macro without typechecking; since C++ does not
    implicitly cast void* this is needed to conform Node.js to the
    OpenSSL documentation.
    
    PR-URL: #30917
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    codebytere authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    a221017 View commit details
    Browse the repository at this point in the history
  22. test: delay loading 'os' in test/common module

    There is a test that doesn't load the common module initially because it
    needs to monkey-patch the 'os' module. I think it would be a good idea
    to minimize the side-effects of loading common anyway, so let's defer
    loading 'os' unless/until it's actually needed.
    
    PR-URL: #30914
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Trott authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    7e6510b View commit details
    Browse the repository at this point in the history
  23. test: make test-os-checked-function work without test harness

    Most tests in `test/parallel` work when invoked with `node` rather than
    `tools/test.py` but not test-os-checked-function because it doesn't load
    the `common` module initially, which means it won't get re-spawned with
    the necessary flags (in the Flags: comment, in this case
    --expose_internals). Now that common delays loading 'os' until it needs
    to load it, this test can load the common module and it will work from
    the command line without the test harness. Additionally, we now can
    remove a comment disabling a lint rule.
    
    PR-URL: #30914
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Trott authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    b7a0574 View commit details
    Browse the repository at this point in the history
  24. test: improve assertion error message in test-debug-usage

    PR-URL: #30913
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    7a25c2c View commit details
    Browse the repository at this point in the history
  25. lib: change var to let/const

    PR-URL: #30910
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    rene.herrmann authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    cbe29ce View commit details
    Browse the repository at this point in the history
  26. doc: fix description of N-API exception handlers

    The return value is not a boolean and even if interpreted as one,
    it does not indicate whether an exception is pending.
    
    For napi_is_exception_pending, the description of the result parameter
    already explains how to check whether an exception is pending.
    
    PR-URL: #30893
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    tniessen authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    df5ae1a View commit details
    Browse the repository at this point in the history
  27. stream: do not chunk strings and Buffer in Readable.from

    PR-URL: #30912
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mcollina authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    0c18c49 View commit details
    Browse the repository at this point in the history
  28. src: unregister Isolate with platform before disposing

    I previously thought the order of these calls was no longer
    relevant. I was wrong.
    
    This commit undoes the changes from 312c02d, adds a comment
    explaining why I was wrong, and flips the order of the calls
    elsewhere for consistency, the latter having been the goal
    of 312c02d.
    
    Fixes: #30846
    Refs: #30181
    
    PR-URL: #30909
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    d456aa0 View commit details
    Browse the repository at this point in the history
  29. test: add test for validation for wasi.start() argument

    PR-URL: #30919
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Trott authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    60485dc View commit details
    Browse the repository at this point in the history
  30. test: add missing test flags

    test-wasi-start-validation.js should require the
    --experimental-wasi-unstable-preview0 flag in order to run.
    However, due to a recent regression, that hasn't been enforced.
    #30963 fixes the regression
    and will cause this test to start (correctly) failing. This
    commit adds the missing flag.
    
    PR-URL: #30971
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    cjihrig authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    51d1a91 View commit details
    Browse the repository at this point in the history
  31. tools: enable Markdown linter's usage information

    Prior to this commit, running `node tools/lint-md --help` and
    `node tools/lint-md --version` resulted in an error.
    
    * Use `unified-args` to start processor
    * Use `unified-args`'s error handler
    
    Fixes: #30156
    PR-URL: #30216
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Derek Lewis authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    b20ddde View commit details
    Browse the repository at this point in the history
  32. build,win: fix goto exit in vcbuild

    PR-URL: #30931
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    joaocgreis authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    10a77d3 View commit details
    Browse the repository at this point in the history
  33. test: avoid leftover report file

    test-windows-failed-heap-allocation forces a out of mem crash resulting
    in a report file. To avoid a leftover in repo the child is started in a
    tmp folder like in test-report-fatal-error.
    
    PR-URL: #30925
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Flarna authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    b6b917d View commit details
    Browse the repository at this point in the history
  34. util: refactor inspect code for constistency

    This removes the special handling to inspect iterable objects with
    a null prototype. It is now handled together with the regular
    prototype.
    
    PR-URL: #30225
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    f830a7d View commit details
    Browse the repository at this point in the history
  35. util: add Set and map size to inspect output

    This adds the size of a set and map to the output. This aligns the
    output with the one from Chromium.
    
    PR-URL: #30225
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    f62a767 View commit details
    Browse the repository at this point in the history
  36. doc: clarify expectations for PR commit messages

    Prior to this commit, new contributors were suggested
    to use a utility to validate commit messages. Although
    not inaccurate, this utility produces misleading results.
    
    * Remove reference to `core-validate-commit`
    
    PR-URL: #30922
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Derek Lewis authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    eb6443d View commit details
    Browse the repository at this point in the history
  37. test: improve dns lookup coverage

    Adding tests covering promises-related code paths.
    
    PR-URL: #30777
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    KeeReal authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    69aaab0 View commit details
    Browse the repository at this point in the history
  38. repl: remove dead code

    The .scope command was used only in the old debugger. Since that's
    not part of core anymore it's does not have any use. I tried to
    replicate the expected behavior but it even results in just exiting
    the repl immediately when using the completion similar to the removed
    test case.
    
    PR-URL: #30907
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    d549dae View commit details
    Browse the repository at this point in the history
  39. repl: simplify repl autocompletion

    This simplifies calling `filteredOwnPropertyNames()`. The context
    is not used in that function, so there's no need to call the function
    as such.
    
    PR-URL: #30907
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    f7eeb8c View commit details
    Browse the repository at this point in the history
  40. repl: simplify code

    This simplifies some repl code and removes a code branch that is
    unreachable.
    
    PR-URL: #30907
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    8b92223 View commit details
    Browse the repository at this point in the history
  41. readline: update ansi-regex

    This updates the used regular expression to the latest version.
    It includes a number of additional escape codes.
    
    PR-URL: #30907
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    424c37b View commit details
    Browse the repository at this point in the history
  42. repl,readline: refactor common code

    This renames some variables for clarity and moves the common substring
    part into a shared file. One algorithm was more efficient than the
    other but the functionality itself was identical.
    
    PR-URL: #30907
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    f6f298e View commit details
    Browse the repository at this point in the history
  43. repl,readline: refactor for simplicity

    This just refactors code without changing the behavior. Especially
    the REPL code is difficult to read and deeply indented. This reduces
    the indentation to improve that.
    
    PR-URL: #30907
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    3906e14 View commit details
    Browse the repository at this point in the history
  44. repl: improve completion

    This improves the completion output by removing the nested special
    handling. It never fully worked as expected and required a lot of
    hacks to even keep it working halfway reliable. Our tests did not
    cover syntax errors though and those can not be handled by this
    implementation. Those break the layout and confuse the REPL.
    
    Besides that the completion now also works in case the current line
    has leading whitespace.
    
    Also improve the error output in case the completion fails.
    
    PR-URL: #30907
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    1a8f828 View commit details
    Browse the repository at this point in the history
  45. repl: add completion preview

    This improves the already existing preview functionality by also
    checking for the input completion. In case there's only a single
    completion, it will automatically be visible to the user in grey.
    If colors are deactivated, it will be visible as comment.
    
    This also changes some keys by automatically accepting the preview
    by moving the cursor behind the current input end.
    
    PR-URL: #30907
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    6a3e79f View commit details
    Browse the repository at this point in the history
  46. repl: fix preview bug in case of long lines

    This addresses an issue that is caused by lines that exceed the
    current window columns. That would cause the preview to confuse the
    REPL. This is meant as hot fix. The preview should be able to handle
    these cases appropriately as well later on.
    
    PR-URL: #30907
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    02f3fe4 View commit details
    Browse the repository at this point in the history
  47. test: add multiple repl preview tests

    This improves the coverage for the preview feature signficantly.
    Quite a few edge cases get testet here to prevent regressions.
    
    PR-URL: #30907
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    f30b771 View commit details
    Browse the repository at this point in the history
  48. doc: add "Be direct." to the style guide

    I've been doing a lot of work on-and-off to reduce unnecessary wordiness
    in our docs. Codify it in the style guide.
    
    PR-URL: #30935
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    559284b View commit details
    Browse the repository at this point in the history
  49. lib: add TypedArray constructors to primordials

    PR-URL: #30740
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Sebastien-Ahkrin authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    698e0a2 View commit details
    Browse the repository at this point in the history
  50. v8: use of TypedArray constructors from primordials

    PR-URL: #30740
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Sebastien-Ahkrin authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    2b0e2c2 View commit details
    Browse the repository at this point in the history
  51. lib: enforce use of Promise from primordials

    PR-URL: #30936
    Refs: #30697
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    targos authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    19f05ca View commit details
    Browse the repository at this point in the history
  52. lib: replace Symbol.asyncIterator by SymbolAsyncIterator

    PR-URL: #30947
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Sebastien-Ahkrin authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    92475e9 View commit details
    Browse the repository at this point in the history
  53. lib: replace Symbol.hasInstance by SymbolHasInstance

    PR-URL: #30948
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Sebastien-Ahkrin authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    f51b5bd View commit details
    Browse the repository at this point in the history
  54. lib: replace Symbol.species by SymbolSpecies

    PR-URL: #30950
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Sebastien-Ahkrin authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    88731ad View commit details
    Browse the repository at this point in the history
  55. process: fix promise catching

    Fixes: #30953
    
    PR-URL: #30957
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    pd4d10 authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    954793f View commit details
    Browse the repository at this point in the history
  56. benchmark: use let/const instead of var in buffers

    PR-URL: #30945
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    dnlup authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    b6ddbc1 View commit details
    Browse the repository at this point in the history
  57. doc: explain napi_run_script

    PR-URL: #30918
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    13b5ace View commit details
    Browse the repository at this point in the history
  58. readline: promote _getCursorPos to public api

    Alias _getCursorPos() = getCursorPos() for backwards
    compatibility.
    
    Refs: #30347
    
    PR-URL: #30687
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Js-Brecht authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    5b49ded View commit details
    Browse the repository at this point in the history
  59. process: refs --unhandled-rejections documentation in warning message

    Refs: #20392
    
    PR-URL: #30564
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    510edea View commit details
    Browse the repository at this point in the history
  60. cli: add --trace-exit cli option

    It could be convenient to trace abnormal exit of the Node.js processes
    that printing stacktrace on each `process.exit` call with a cli option.
    This also takes effects on worker threads.
    
    PR-URL: #30516
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    legendecas authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    d8ce9a0 View commit details
    Browse the repository at this point in the history
  61. stream: use for...of

    PR-URL: #30960
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    trivikr authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    5ca29d8 View commit details
    Browse the repository at this point in the history
  62. wasi: require CLI flag to require() wasi module

    This commit ensures that the WASI module cannot be require()'ed
    without a CLI flag while the module is still experimental.
    
    This fixes a regression from
    #30778.
    
    PR-URL: #30963
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    cjihrig authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    54d51db View commit details
    Browse the repository at this point in the history
  63. test: improve test coverage in child_process

    PR-URL: #26282
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    juanarbol authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    72b4aee View commit details
    Browse the repository at this point in the history
  64. test: improve WASI start() coverage

    This commit adds additional test cases to
    test-wasi-start-validation.js, which gets the JS test coverage
    of start() to 100%.
    
    PR-URL: #30972
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    c2d9552 View commit details
    Browse the repository at this point in the history
  65. test: simplify test-wasi-start-validation.js

    This commit removes an extra block scope, and avoid reading
    the simple.wasm file for every test case.
    
    PR-URL: #30972
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    5e268b8 View commit details
    Browse the repository at this point in the history
  66. doc: add note about fs.close() about undefined behavior

    Add notes to fs.close and fs.closeSync() about udnefined behavior.
    
    PR-URL: #30966
    Refs: #30864
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ronag authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    3abcb69 View commit details
    Browse the repository at this point in the history
  67. async_hooks: ensure proper handling in runInAsyncScope

    We should never try to manually run emitAfter in case of an error,
    the exception handler will do it for us, if we're going to recover.
    
    PR-URL: #30965
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    apapirovski authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    e10917f View commit details
    Browse the repository at this point in the history
  68. tls: for...of in _tls_common.js

    PR-URL: #30961
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    trivikr authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    956dec8 View commit details
    Browse the repository at this point in the history
  69. http: use for...of in http library code

    PR-URL: #30958
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    trivikr authored and MylesBorins committed Dec 17, 2019
    Copy the full SHA
    3bc9b09 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. 2019-12-18, Version 13.5.0 (Current)

    Notable Changes:
    
    * cli:
      * add --trace-exit cli option (legendecas)
        #30516
    * http,https:
      * increase server headers timeout (Tim Costa)
        #30071
    * readline:
      * update ansi-regex (Ruben Bridgewater)
        #30907
      * promote \_getCursorPos to public api (Jeremy Albright)
        #30687
    * repl:
      * add completion preview (Ruben Bridgewater)
        #30907
    * util:
      * add Set and map size to inspect output (Ruben Bridgewater)
        #30225
    * wasi:
      * require CLI flag to require() wasi module (Colin Ihrig)
        #30963
    
    PR-URL: #31010
    MylesBorins committed Dec 18, 2019
    Copy the full SHA
    2e222e6 View commit details
    Browse the repository at this point in the history