v13.5.0 proposal

.gitignore

@@ -37,6 +37,8 @@
 /*.swp
 /out
 /*.txt
+/*.msi
+/*.wixpdb
 
 # === Rules for artifacts of `./configure` ===
 /icu_config.gypi
@@ -58,6 +60,9 @@ _UpgradeReport_Files/
 *.wixobj
 /tools/msvs/genfiles/
 /npm.wxs
+/tools/msvs/msi/Release/
+/tools/msvs/msi/obj/
+/tools/msvs/msi/x64/
 # Exclude MSVS files used for .msi file generation
 !tools/msvs/msi/custom_actions.vcxproj
 !tools/msvs/msi/nodemsi.sln

CHANGELOG.md

@@ -30,7 +30,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V13.md#13.4.0">13.4.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V13.md#13.5.0">13.5.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V13.md#13.4.0">13.4.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.3.0">13.3.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.2.0">13.2.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.1.0">13.1.0</a><br/>

Makefile

@@ -842,6 +842,7 @@ endif
 endif
 endif
 endif
+endif
 ifeq ($(DESTCPU),x64)
 ARCH=x64
 else
@@ -871,7 +872,6 @@ endif
 endif
 endif
 endif
-endif
 
 # node and v8 use different arch names (e.g. node 'x86' vs v8 'ia32').
 # pass the proper v8 arch name to $V8_ARCH based on user-specified $DESTCPU.

benchmark/buffers/buffer-bytelength.js

@@ -16,8 +16,8 @@ const chars = [
 ];
 
 function main({ n, len, encoding }) {
-  var strings = [];
-  var results = [ len * 16 ];
+  let strings = [];
+  let results = [ len * 16 ];
   if (encoding === 'buffer') {
     strings = [ Buffer.alloc(len * 16, 'a') ];
   } else {

benchmark/buffers/buffer-compare-instance-method.js

@@ -12,47 +12,46 @@ function main({ n, size, args }) {
   const b1 = Buffer.alloc(size, 'a');
   const b0Len = b0.length;
   const b1Len = b1.length;
-  var i;
 
   b1[size - 1] = 'b'.charCodeAt(0);
 
   switch (args) {
     case 2:
       b0.compare(b1, 0);
       bench.start();
-      for (i = 0; i < n; i++) {
+      for (let i = 0; i < n; i++) {
         b0.compare(b1, 0);
       }
       bench.end(n);
       break;
     case 3:
       b0.compare(b1, 0, b1Len);
       bench.start();
-      for (i = 0; i < n; i++) {
+      for (let i = 0; i < n; i++) {
         b0.compare(b1, 0, b1Len);
       }
       bench.end(n);
       break;
     case 4:
       b0.compare(b1, 0, b1Len, 0);
       bench.start();
-      for (i = 0; i < n; i++) {
+      for (let i = 0; i < n; i++) {
         b0.compare(b1, 0, b1Len, 0);
       }
       bench.end(n);
       break;
     case 5:
       b0.compare(b1, 0, b1Len, 0, b0Len);
       bench.start();
-      for (i = 0; i < n; i++) {
+      for (let i = 0; i < n; i++) {
         b0.compare(b1, 0, b1Len, 0, b0Len);
       }
       bench.end(n);
       break;
     default:
       b0.compare(b1);
       bench.start();
-      for (i = 0; i < n; i++) {
+      for (let i = 0; i < n; i++) {
         b0.compare(b1);
       }
       bench.end(n);

benchmark/buffers/buffer-hex.js

@@ -9,16 +9,15 @@ const bench = common.createBenchmark(main, {
 
 function main({ len, n }) {
   const buf = Buffer.alloc(len);
-  var i;
 
-  for (i = 0; i < buf.length; i++)
+  for (let i = 0; i < buf.length; i++)
     buf[i] = i & 0xff;
 
   const hex = buf.toString('hex');
 
   bench.start();
 
-  for (i = 0; i < n; i += 1)
+  for (let i = 0; i < n; i += 1)
     Buffer.from(hex, 'hex');
 
   bench.end(n);

benchmark/buffers/buffer-indexof.js

@@ -25,7 +25,7 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ n, search, encoding, type }) {
-  var aliceBuffer = fs.readFileSync(
+  let aliceBuffer = fs.readFileSync(
     path.resolve(__dirname, '../fixtures/alice.html')
   );
 

benchmark/buffers/buffer-iterate.js

@@ -29,23 +29,23 @@ function main({ size, type, method, n }) {
 }
 
 function benchFor(buffer, n) {
-  for (var k = 0; k < n; k++) {
-    for (var i = 0; i < buffer.length; i++) {
+  for (let k = 0; k < n; k++) {
+    for (let i = 0; i < buffer.length; i++) {
       assert(buffer[i] === 0);
     }
   }
 }
 
 function benchForOf(buffer, n) {
-  for (var k = 0; k < n; k++) {
+  for (let k = 0; k < n; k++) {
     for (const b of buffer) {
       assert(b === 0);
     }
   }
 }
 
 function benchIterator(buffer, n) {
-  for (var k = 0; k < n; k++) {
+  for (let k = 0; k < n; k++) {
     const iter = buffer[Symbol.iterator]();
     let cur = iter.next();
 

benchmark/buffers/buffer-swap.js

@@ -36,7 +36,7 @@ Buffer.prototype.htons = function htons() {
 Buffer.prototype.htonl = function htonl() {
   if (this.length % 4 !== 0)
     throw new RangeError();
-  for (var i = 0; i < this.length; i += 4) {
+  for (let i = 0; i < this.length; i += 4) {
     swap(this, i, i + 3);
     swap(this, i + 1, i + 2);
   }
@@ -66,7 +66,7 @@ function createBuffer(len, aligned) {
 function genMethod(method) {
   const fnString = `
       return function ${method}(n, buf) {
-        for (var i = 0; i <= n; i++)
+        for (let i = 0; i <= n; i++)
           buf.${method}();
       }`;
   return (new Function(fnString))();

benchmark/buffers/buffer-tostring.js

@@ -15,29 +15,28 @@ function main({ encoding, args, len, n }) {
   if (encoding.length === 0)
     encoding = undefined;
 
-  var i;
   switch (args) {
     case 1:
       bench.start();
-      for (i = 0; i < n; i += 1)
+      for (let i = 0; i < n; i += 1)
         buf.toString(encoding);
       bench.end(n);
       break;
     case 2:
       bench.start();
-      for (i = 0; i < n; i += 1)
+      for (let i = 0; i < n; i += 1)
         buf.toString(encoding, 0);
       bench.end(n);
       break;
     case 3:
       bench.start();
-      for (i = 0; i < n; i += 1)
+      for (let i = 0; i < n; i += 1)
         buf.toString(encoding, 0, len);
       bench.end(n);
       break;
     default:
       bench.start();
-      for (i = 0; i < n; i += 1)
+      for (let i = 0; i < n; i += 1)
         buf.toString();
       bench.end(n);
       break;

benchmark/buffers/buffer-write-string.js

@@ -15,21 +15,19 @@ function main({ len, n, encoding, args }) {
   let start = 0;
   const buf = Buffer.allocUnsafe(len);
 
-  var i;
-
   switch (args) {
     case 'offset':
       string = 'a'.repeat(Math.floor(len / 2));
       start = len - string.length;
       if (encoding) {
         bench.start();
-        for (i = 0; i < n; ++i) {
+        for (let i = 0; i < n; ++i) {
           buf.write(string, start, encoding);
         }
         bench.end(n);
       } else {
         bench.start();
-        for (i = 0; i < n; ++i) {
+        for (let i = 0; i < n; ++i) {
           buf.write(string, start);
         }
         bench.end(n);
@@ -39,13 +37,13 @@ function main({ len, n, encoding, args }) {
       string = 'a'.repeat(len);
       if (encoding) {
         bench.start();
-        for (i = 0; i < n; ++i) {
+        for (let i = 0; i < n; ++i) {
           buf.write(string, 0, buf.length, encoding);
         }
         bench.end(n);
       } else {
         bench.start();
-        for (i = 0; i < n; ++i) {
+        for (let i = 0; i < n; ++i) {
           buf.write(string, 0, buf.length);
         }
         bench.end(n);
@@ -55,13 +53,13 @@ function main({ len, n, encoding, args }) {
       string = 'a'.repeat(len);
       if (encoding) {
         bench.start();
-        for (i = 0; i < n; ++i) {
+        for (let i = 0; i < n; ++i) {
           buf.write(string, encoding);
         }
         bench.end(n);
       } else {
         bench.start();
-        for (i = 0; i < n; ++i) {
+        for (let i = 0; i < n; ++i) {
           buf.write(string);
         }
         bench.end(n);

configure.py

@@ -450,6 +450,14 @@
         'the icu4c source archive. '
         'v%d.x or later recommended.' % icu_versions['minimum_icu'])
 
+intl_optgroup.add_option('--with-icu-default-data-dir',
+    action='store',
+    dest='with_icu_default_data_dir',
+    help='Path to the icuXXdt{lb}.dat file. If unspecified, ICU data will '
+         'only be read if the NODE_ICU_DATA environment variable or the '
+         '--icu-data-dir runtime argument is used. This option has effect '
+         'only when Node.js is built with --with-intl=small-icu.')
+
 parser.add_option('--with-ltcg',
     action='store_true',
     dest='with_ltcg',
@@ -1394,6 +1402,7 @@ def write_config(data, name):
     locs.add('root')  # must have root
     o['variables']['icu_locales'] = ','.join(str(loc) for loc in locs)
     # We will check a bit later if we can use the canned deps/icu-small
+    o['variables']['icu_default_data'] = options.with_icu_default_data_dir or ''
   elif with_intl == 'full-icu':
     # full ICU
     o['variables']['v8_enable_i18n_support'] = 1

doc/STYLE_GUIDE.md

@@ -55,10 +55,15 @@
   * OK: JavaScript, Google's V8
   <!--lint disable prohibited-strings remark-lint-->
   * NOT OK: Javascript, Google's v8
-
 * Use _Node.js_ and not _Node_, _NodeJS_, or similar variants.
   <!-- lint enable prohibited-strings remark-lint-->
   * When referring to the executable, _`node`_ is acceptable.
+* Be direct.
+  * OK: The return value is a string.
+  <!-- lint disable prohibited-strings remark-lint-->
+  * NOT OK: It is important to note that, in all cases, the return value will be
+    a string regardless.
+  <!-- lint enable prohibited-strings remark-lint-->
 
 See also API documentation structure overview in [doctools README][].
 

doc/api/cli.md

@@ -784,6 +784,14 @@ added: v7.7.0
 
 Enables the collection of trace event tracing information.
 
+### `--trace-exit`
+<!-- YAML
+added: v13.5.0
+-->
+
+Prints a stack trace whenever an environment is exited proactively,
+i.e. invoking `process.exit()`.
+
 ### `--trace-sync-io`
 <!-- YAML
 added: v2.1.0
@@ -1112,6 +1120,7 @@ Node.js options that are allowed are:
 * `--trace-event-categories`
 * `--trace-event-file-pattern`
 * `--trace-events-enabled`
+* `--trace-exit`
 * `--trace-sync-io`
 * `--trace-tls`
 * `--trace-uncaught`

doc/api/fs.md

@@ -1533,6 +1533,9 @@ changes:
 Asynchronous close(2). No arguments other than a possible exception are given
 to the completion callback.
 
+Calling `fs.close()` on any file descriptor (`fd`) that is currently in use
+through any other `fs` operation may lead to undefined behavior.
+
 ## fs.closeSync(fd)
 <!-- YAML
 added: v0.1.21
@@ -1542,6 +1545,9 @@ added: v0.1.21
 
 Synchronous close(2). Returns `undefined`.
 
+Calling `fs.closeSync()` on any file descriptor (`fd`) that is currently in use
+through any other `fs` operation may lead to undefined behavior.
+
 ## fs.constants
 
 * {Object}

doc/api/http.md

@@ -1107,7 +1107,7 @@ Stops the server from accepting new connections. See [`net.Server.close()`][].
 added: v11.3.0
 -->
 
-* {number} **Default:** `40000`
+* {number} **Default:** `60000`
 
 Limit the amount of time the parser will wait to receive the complete HTTP
 headers.

doc/api/https.md

@@ -94,7 +94,7 @@ See [`server.close()`][`http.close()`] from the HTTP module for details.
 added: v11.3.0
 -->
 
-* {number} **Default:** `40000`
+* {number} **Default:** `60000`
 
 See [`http.Server#headersTimeout`][].