doc: update stream.pipeline() signature #31789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `...transforms` parameter seems optional. Refs: https://github.com/nodejs/node/blob/087583741716969edf12874d4f1f1774de581f50/lib/internal/streams/pipeline.js#L130-L132 Refs: https://github.com/nodejs/node/blob/e559842188f541b884abff2ffad4d2d3e1b841a6/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators (see the last example)
nodejs-github-bot
added
doc
|
Isn't |
|
Yes, but the |
jasnell
approved these changes
Feb 14, 2020
ronag
approved these changes
Feb 14, 2020
|
Sorry, I did not even consider |
|
And it seems this pattern is used: |
ZYSzys
approved these changes
Feb 14, 2020
lpinca
approved these changes
Feb 14, 2020
cjihrig
approved these changes
Feb 15, 2020
lpinca
pushed a commit
that referenced
this pull request
Feb 22, 2020
The `...transforms` parameter is optional. Refs: https://github.com/nodejs/node/blob/0875837417/lib/internal/streams/pipeline.js#L130-L132 Refs: https://github.com/nodejs/node/blob/e559842188/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators PR-URL: #31789 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 2f23918. |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 4, 2020
The `...transforms` parameter is optional. Refs: https://github.com/nodejs/node/blob/0875837417/lib/internal/streams/pipeline.js#L130-L132 Refs: https://github.com/nodejs/node/blob/e559842188/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators PR-URL: #31789 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThe
...transformsparameter seems optional.Refs:
node/lib/internal/streams/pipeline.js
Lines 130 to 132 in 0875837
Refs: https://github.com/nodejs/node/blob/e559842188f541b884abff2ffad4d2d3e1b841a6/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators
(see the last example)