Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add asan check in Github action #31902

Closed
wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Feb 21, 2020

This related to #30257

This currently only runs on linux only. Acutally windows has made some progress on
this too, see https://devblogs.microsoft.com/cppblog/addresssanitizer-asan-for-windows-with-msvc/, but it require cmake as build toolchain IIUC. Also current code asan checks broken on macOS, so I didn't add them.

currrent Docker Image source: https://github.com/gengjiawen/node-build/blob/master/Dockerfile.

todo

Hopefully we can remove continue-on-error in the future.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 21, 2020
@bnoordhuis
Copy link
Member

Seems like a good idea but how long does make test take for an asan+debug build?

@richardlau
Copy link
Member

Seems like a good idea but how long does make test take for an asan+debug build?

https://github.com/nodejs/node/pull/31902/checks?check_run_id=460428978 took 1 hr 40mins.

@gengjiawen
Copy link
Member Author

ASAN checks failed on first error (https://github.com/nodejs/node/runs/460428978?check_suite_focus=true), so I add ASAN_OPTIONS: halt_on_error=0 to run all the tests.

@gengjiawen
Copy link
Member Author

@bnoordhuis @addaleax @richardlau Can you review this ? thanks.

Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks, this is useful!

To save everyone some clicking: it takes 205 minutes or about 3.5 hours for a full run. 1.5h is just the build itself though so maybe that can be sped up somehow.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@gengjiawen gengjiawen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 1, 2020
@nodejs-github-bot
Copy link
Collaborator

gengjiawen added a commit that referenced this pull request Mar 3, 2020
PR-URL: #31902
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@gengjiawen
Copy link
Member Author

Landed in 3ec4b21

@gengjiawen gengjiawen closed this Mar 3, 2020
@gengjiawen gengjiawen deleted the ci/asan branch March 3, 2020 10:06
@richardlau richardlau mentioned this pull request Mar 4, 2020
2 tasks
MylesBorins pushed a commit that referenced this pull request Mar 4, 2020
PR-URL: #31902
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorins MylesBorins mentioned this pull request Mar 4, 2020
codebytere pushed a commit that referenced this pull request Mar 16, 2020
PR-URL: #31902
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
PR-URL: #31902
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants