Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v10.20.0 proposal #31984

Merged
merged 56 commits into from Apr 8, 2020
Merged

v10.20.0 proposal #31984

merged 56 commits into from Apr 8, 2020

Conversation

BethGriggs
Copy link
Member

@BethGriggs BethGriggs commented Feb 27, 2020 •
edited

2020-04-08, Version 10.20.0 'Dubnium' (LTS), @BethGriggs

macOS package notarization and a change in builder configuration

The macOS binaries for this release, and future 10.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing .pkg files on macOS
10.15 and later. Previous builds of Node.js 10.x were compiled on macOS
10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion).
As binaries are still being compiled to support a minimum of macOS 10.7
(Lion) we do not anticipate this having a negative impact on Node.js
10.x users with older versions of macOS.

Notable changes

  • buffer: add {read|write}Big[U]Int64{BE|LE} methods (garygsc) #19691
  • build: macOS package notarization (Rod Vagg) #31459
  • deps:
    • update npm to 6.14.3 (Myles Borins) #32368
    • upgrade openssl sources to 1.1.1e (Hassaan Pasha) #32328
    • upgrade to libuv 1.34.2 (cjihrig) #31477
  • n-api:
    • add napi_get_all_property_names (himself65) #30006
    • add APIs for per-instance state management (Gabriel Schulhof) #28682
    • define release 6 #32058
    • turn NAPI_CALL_INTO_MODULE into a function (Anna Henningsen) #26128
  • tls:
    • expose keylog event on TLSSocket (Alba Mendez) #27654
    • support TLS min/max protocol defaults in CLI (Sam Roberts) #27946
  • url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) #26226

Commits

ruyadorno and others added 17 commits February 14, 2020 00:13
@ruyadorno @MylesBorins
deps: upgrade npm to 6.13.6
db24641 
PR-URL: #31304
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins
deps: upgrade npm to 6.13.7
7eac959 
PR-URL: #31558
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@refack @BethGriggs
test: try to stabalize test-child-process-fork-exec-path.js
2315270 
PR-URL: #27277
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@BethGriggs
test: mark http2 tests as flaky on 10.x
a8fd8a1 
These tests are already marked as flaky on 12.x and master.

PR-URL: #31887
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@joaocgreis @BethGriggs
test: mark tests as flaky
4b9a779 
PR-URL: #30848
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig @BethGriggs
test: allow EAI_FAIL in test-http-dns-error.js
f1a8791 
EAI_FAIL is expected on OpenBSD, and has been observed on
platforms such as FreeBSD and Windows. This commit makes
EAI_FAIL an acceptable error code on all platforms.

PR-URL: #27500
Fixes: #27487
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@sam-github @BethGriggs
tls: support TLS min/max protocol defaults in CLI
1cfb457 
Backport CLI switches for default TLS versions:
- `--tls-max-v1.2`
- `--tls-min-v1.0`
- `--tls-min-v1.1`
- `--tls-min-v1.2`

PR-URL: #27946
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
@GaryGSC @BethGriggs
buffer: add {read|write}Big[U]Int64{BE|LE} methods
64744a2 
Backport-PR-URL: #30361
PR-URL: #19691
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@Trott @BethGriggs
test: add debugging output to test-net-listen-after-destroy-stdin
3f9cec3 
The test failed in CI once with a timeout but there is insufficient
information to further debug. Add additional debugging information.

Refactored callbacks to be arrow functions, since that seems to be the
direction we're moving.

PR-URL: #31698
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@addaleax @BethGriggs
n-api: turn NAPI_CALL_INTO_MODULE into a function
20177b9 
These do not need to be macros.

PR-URL: #26128
Backport-PR-URL: #30537
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs
n-api: add APIs for per-instance state management
f29fb14 
Adds `napi_set_instance_data()` and `napi_get_instance_data()`, which
allow native addons to store their data on and retrieve their data from
`napi_env`. `napi_set_instance_data()` accepts a finalizer which is
called when the `node::Environment()` is destroyed.

This entails rendering the `napi_env` local to each add-on.

Fixes: nodejs/abi-stable-node#378
PR-URL: #28682
Backport-PR-URL: #30537
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@bnoordhuis @BethGriggs
v8: fix load elimination liveness checks
dc61e09 
This commit back-ports the implementations of IsRename() and MayAlias()
from the upstream 8.0 branch wholesale. Fixes several bugs where V8's
load elimination pass considered values to be alive when they weren't.

Fixes: #31484

PR-URL: #31613
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs
deps: V8: cherry-pick d89f4ef1cd62
9b2b66b 
PR-URL: #31753
Refs: v8/v8@d89f4ef
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis @BethGriggs
test: scale keepalive timeouts for slow machines
5484e06 
The test was using fixed timeouts and that seems to be causing sporadic
test failures on pi1-docker host (which is a very slow machine.)

Fixes: #30828

PR-URL: #30834
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@joaocgreis @BethGriggs
build,win: fix goto exit in vcbuild
42af3b8 
PR-URL: #30931
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@andrewhughes101 @BethGriggs
doc: fix changelog for v10.18.1
ffa9f9b 
PR-URL: #31358
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@sam-github @BethGriggs
test: mark empty udp tests flaky on OS X
9bd1317 
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X.

Refs: #30030
Refs: nodejs/build#2189 (comment)

PR-URL: #31936
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. v10.x labels Feb 27, 2020
@BethGriggs BethGriggs mentioned this pull request Feb 27, 2020
Closed
himself65 and others added 8 commits March 2, 2020 11:05
@himself65 @BethGriggs
n-api: add napi_get_all_property_names
ecbb331 
Co-Authored-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

PR-URL: #30006
Backport-PR-URL: #31384
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig @BethGriggs
deps: upgrade to libuv 1.29.1
b53ce6e 
Notable changes:

- uv_get_constrained_memory() has been added.
- A race condition in uv_async_send() has been fixed.
- uv_get_free_memory() and uv_get_total_memory() now read from
  /proc/meminfo, which should improve correctness when called
  from inside an lxc container.
- A failed assertion in uv_fs_poll_stop() has been fixed.
- A bug in MAC addresses for IP-aliases has been fixed.

Fixes: #27170
Fixes: #27493
PR-URL: #27718
Backport-PR-URL: #31969
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig @BethGriggs
deps: upgrade to libuv 1.30.0
7cde563 
Notable changes:

- Support for the Haiku platform has been added.
- The maximum UV_THREADPOOL_SIZE has been increased from
  128 to 1024.
- uv_fs_copyfile() now works properly when the source and
  destination files are the same.

PR-URL: #28449
Backport-PR-URL: #31969
Fixes: #27746
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@cjihrig @BethGriggs
deps: upgrade to libuv 1.30.1
ed71f55 
This upgrade is a small patch release, fixing compilation
errors on Android, Cygwin, and uClibc - none of which are
tested in the CI.

PR-URL: #28511
Backport-PR-URL: #31969
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@cjihrig @BethGriggs
deps: upgrade to libuv 1.31.0
794abbc 
Notable changes:

- UV_FS_O_FILEMAP has been added for faster access to memory
  mapped files on Windows.
- uv_fs_mkdir() now returns UV_EINVAL for invalid filenames
  on Windows. It previously returned UV_ENOENT.
- The uv_fs_statfs() API has been added.
- The uv_os_environ() and uv_os_free_environ() APIs have
  been added.

Fixes: #28599
Fixes: #28945
Fixes: #29008
PR-URL: #29070
Backport-PR-URL: #31969
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@cjihrig @BethGriggs
deps: upgrade to libuv 1.32.0
aed7ca4 
Notable changes:

- `uv_tcp_close_reset()` has been added.
- `uv_udp_set_source_membership()` has been added.
- A double free in `uv_free_cpu_info()` on OpenBSD
  has been fixed.
- Defined, but empty environment variables can now
  be read on Windows.
- Several improvements to the cmake build process.
- The `EILSEQ` error code is now mapped by libuv.

PR-URL: #29508
Backport-PR-URL: #31969
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig @BethGriggs
deps: upgrade to libuv 1.33.1
6826ef0 
Notable changes:

- uv_random() has been added.
- More work to read those pesky Windows
  environment variables.
- Several build fixes for Tier 3 platforms (Android,
  NetBSD, OpenBSD, Haiku).
- Stop using fsevents to watch files (using kqueue again).

PR-URL: #29996
Backport-PR-URL: #31969
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@cjihrig @BethGriggs
deps: upgrade to libuv 1.34.0
fff6162 
Notable changes:

- Fix handling of large files in uv_fs_copyfile().
  Fixes: #30085
- Fix Android build errors.
- uv_sleep() has been added.
- uv_interface_addresses() IPv6 netmask support has been fixed.
  Fixes: #30504
- uv_fs_mkstemp() has been added.

PR-URL: #30783
Backport-PR-URL: #31969
Fixes: #30085
Fixes: #30504
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@sam-github
Copy link
Contributor

sudo xcodebuild -license <-- I did that, and agreed, but the output doesn't give any suggestion of whether it had previously been agreed or not.

@BethGriggs
Copy link
Member Author

@sam-github thanks, I'll rerun the build and let you know the output.

@sam-github
Copy link
Contributor

sam-github commented Apr 7, 2020 •
edited

image

No agreements are pending, good?

But also, it doesn't look like any agreements got agreed to today, so I don't know if anything changed. EDIT: oops, missed the accepted data, so the CLI license accept may have taken effect.

@AshCripps
Copy link
Member

sudo xcodebuild -license <-- I did that, and agreed, but the output doesn't give any suggestion of whether it had previously been agreed or not.

It appears our docs are wrong again ill update nodejs/build#2270 with sudo xcodebuild -license

@BethGriggs
Copy link
Member Author

@sam-github unfortunately hit the same error on latest couple of runs:

20:13:53 2020-04-07T12:13:27.846-0700 [INFO]  notarize: notarization submission complete: output="<?xml version="1.0" encoding="UTF-8"?>
20:13:53 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
20:13:53 <plist version="1.0">
20:13:53 <dict>
20:13:53 	<key>os-version</key>
20:13:53 	<string>10.15.1</string>
20:13:53 	<key>product-errors</key>
20:13:53 	<array>
20:13:53 		<dict>
20:13:53 			<key>code</key>
20:13:53 			<integer>1048</integer>
20:13:53 			<key>message</key>
20:13:53 			<string>You must first sign the relevant contracts online. (1048)</string>
20:13:53 			<key>userInfo</key>
20:13:53 			<dict>
20:13:53 				<key>NSLocalizedDescription</key>
20:13:53 				<string>You must first sign the relevant contracts online. (1048)</string>
20:13:53 				<key>NSLocalizedFailureReason</key>
20:13:53 				<string>You must first sign the relevant contracts online. (1048)</string>
20:13:53 				<key>NSLocalizedRecoverySuggestion</key>
20:13:53 				<string>You must first sign the relevant contracts online. (1048)</string>
20:13:53 			</dict>
20:13:53 		</dict>
20:13:53 	</array>
20:13:53 	<key>tool-path</key>
20:13:53 	<string>/Applications/Xcode.app/Contents/SharedFrameworks/ContentDeliveryServices.framework/Versions/A/Frameworks/AppStoreService.framework</string>
20:13:53 	<key>tool-version</key>
20:13:53 	<string>4.00.1181</string>
20:13:53 </dict>
20:13:53 </plist>
20:13:53 " err="exit status 24"
20:13:53     Error notarizing
20:13:53 
20:13:53 ❗️ Error notarizing:
20:13:53 
20:13:53 1 error occurred:
20:13:53 	* 1 error occurred:
20:13:53 	* You must first sign the relevant contracts online. (1048) (1048)

https://ci-release.nodejs.org/job/iojs+release/nodes=osx1015-release-pkg/5835/console

@MylesBorins
Copy link
Member

I think there might be something we need to agree to on the apple website and my understanding is that it requires @rvagg's 2FA

@mhdawson is on it afaik

@sam-github
Copy link
Contributor

OK, so the language makes this sound like it has nothing to do with accepting the xcode license, but instead accepting some kind of license related to the meaning of notarization.

https://forums.developer.apple.com/thread/117351

that infamous 1048 error

I logged into itunes connect, which changed to https://appstoreconnect.apple.com/, switched to the node.js account, accepted a license...

The updated Apple Developer Program License Agreement needs to be reviewed. In order to update your existing apps and submit new apps to the App Store, a user with the Legal role must review and accept the updated agreement.

I see under licenses and agreements, but not clear idea of how to agree. There is an Action column, but contents are blank. Might be just Rod that can do this.

@sam-github
Copy link
Contributor

@nodejs/releasers I suggest that if its not already the case, that release candidates be notarized, so that as much of the day-of release process as possible is exercised when doing the release candidates.

@BethGriggs
Copy link
Member Author

BethGriggs commented Apr 7, 2020 •
edited

@sam-github - v10.20.0-rc.2 was notarized successfully. rc.2 was built to test the notarization changes, as that is when the relevant notarization commits were pulled in.

https://ci-release.nodejs.org/job/iojs+release/nodes=osx1015-release-pkg/5820/console

All release lines are now seeing this error (including v14.x nightly), so it probably warrants a new issue over in nodejs/build

EDIT: raised nodejs/build#2271

@BethGriggs BethGriggs mentioned this pull request Apr 7, 2020
Closed
@sam-github
Copy link
Contributor

I see, so its not that it wasn't tested e2e, its more likely something apple-side changed, maybe a new license agreement.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30544/

@mhdawson
Copy link
Member

mhdawson commented Apr 7, 2020 •
edited

I did log into our apple developer account, and from the message only the account holder can accept. Rod had tried to give more of us access but the 2fa that apple has in place makes this more difficult than if they used standard 2fa processes/technologies. At this point we'll have to wait.

@rvagg
Copy link
Member

rvagg commented Apr 7, 2020

I think I have it sorted and have kicked off the macos 10.20.0 build to see. Will explain this deeply frustrating Apple garbage in a nodejs/build.

@rvagg
Copy link
Member

rvagg commented Apr 8, 2020

CI got this from Apple:

09:57:34 * Unable to process developerIDPlusInfoForPackageWithArguments request at this time due to a general error (1510)

But got an email:

Your Mac software has been notarized. You can now export this software and distribute it directly to users.

Bundle Identifier: org.nodejs.pkg.v10.20.0
Request Identifier: 0aa1488f-8357-49e2-ace3-44b36b4d015a

So there's still something amiss. It could be because we had an authentication mixup trying to get Michael into that root account. I'm trying again now.

@rvagg
Copy link
Member

rvagg commented Apr 8, 2020

Got it! The next one was stuck in a notarization queue, took 53 minutes (welcome to the norm for releases folks!). But it should be in staging now @BethGriggs . Pay careful attention to the expected-assets check when you run the release script, if you don't have a green tick then don't proceed.
https://ci-release.nodejs.org/job/iojs+release/5839/nodes=osx1015-release-pkg/

@codebytere
Copy link
Member

@rvagg should this be sorted for v12.16.2 as well now?

@rvagg
Copy link
Member

rvagg commented Apr 8, 2020

ah yes, @codebytere should be fixed for all, I'll let you re-run 12.16.2. I saw a 14.0.0-rc in there too that I'll rerun.

@BethGriggs
2020-04-08, Version 10.20.0 'Dubnium' (LTS)
246eede 
macOS package notarization and a change in builder configuration

The macOS binaries for this release, and future 10.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing .pkg files on macOS
10.15 and later. Previous builds of Node.js 10.x were compiled on macOS
10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion).
As binaries are still being compiled to support a minimum of macOS 10.7
(Lion) we do not anticipate this having a negative impact on Node.js
10.x users with older versions of macOS.

Notable changes:

- buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc)
  [#19691](#19691)
- build: macOS package notarization (Rod Vagg)
  [#31459](#31459)
- deps:
  - update npm to 6.14.3 (Myles Borins)
    [#32368](#32368)
  - upgrade openssl sources to 1.1.1e (Hassaan Pasha)
    [#32328](#32328)
  - upgrade to libuv 1.34.2 (cjihrig)
    [#31477](#31477)
- n-api:
  - add napi\_get\_all\_property\_names (himself65)
    [#30006](#30006)
  - add APIs for per-instance state management (Gabriel Schulhof)
    [#28682](#28682)
  - define release 6
    [#32058](#32058)
  - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen)
    [#26128](#26128)
- tls:
  - expose keylog event on TLSSocket (Alba Mendez)
    [#27654](#27654)
  - support TLS min/max protocol defaults in CLI (Sam Roberts)
    [#27946](#27946)
- url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig)
  [#26226](#26226)

PR-URL: #31984
@BethGriggs BethGriggs merged commit 246eede into v10.x Apr 8, 2020
BethGriggs added a commit that referenced this pull request Apr 8, 2020
@BethGriggs
Working on v10.20.1
670f3db 
PR-URL: #31984
BethGriggs added a commit that referenced this pull request Apr 8, 2020
@BethGriggs
2020-04-08, Version 10.20.0 'Dubnium' (LTS)
9b46e3f 
macOS package notarization and a change in builder configuration

The macOS binaries for this release, and future 10.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing .pkg files on macOS
10.15 and later. Previous builds of Node.js 10.x were compiled on macOS
10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion).
As binaries are still being compiled to support a minimum of macOS 10.7
(Lion) we do not anticipate this having a negative impact on Node.js
10.x users with older versions of macOS.

Notable changes:

- buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc)
  [#19691](#19691)
- build: macOS package notarization (Rod Vagg)
  [#31459](#31459)
- deps:
  - update npm to 6.14.3 (Myles Borins)
    [#32368](#32368)
  - upgrade openssl sources to 1.1.1e (Hassaan Pasha)
    [#32328](#32328)
  - upgrade to libuv 1.34.2 (cjihrig)
    [#31477](#31477)
- n-api:
  - add napi\_get\_all\_property\_names (himself65)
    [#30006](#30006)
  - add APIs for per-instance state management (Gabriel Schulhof)
    [#28682](#28682)
  - define release 6
    [#32058](#32058)
  - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen)
    [#26128](#26128)
- tls:
  - expose keylog event on TLSSocket (Alba Mendez)
    [#27654](#27654)
  - support TLS min/max protocol defaults in CLI (Sam Roberts)
    [#27946](#27946)
- url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig)
  [#26226](#26226)

PR-URL: #31984
@BethGriggs BethGriggs mentioned this pull request Apr 8, 2020
Merged
BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Apr 8, 2020
@BethGriggs
Blog: v10.20.0 release post
f69b94f 
Refs: nodejs/node#31984
BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Apr 8, 2020
@BethGriggs
Blog: v10.20.0 release post (#3085)
f556f24 
Refs: nodejs/node#31984
@BethGriggs BethGriggs mentioned this pull request Apr 10, 2020
Merged
@BethGriggs BethGriggs deleted the v10.20.0-proposal branch April 12, 2020 13:38
BethGriggs added a commit that referenced this pull request Apr 14, 2020
@BethGriggs
2020-04-08, Version 10.20.0 'Dubnium' (LTS)
8d8095f 
macOS package notarization and a change in builder configuration

The macOS binaries for this release, and future 10.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing .pkg files on macOS
10.15 and later. Previous builds of Node.js 10.x were compiled on macOS
10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion).
As binaries are still being compiled to support a minimum of macOS 10.7
(Lion) we do not anticipate this having a negative impact on Node.js
10.x users with older versions of macOS.

Notable changes:

- buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc)
  [#19691](#19691)
- build: macOS package notarization (Rod Vagg)
  [#31459](#31459)
- deps:
  - update npm to 6.14.3 (Myles Borins)
    [#32368](#32368)
  - upgrade openssl sources to 1.1.1e (Hassaan Pasha)
    [#32328](#32328)
  - upgrade to libuv 1.34.2 (cjihrig)
    [#31477](#31477)
- n-api:
  - add napi\_get\_all\_property\_names (himself65)
    [#30006](#30006)
  - add APIs for per-instance state management (Gabriel Schulhof)
    [#28682](#28682)
  - define release 6
    [#32058](#32058)
  - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen)
    [#26128](#26128)
- tls:
  - expose keylog event on TLSSocket (Alba Mendez)
    [#27654](#27654)
  - support TLS min/max protocol defaults in CLI (Sam Roberts)
    [#27946](#27946)
- url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig)
  [#26226](#26226)

PR-URL: #31984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

@MylesBorins MylesBorins Awaiting requested review from MylesBorins

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet