Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10.20.0 proposal #31984

Merged
merged 56 commits into from Apr 8, 2020
Merged

v10.20.0 proposal #31984

merged 56 commits into from Apr 8, 2020

Commits on Feb 14, 2020

  1. deps: upgrade npm to 6.13.6

    PR-URL: #31304
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ruyadorno authored and MylesBorins committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    db24641 View commit details
    Browse the repository at this point in the history
  2. deps: upgrade npm to 6.13.7

    PR-URL: #31558
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Michael Perrotte authored and MylesBorins committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    7eac959 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2020

  1. test: try to stabalize test-child-process-fork-exec-path.js

    PR-URL: #27277
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    refack authored and BethGriggs committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    2315270 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. test: mark http2 tests as flaky on 10.x

    These tests are already marked as flaky on 12.x and master.
    
    PR-URL: #31887
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    AshCripps authored and BethGriggs committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    a8fd8a1 View commit details
    Browse the repository at this point in the history
  2. test: mark tests as flaky

    PR-URL: #30848
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    joaocgreis authored and BethGriggs committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    4b9a779 View commit details
    Browse the repository at this point in the history
  3. test: allow EAI_FAIL in test-http-dns-error.js

    EAI_FAIL is expected on OpenBSD, and has been observed on
    platforms such as FreeBSD and Windows. This commit makes
    EAI_FAIL an acceptable error code on all platforms.
    
    PR-URL: #27500
    Fixes: #27487
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cjihrig authored and BethGriggs committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    f1a8791 View commit details
    Browse the repository at this point in the history
  4. tls: support TLS min/max protocol defaults in CLI

    Backport CLI switches for default TLS versions:
    - `--tls-max-v1.2`
    - `--tls-min-v1.0`
    - `--tls-min-v1.1`
    - `--tls-min-v1.2`
    
    PR-URL: #27946
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    sam-github authored and BethGriggs committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    1cfb457 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. buffer: add {read|write}Big[U]Int64{BE|LE} methods

    Backport-PR-URL: #30361
    PR-URL: #19691
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    GaryGSC authored and BethGriggs committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    64744a2 View commit details
    Browse the repository at this point in the history
  2. test: add debugging output to test-net-listen-after-destroy-stdin

    The test failed in CI once with a timeout but there is insufficient
    information to further debug. Add additional debugging information.
    
    Refactored callbacks to be arrow functions, since that seems to be the
    direction we're moving.
    
    PR-URL: #31698
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Trott authored and BethGriggs committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    3f9cec3 View commit details
    Browse the repository at this point in the history
  3. n-api: turn NAPI_CALL_INTO_MODULE into a function

    These do not need to be macros.
    
    PR-URL: #26128
    Backport-PR-URL: #30537
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and BethGriggs committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    20177b9 View commit details
    Browse the repository at this point in the history
  4. n-api: add APIs for per-instance state management

    Adds `napi_set_instance_data()` and `napi_get_instance_data()`, which
    allow native addons to store their data on and retrieve their data from
    `napi_env`. `napi_set_instance_data()` accepts a finalizer which is
    called when the `node::Environment()` is destroyed.
    
    This entails rendering the `napi_env` local to each add-on.
    
    Fixes: nodejs/abi-stable-node#378
    PR-URL: #28682
    Backport-PR-URL: #30537
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Gabriel Schulhof authored and BethGriggs committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    f29fb14 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2020

  1. v8: fix load elimination liveness checks

    This commit back-ports the implementations of IsRename() and MayAlias()
    from the upstream 8.0 branch wholesale. Fixes several bugs where V8's
    load elimination pass considered values to be alive when they weren't.
    
    Fixes: #31484
    
    PR-URL: #31613
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    bnoordhuis authored and BethGriggs committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    dc61e09 View commit details
    Browse the repository at this point in the history
  2. deps: V8: cherry-pick d89f4ef1cd62

    PR-URL: #31753
    Refs: v8/v8@d89f4ef
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Milad Farazmand authored and BethGriggs committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    9b2b66b View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. test: scale keepalive timeouts for slow machines

    The test was using fixed timeouts and that seems to be causing sporadic
    test failures on pi1-docker host (which is a very slow machine.)
    
    Fixes: #30828
    
    PR-URL: #30834
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    bnoordhuis authored and BethGriggs committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    5484e06 View commit details
    Browse the repository at this point in the history
  2. build,win: fix goto exit in vcbuild

    PR-URL: #30931
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    joaocgreis authored and BethGriggs committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    42af3b8 View commit details
    Browse the repository at this point in the history
  3. doc: fix changelog for v10.18.1

    PR-URL: #31358
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    andrewhughes101 authored and BethGriggs committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    ffa9f9b View commit details
    Browse the repository at this point in the history
  4. test: mark empty udp tests flaky on OS X

    They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X.
    
    Refs: #30030
    Refs: nodejs/build#2189 (comment)
    
    PR-URL: #31936
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    sam-github authored and BethGriggs committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    9bd1317 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2020

  1. n-api: add napi_get_all_property_names

    Co-Authored-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    
    PR-URL: #30006
    Backport-PR-URL: #31384
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    himself65 authored and BethGriggs committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    ecbb331 View commit details
    Browse the repository at this point in the history
  2. deps: upgrade to libuv 1.29.1

    Notable changes:
    
    - uv_get_constrained_memory() has been added.
    - A race condition in uv_async_send() has been fixed.
    - uv_get_free_memory() and uv_get_total_memory() now read from
      /proc/meminfo, which should improve correctness when called
      from inside an lxc container.
    - A failed assertion in uv_fs_poll_stop() has been fixed.
    - A bug in MAC addresses for IP-aliases has been fixed.
    
    Fixes: #27170
    Fixes: #27493
    PR-URL: #27718
    Backport-PR-URL: #31969
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and BethGriggs committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    b53ce6e View commit details
    Browse the repository at this point in the history
  3. deps: upgrade to libuv 1.30.0

    Notable changes:
    
    - Support for the Haiku platform has been added.
    - The maximum UV_THREADPOOL_SIZE has been increased from
      128 to 1024.
    - uv_fs_copyfile() now works properly when the source and
      destination files are the same.
    
    PR-URL: #28449
    Backport-PR-URL: #31969
    Fixes: #27746
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    cjihrig authored and BethGriggs committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    7cde563 View commit details
    Browse the repository at this point in the history
  4. deps: upgrade to libuv 1.30.1

    This upgrade is a small patch release, fixing compilation
    errors on Android, Cygwin, and uClibc - none of which are
    tested in the CI.
    
    PR-URL: #28511
    Backport-PR-URL: #31969
    Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    cjihrig authored and BethGriggs committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    ed71f55 View commit details
    Browse the repository at this point in the history
  5. deps: upgrade to libuv 1.31.0

    Notable changes:
    
    - UV_FS_O_FILEMAP has been added for faster access to memory
      mapped files on Windows.
    - uv_fs_mkdir() now returns UV_EINVAL for invalid filenames
      on Windows. It previously returned UV_ENOENT.
    - The uv_fs_statfs() API has been added.
    - The uv_os_environ() and uv_os_free_environ() APIs have
      been added.
    
    Fixes: #28599
    Fixes: #28945
    Fixes: #29008
    PR-URL: #29070
    Backport-PR-URL: #31969
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    cjihrig authored and BethGriggs committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    794abbc View commit details
    Browse the repository at this point in the history
  6. deps: upgrade to libuv 1.32.0

    Notable changes:
    
    - `uv_tcp_close_reset()` has been added.
    - `uv_udp_set_source_membership()` has been added.
    - A double free in `uv_free_cpu_info()` on OpenBSD
      has been fixed.
    - Defined, but empty environment variables can now
      be read on Windows.
    - Several improvements to the cmake build process.
    - The `EILSEQ` error code is now mapped by libuv.
    
    PR-URL: #29508
    Backport-PR-URL: #31969
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and BethGriggs committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    aed7ca4 View commit details
    Browse the repository at this point in the history
  7. deps: upgrade to libuv 1.33.1

    Notable changes:
    
    - uv_random() has been added.
    - More work to read those pesky Windows
      environment variables.
    - Several build fixes for Tier 3 platforms (Android,
      NetBSD, OpenBSD, Haiku).
    - Stop using fsevents to watch files (using kqueue again).
    
    PR-URL: #29996
    Backport-PR-URL: #31969
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    cjihrig authored and BethGriggs committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    6826ef0 View commit details
    Browse the repository at this point in the history
  8. deps: upgrade to libuv 1.34.0

    Notable changes:
    
    - Fix handling of large files in uv_fs_copyfile().
      Fixes: #30085
    - Fix Android build errors.
    - uv_sleep() has been added.
    - uv_interface_addresses() IPv6 netmask support has been fixed.
      Fixes: #30504
    - uv_fs_mkstemp() has been added.
    
    PR-URL: #30783
    Backport-PR-URL: #31969
    Fixes: #30085
    Fixes: #30504
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    cjihrig authored and BethGriggs committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    fff6162 View commit details
    Browse the repository at this point in the history
  9. deps: upgrade to libuv 1.34.1

    Notable changes:
    
    - uv_fs_copyfile() now supports CIFS share destinations.
    - isatty() now works on IBMi
    - TTYs are opened with the O_NOCTTY flag.
    
    Fixes: #31170
    
    PR-URL: #31332
    Backport-PR-URL: #31969
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    cjihrig authored and BethGriggs committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    4b1cccc View commit details
    Browse the repository at this point in the history
  10. deps: upgrade to libuv 1.34.2

    Notable changes:
    
    - SetApplicationDaemon() is no longer called on macOS.
    - uv_interface_addresses() is implemented on IBMi.
    - The return value of uv__open_cloexec() is now handled
      properly.
    - A race condition in fsevents has been fixed.
    
    Fixes: #31328
    Fixes: nodejs/help#2099
    
    PR-URL: #31477
    Backport-PR-URL: #31969
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cjihrig authored and BethGriggs committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    098704c View commit details
    Browse the repository at this point in the history
  11. tools: use CC instead of CXX when pointing to gcc

    Current CC flag points to g++ instead of gcc which is causing failures
    when compiling V8.
    
    PR-URL: #30817
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Milad Farazmand authored and BethGriggs committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    61e2d48 View commit details
    Browse the repository at this point in the history
  12. tools: unify make-v8.sh for ppc64le and s390x

    Refactor `tools/make-v8.sh` to minimise differences between the
    `ppc64le` and `s390x` paths to allow us to enable `ccache` on the
    `ppc64le` machines in the CI.
    
    PR-URL: #31628
    Refs: nodejs/build#1927
    Refs: nodejs/build#1940
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    richardlau authored and BethGriggs committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    f235eea View commit details
    Browse the repository at this point in the history
  13. deps: openssl: cherry-pick 4dcb150ea30f

    OpenSSL 1.1.1d does not ship with getrandom syscall being
    predefined on all architectures. So when NodeJS is run with glibc
    prior to 2.25, where getentropy is unavailable, and the getrandom
    syscall is unknown, it will fail. PPC64LE or s390 are affected
    by lack of this definition.
    
    Original commit message.
    
        commit 4dcb150ea30f9bbfa7946e6b39c30a86aca5ed02
        Author: Kurt Roeckx <kurt@roeckx.be>
        Date:   Sat Sep 28 14:59:32 2019 +0200
    
          Add defines for __NR_getrandom for all Linux architectures
    
          Fixes: openssl/openssl#10015
    
          Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
          GH: openssl/openssl#10044
    
    Fixes: #31671
    PR-URL: #32002
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    AdamMajer authored and BethGriggs committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    47046aa View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. console: add trace-events for time and count

    Add the `node.console` trace event category to capture
    `console.count()`, `console.countReset()`, `console.time()`,
    `console.timeLog()`, and `console.timeEnd()` to the trace
    event log.
    
    PR-URL: #23703
    Backport-PR-URL: #28840
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    jasnell authored and BethGriggs committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    b164a2e View commit details
    Browse the repository at this point in the history
  2. doc: remove em dashes

    Our documentation uses em dashes inconsistently. They are treated
    inconsistently typographically too. (For example, they are sometimes
    surrounded by spaces and sometimes not.) They are also often confused
    with ordinary hyphens such as in the CHANGELOG, where they are
    inadvertently mixed together in a single list. The difference is
    not obvious in the raw markdown but is very noticeable when rendered,
    appearing to be a typographical error (which it in fact is).
    
    The em dash is never needed. There are always alternatives. Remove em
    dashes entirely.
    
    PR-URL: #32080
    Backport-PR-URL: #32149
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and BethGriggs committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    05f5b3e View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. tls: expose keylog event on TLSSocket

    Exposes SSL_CTX_set_keylog_callback in the form of a `keylog` event
    that is emitted on clients and servers. This enables easy debugging
    of TLS connections with i.e. Wireshark, which is a long-requested
    feature.
    
    PR-URL: #27654
    Backport-PR-URL: #31582
    Refs: #2363
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mildsunrise authored and BethGriggs committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    a2b0e9e View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. deps: upgrade npm to 6.14.1

    PR-URL: #31977
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    isaacs authored and BethGriggs committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    8cae4dd View commit details
    Browse the repository at this point in the history
  2. deps: update npm to 6.14.3

    PR-URL: #32368
    Refs: #32296
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    MylesBorins authored and BethGriggs committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    c2b3cf6 View commit details
    Browse the repository at this point in the history
  3. deps: remove *.pyc files from deps/npm

    These seem to have accidentally slipped into the npm source tarball and
    cause problems when contributors update their git checkout of node.
    
    PR-URL: #32387
    Refs: #32368
    Refs: npm/cli#1037
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    bnoordhuis authored and BethGriggs committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    bf26c44 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. deps: upgrade openssl sources to 1.1.1e

    This updates all sources in deps/openssl/openssl by:
        $ cd deps/openssl/
        $ rm -rf openssl
        $ tar zxf ~/tmp/openssl-1.1.1e.tar.gz
        $ mv openssl-1.1.1e openssl
        $ git add --all openssl
        $ git commit openssl
    
    PR-URL: #32328
    Backport-PR-URL: #32443
    Fixes: #32210
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    hassaanp authored and BethGriggs committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    c8f5ab2 View commit details
    Browse the repository at this point in the history
  2. deps: adjust openssl configuration for 1.1.1e

    The scripts used by make were modified to correctly reference the source
    files that were originially in crypto/include/internal, but got moved to
    include/crypto.  The base path has been left unaltered since that would
    require too many changes
    
    PR-URL: #32328
    Backport-PR-URL: #32443
    Fixes: #32210
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    hassaanp authored and BethGriggs committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    64c1848 View commit details
    Browse the repository at this point in the history
  3. deps: update archs files for OpenSSL-1.1.1e

    After an OpenSSL source update, all the config files need to be
    regenerated and comitted by:
        $ cd deps/openssl/config
        $ make
        $ git add deps/openssl/config/archs
        $ git add deps/openssl/include
    
    PR-URL: #32328
    Backport-PR-URL: #32443
    Fixes: #32210
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    hassaanp authored and BethGriggs committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    76033c5 View commit details
    Browse the repository at this point in the history
  4. test: end tls connection with some data

    In openssl-1.1.1e the client doesn't seem to like having the TLS
    connection shut down with no data sent, so send an empty string. A
    number of related issues showed up in the TLS1.3 port, so this is
    not entirely surprising.
    
    PR-URL: #32328
    Backport-PR-URL: #32443
    Fixes: #32210
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    sam-github authored and BethGriggs committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    89692ff View commit details
    Browse the repository at this point in the history
  5. url: handle quasi-WHATWG URLs in urlToOptions()

    PR-URL: #26226
    Backport-PR-URL: #32446
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    cjihrig authored and BethGriggs committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    4390674 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. doc: update releaser list in README.md

    Moved emeritus members keys and fixed alphabetization issues
    
    PR-URL: #32577
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    MylesBorins committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    aa7d369 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. deps: update term-size with signed version

    Backport-PR-URL: #32528
    PR-URL: #31459
    Refs: #29216
    Refs: sindresorhus/macos-terminal-size#3
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
    Signed-off-by: Rod Vagg <rod@vagg.org>
    rvagg authored and MylesBorins committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    8d85a43 View commit details
    Browse the repository at this point in the history
  2. deps: upgrade npm to 6.14.4

    Backport-PR-URL: #32528
    PR-URL: #32495
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    ruyadorno authored and MylesBorins committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    04cd67f View commit details
    Browse the repository at this point in the history
  3. build: macOS package notarization

    Includes hardened-runtime patch from gdams from
    #29216 (comment)
    
    Backport-PR-URL: #32528
    PR-URL: #31459
    Refs: #29216
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
    Signed-off-by: Rod Vagg <rod@vagg.org>
    rvagg authored and MylesBorins committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    8a0ed8f View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. n-api: correct instance data tests

    When instance data was backported, some of the tests ended up in a
    location where they do not get run. This moves the tests into
    test/addons-napi, merging them with existing tests therein, thereby
    ensuring that they do get run.
    
    PR-URL: #32488
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Gabriel Schulhof authored and BethGriggs committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    239377b View commit details
    Browse the repository at this point in the history
  2. n-api: define release 6

    Mark all N-APIs that have been added since version 5 as stable.
    
    PR-URL: #32058
    Backport-PR-URL: #32488
    Fixes: nodejs/abi-stable-node#393
    Co-Authored-By: legendecas <legendecas@gmail.com>
    Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    2 people authored and BethGriggs committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    e9c590e View commit details
    Browse the repository at this point in the history
  3. doc: add missing version metadata for Readable.from

    Fixes: #28693
    
    PR-URL: #28695
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    addaleax authored and BethGriggs committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    34c1c2a View commit details
    Browse the repository at this point in the history
  4. doc: correct version metadata for Readable.from

    PR-URL: #32639
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    kzar authored and BethGriggs committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    2e3d511 View commit details
    Browse the repository at this point in the history
  5. doc,tools: get altDocs versions from CHANGELOG.md

    Parse `CHANGELOG.md` for versions of Node.js used by the documentation
    feature `View another version` so that we don't have to manually update
    the list when we cut a new version or transition a release to LTS.
    
    Backport-PR-URL: #32642
    PR-URL: #27661
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    richardlau authored and BethGriggs committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    0177464 View commit details
    Browse the repository at this point in the history
  6. test: fix flaky doctool and test

    Doctool tests have been failing a lot in CI on Win2008 R2. It appears
    async functions and callback-based functions are being used in
    combination such that the callback-based function cannot guarantee that
    it will invoke its callback. Convert the callback-based functions to
    async functions so we have one paradigm and reliable results.
    
    Backport-PR-URL: #32642
    PR-URL: #29979
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Trott authored and BethGriggs committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    1ea70d6 View commit details
    Browse the repository at this point in the history
  7. tools: make doctool work if no internet available

    Allow doctool to fallback to use local files if not building a release
    build.
    
    Backport-PR-URL: #32642
    PR-URL: #30214
    Fixes: #29918
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    richardlau authored and BethGriggs committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    ac1ea73 View commit details
    Browse the repository at this point in the history
  8. tools: add NODE_TEST_NO_INTERNET to the doc builder

    At the moment the doc builder tries to access the internet
    for CHANGELOG information and only falls back to local sources
    after the connection fails or a 5 second timeout. This means
    that the doc building could take at least 7 minutes on a
    machine with hijacked connection to Github for useless network
    attempts. This patch adds a NODE_TEST_NO_INTERNET environment
    variable to directly bypass these attempts so that docs can be
    built in reasonable time on a machine like that.
    
    Backport-PR-URL: #32642
    PR-URL: #31849
    Fixes: #29918
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    joyeecheung authored and BethGriggs committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    3756be8 View commit details
    Browse the repository at this point in the history
  9. tools: only fetch previous versions when necessary

    Refactor the logic for working out the previous versions of Node.js for
    the API documentation so that the parsing (including the potential https
    get) happens at most once per build (as opposed to the current once per
    generated API doc).
    
    Signed-off-by: Richard Lau <riclau@uk.ibm.com>
    
    Backport-PR-URL: #32642
    PR-URL: #32518
    Fixes: #32512
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    richardlau authored and BethGriggs committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    a175b8d View commit details
    Browse the repository at this point in the history
  10. test: fix tool path in test-doctool-versions.js

    Path to the versions tool tested by test-doctool-versions.js would
    be incorrect if the test temporary directory was redirected (e.g.
    via NODE_TEST_DIR) outside of `test/`.
    
    Signed-off-by: Richard Lau <riclau@uk.ibm.com>
    
    Backport-PR-URL: #32642
    PR-URL: #32645
    Refs: #32518
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    richardlau authored and BethGriggs committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    017909b View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. 2020-04-08, Version 10.20.0 'Dubnium' (LTS)

    macOS package notarization and a change in builder configuration
    
    The macOS binaries for this release, and future 10.x releases, are now
    being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
    package notarization, a requirement for installing .pkg files on macOS
    10.15 and later. Previous builds of Node.js 10.x were compiled on macOS
    10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion).
    As binaries are still being compiled to support a minimum of macOS 10.7
    (Lion) we do not anticipate this having a negative impact on Node.js
    10.x users with older versions of macOS.
    
    Notable changes:
    
    - buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc)
      [#19691](#19691)
    - build: macOS package notarization (Rod Vagg)
      [#31459](#31459)
    - deps:
      - update npm to 6.14.3 (Myles Borins)
        [#32368](#32368)
      - upgrade openssl sources to 1.1.1e (Hassaan Pasha)
        [#32328](#32328)
      - upgrade to libuv 1.34.2 (cjihrig)
        [#31477](#31477)
    - n-api:
      - add napi\_get\_all\_property\_names (himself65)
        [#30006](#30006)
      - add APIs for per-instance state management (Gabriel Schulhof)
        [#28682](#28682)
      - define release 6
        [#32058](#32058)
      - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen)
        [#26128](#26128)
    - tls:
      - expose keylog event on TLSSocket (Alba Mendez)
        [#27654](#27654)
      - support TLS min/max protocol defaults in CLI (Sam Roberts)
        [#27946](#27946)
    - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig)
      [#26226](#26226)
    
    PR-URL: #31984
    BethGriggs committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    246eede View commit details
    Browse the repository at this point in the history