Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v13.10.1 proposal #32099

Merged
merged 17 commits into from Mar 5, 2020
Merged

v13.10.1 proposal #32099

merged 17 commits into from Mar 5, 2020

Commits on Mar 4, 2020

  1. doc: update stream.pipeline() signature 

    The  `...transforms` parameter is optional.

Refs: https://github.com/nodejs/node/blob/0875837417/lib/internal/streams/pipeline.js#L130-L132
Refs: https://github.com/nodejs/node/blob/e559842188/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators

PR-URL: #31789
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @vsemozhetbyt @MylesBorins
    vsemozhetbyt authored and MylesBorins committed Mar 4, 2020
    Copy the full SHA
    ba3f7ff View commit details
    Browse the repository at this point in the history

  2. crypto: simplify exportKeyingMaterial 

    PR-URL: #31922
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
    @tniessen @MylesBorins
    tniessen authored and MylesBorins committed Mar 4, 2020
    Copy the full SHA
    0fc45f8 View commit details
    Browse the repository at this point in the history

  3. src: improve handling of internal field counting 

    Change suggested by bnoordhuis.

Improve handing of internal field counting by using enums.
Helps protect against future possible breakage if field
indexes are ever changed or added to.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #31960
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @jasnell @MylesBorins
    jasnell authored and MylesBorins committed Mar 4, 2020
    Copy the full SHA
    4d5318c View commit details
    Browse the repository at this point in the history

  4. perf,src: add HistogramBase and internal/histogram.js 

    Separating this out from the QUIC PR to allow it to be separately
reviewed. The QUIC implementation makes use of the hdr_histogram
for dynamic performance monitoring. This introduces a BaseObject
class that allows the internal histograms to be accessed on the
JavaScript side and adds a generic Histogram class that will be
used by both QUIC and perf_hooks (for the event loop delay
monitoring).

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #31988
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @jasnell @MylesBorins
    jasnell authored and MylesBorins committed Mar 4, 2020
    Copy the full SHA
    6b44df2 View commit details
    Browse the repository at this point in the history

  5. test: remove common.port from test-tls-securepair-client 

    OpenSSL s_server accepts port 0 as an indicator to use an open port
provided by the operating system. Use that instead of common.PORT in the
test.

Remove 500ms delay added in 8e46167.
Hopefully the race condition in OpenSSL s_server has been fixed and/or
the change to port 0 means that the server is listening by the time
the ACCEPT text is printed and the setTimeout() is no longer necessary.

PR-URL: #32024
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    @Trott @MylesBorins
    Trott authored and MylesBorins committed Mar 4, 2020
    Copy the full SHA
    be90817 View commit details
    Browse the repository at this point in the history

  6. events: convert errorMonitor to a normal property 

    Convert property errorMonitor to a normal property as non-writable
caused unwanted side effects.

Refs: #30932 (comment)

PR-URL: #31848
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @Flarna @MylesBorins
    Flarna authored and MylesBorins committed Mar 4, 2020
    Copy the full SHA
    3c8daa3 View commit details
    Browse the repository at this point in the history

  7. test: add GC test for disabled AsyncLocalStorage 

    PR-URL: #31995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @puzpuzpuz @MylesBorins
    puzpuzpuz authored and MylesBorins committed Mar 4, 2020
    Copy the full SHA
    1539928 View commit details
    Browse the repository at this point in the history

  8. src: add node_crypto_common and refactor 

    Two things in one on this commit:

(a) For the QUIC implementation, we need to separate out various bits
    from node_crypto.cc to allow them to be reused. That's where this
    commit starts.

(b) Quite a bit of the node_crypto.cc code was just messy in terms of
    it's organization and lack of error handling and use of Local vs.
    MaybeLocal. This cleans that up a bit and hopefully makes certain
    parts a bit more manageable also.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #32016
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    @jasnell @MylesBorins
    jasnell authored and MylesBorins committed Mar 4, 2020
    Copy the full SHA
    755da03 View commit details
    Browse the repository at this point in the history

  9. src: start the .text section with an asm symbol 

    We create an object file in assembly which introduces the symbol
`__node_text_start` into the .text section and place the resulting
object file as the first file the linker encounters. We do this to
ensure that we can recognize the boundaries of the .text section when
attempting to establish the address range to map to large pages.

Additionally, we rename the section containing the remapping code from
`.lpstub` to `lpstub` so as to take advantage of the linker's feature
whereby it inserts the symbol `__start_lpstub` when the section's name
can be rendered as a valid C variable. We need this symbol in order to
avoid self-mapping the remapping code to large pages, because doing so
would cause the process to crash.

PR-URL: #31981
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    @MylesBorins
    Gabriel Schulhof authored and MylesBorins committed Mar 4, 2020
    Copy the full SHA
    70f0460 View commit details
    Browse the repository at this point in the history

  10. build: add asan check in Github action 

    PR-URL: #31902
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @gengjiawen @MylesBorins
    gengjiawen authored and MylesBorins committed Mar 4, 2020
    Copy the full SHA
    478450d View commit details
    Browse the repository at this point in the history

  11. dgram: make UDPWrap more reusable 

    Allow using the handle more directly for I/O in other parts of
the codebase.

Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#165
  Reviewed-By: James M Snell <jasnell@gmail.com>
  Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
```

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #31871
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @addaleax @MylesBorins
    addaleax authored and MylesBorins committed Mar 4, 2020
    Copy the full SHA
    4dc59b9 View commit details
    Browse the repository at this point in the history

  12. build: fix building with ninja 

    The ninja build places objects in a different directory.

Co-authored-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #32071
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    @richardlau @MylesBorins
    richardlau authored and MylesBorins committed Mar 4, 2020
    Copy the full SHA
    9c1ac50 View commit details
    Browse the repository at this point in the history

  13. doc: improve doc/markdown file organization coherence 

    * Updated cpp style guide file name and location and fixed links to
  this file.

* Updated collaborator guide file name and location and fixed links
  to this file.

* Updated documentation style guide file name and location and updated
  links referencing the file.

* Moved files to appropriate location and updated naming style for
  some of them.

Fixes: #31741

PR-URL: #31792
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    @ConorDavenport @MylesBorins
    ConorDavenport authored and MylesBorins committed Mar 4, 2020
    Copy the full SHA
    2518213 View commit details
    Browse the repository at this point in the history

  14. doc: visibility of Worker threads cli options 

    Fixes: #28518
PR-URL: #31380
Fixes: #28518
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @HarshithaKP @MylesBorins
    HarshithaKP authored and MylesBorins committed Mar 4, 2020
    Copy the full SHA
    4ed720e View commit details
    Browse the repository at this point in the history

  15. build: fix zlib tarball generation 

    PR-URL: #32094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @codebytere @MylesBorins
    codebytere authored and MylesBorins committed Mar 4, 2020
    Copy the full SHA
    723aa41 View commit details
    Browse the repository at this point in the history

  16. src: pass resource object along with InternalMakeCallback 

    This was an oversight in 9fdb6e6.
Fixing this is necessary to make `executionAsyncResource()` work
as expected.

Refs: #30959
Fixes: #32060

PR-URL: #32063
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @addaleax @MylesBorins
    addaleax authored and MylesBorins committed Mar 4, 2020
    Copy the full SHA
    6a9cea9 View commit details
    Browse the repository at this point in the history

  17. 2020-03-04 Version 13.10.1 (Current) 

    Notable changes:

In Node.js 13.9.0 deps/zlib was switched to the chromium maintained
implementation. This change had the unforseen consequence of breaking
building from the tarballs we release as we were too aggressively
removing `unneccessary files` from the `deps/zlib` folder. This release
includes a patch that ensures that individuals will once again be able
to build Node.js from source.

PR-URL: #32099
    @MylesBorins
    MylesBorins committed Mar 4, 2020
    Copy the full SHA
    59ab6bf View commit details
    Browse the repository at this point in the history