Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: Fix extra includes of "env.h" and "env-inl.h" in this directory. #32293

Closed
wants to merge 3 commits into from
Closed

src: Fix extra includes of "env.h" and "env-inl.h" in this directory. #32293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e26be9
src: fix extra includes of "env.h" and "env-inl.h"
nkreeger Mar 16, 2020
0fbf83b
Merge branch 'master' into kreeger/include-fixes
nkreeger Mar 16, 2020
0805001
Review comments.
nkreeger Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion src/node_crypto_common.h
View file
Open in desktop
Expand Up @@ -3,7 +3,6 @@

#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#include "env.h"
#include "node_crypto.h"
#include "v8.h"
#include <openssl/ssl.h>
Expand Down
3 changes: 2 additions & 1 deletion src/node_sockaddr.h
View file
Open in desktop
Expand Up @@ -3,7 +3,6 @@

#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#include "env.h"
#include "memory_tracker.h"
#include "node.h"
#include "uv.h"
Expand All @@ -14,6 +13,8 @@

namespace node {

class Environment;

class SocketAddress : public MemoryRetainer {
public:
struct Hash {
Expand Down
5 changes: 2 additions & 3 deletions src/stream_base-inl.h
View file
Open in desktop
Expand Up @@ -3,10 +3,9 @@

#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#include "stream_base.h"

#include "async_wrap-inl.h"
#include "node.h"
#include "env-inl.h"
addaleax marked this conversation as resolved.
Show resolved Hide resolved
#include "stream_base.h"
#include "v8.h"

namespace node {
Expand Down
3 changes: 2 additions & 1 deletion src/stream_base.h
View file
Open in desktop
Expand Up @@ -3,7 +3,8 @@

#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#include "async_wrap-inl.h"
#include "env.h"
#include "async_wrap.h"
#include "node.h"
#include "util.h"

Expand Down