Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: Fix extra includes of "env.h" and "env-inl.h" in this directory. #32293
src: Fix extra includes of "env.h" and "env-inl.h" in this directory. #32293
Changes from 1 commit
3e26be9
0fbf83b
0805001
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If removing this works, then it’s by accident – this file does require
env-inl.h
in order to work. Please leave the include here.(You can test this by including only
node_http_common-inl.h
from a.cc
file – compiling that file will fail without this line.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can guarantee that removing this would break on some of the platforms as I had omitted this originally and had to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks - any tips on better build testing? I git grep'ing for these items in header files and running
make -j8 test
as a blanket test. I see the x-platform integration tests pass...@jasnell Please let me know if I'm stomping on anything you're doing. Just looking for some fun side-hacking :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope you're good :-) ... I'll adjust on my end if there are any merge conflicts.