Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasi: avoid hard crash if start() is never called #33184

Closed
wants to merge 1 commit into from
Closed

wasi: avoid hard crash if start() is never called #33184

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 1, 2020

Prior to this commit, calling the WebAssembly instance's _start()
export directly would hard crash the process because the memory
was never configured. This commit adds an additional check that
the memory is usable. With this commit, calling _start() directly
will still lead to WASI exiting with a non-zero exit code, but
Node does not crash.

Fixes: #33175

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@cjihrig
wasi: avoid hard crash if start() is never called
7c2870d 
Prior to this commit, calling the WebAssembly instance's _start()
export directly would hard crash the process because the memory
was never configured. This commit adds an additional check that
the memory is usable. With this commit, calling _start() directly
will still lead to WASI exiting with a non-zero exit code, but
Node does not crash.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. wasi Issues and PRs related to the WebAssembly System Interface. labels May 1, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 1, 2020 •
edited by cjihrig

CI: https://ci.nodejs.org/job/node-test-pull-request/31137/ 💛

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 1, 2020
@tniessen tniessen mentioned this pull request May 4, 2020
Closed
4 tasks
@tniessen
Copy link
Member

tniessen commented May 4, 2020

I didn't see this PR (or the issue) before opening #33235. Please consider it as an alternative:

  • Personally, I think a non-recoverable error (at least not recoverable from WASM) is more appropriate in case a WASI module was not started properly. With this PR, it is up to the WASM module to handle the error code EINVAL, even though the WASM module likely isn't at fault.
  • This PR doesn't prevent calling syscalls that don't access memory.

@cjihrig
Copy link
Contributor Author

cjihrig commented May 4, 2020

I'm good with the approach in #33235. I'll close this.

@cjihrig cjihrig closed this May 4, 2020
@cjihrig cjihrig deleted the wasi-start branch May 4, 2020 16:58
@gengjiawen gengjiawen mentioned this pull request Sep 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@santigimeno santigimeno santigimeno approved these changes

@devnexen devnexen devnexen approved these changes

@devsnek devsnek devsnek approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. wasi Issues and PRs related to the WebAssembly System Interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Segfault on combo of global ctors, ostream, wasi
9 participants
@cjihrig @nodejs-github-bot @tniessen @jasnell @addaleax @santigimeno @devnexen @devsnek @juanarbol