Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasi: avoid hard crash if start() is never called #33184

Closed
wants to merge 1 commit into from
Closed

wasi: avoid hard crash if start() is never called #33184

wants to merge 1 commit into from

Commits on May 1, 2020

  1. wasi: avoid hard crash if start() is never called 

    Prior to this commit, calling the WebAssembly instance's _start()
export directly would hard crash the process because the memory
was never configured. This commit adds an additional check that
the memory is usable. With this commit, calling _start() directly
will still lead to WASI exiting with a non-zero exit code, but
Node does not crash.
    @cjihrig
    cjihrig committed May 1, 2020
    Copy the full SHA
    7c2870d View commit details
    Browse the repository at this point in the history