Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix grammar in buffer.md #33194

Closed
wants to merge 2 commits into from
Closed

doc: fix grammar in buffer.md #33194

wants to merge 2 commits into from

Conversation

seishun
Copy link
Contributor

@seishun seishun commented May 1, 2020

I don't like repeating the TypeError note under each Buffer.from variant. I think it should be mentioned once (if at all), but I can't think of a good place for it. Thoughts?

Checklist

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels May 1, 2020
Copy link
Member

@rexagod rexagod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BridgeAR BridgeAR requested a review from Trott May 3, 2020 15:48
@BridgeAR
Copy link
Member

BridgeAR commented May 3, 2020

@nodejs/documentation PTAL

@Trott
Copy link
Member

Trott commented May 4, 2020

Landed in c17dcb3

@Trott Trott closed this May 4, 2020
Trott pushed a commit that referenced this pull request May 4, 2020
PR-URL: #33194
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@seishun seishun deleted the fix-buffer-doc branch May 5, 2020 10:31
@seishun
Copy link
Contributor Author

seishun commented May 5, 2020

@Trott thanks for landing, but you misspelled grammar in the commit message :(

codebytere pushed a commit that referenced this pull request May 7, 2020
PR-URL: #33194
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request May 18, 2020
codebytere pushed a commit that referenced this pull request Jun 7, 2020
PR-URL: #33194
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants