perf_hooks: fix error message for invalid entryTypes #33285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will now print a more meaningful value instead of always [object Object]
nodejs-github-bot
added
the
perf_hooks
targos
commented
May 7, 2020
| @@ -341,19 +341,20 @@ class PerformanceObserver extends AsyncResource { | |||
| if (typeof options !== 'object' || options === null) { | |||
| throw new ERR_INVALID_ARG_TYPE('options', 'Object', options); | |||
| } | |||
| if (!ArrayIsArray(options.entryTypes)) { | |||
| throw new ERR_INVALID_OPT_VALUE('entryTypes', options); | |||
| const { entryTypes } = options; | |||
There was a problem hiding this comment.
this is to prevent accessing the value more than once (it could be a getter that doesn't always return the same thing)
jasnell
approved these changes
May 7, 2020
|
CI: https://ci.nodejs.org/job/node-test-pull-request/31212/ (:yellow_heart:) |
cjihrig
approved these changes
May 7, 2020
addaleax
approved these changes
May 7, 2020
legendecas
approved these changes
May 8, 2020
lpinca
approved these changes
May 8, 2020
targos
added a commit
that referenced
this pull request
May 10, 2020
Will now print a more meaningful value instead of always [object Object] PR-URL: #33285 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 1182539 |
codebytere
pushed a commit
that referenced
this pull request
May 11, 2020
Will now print a more meaningful value instead of always [object Object] PR-URL: #33285 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
Will now print a more meaningful value instead of always [object Object] PR-URL: #33285 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will now print a more meaningful value instead of always "[object Object]".