src: add primordials to arguments comment #33318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the primordials argument to the comment of arguments passed to bootstrap/node.js.
addaleax
approved these changes
May 9, 2020
cjihrig
approved these changes
May 9, 2020
BridgeAR
approved these changes
May 9, 2020
BridgeAR
added
the
author ready
trivikr
approved these changes
May 11, 2020
himself65
approved these changes
May 11, 2020
danbev
removed
the
author ready
danbev
added a commit
that referenced
this pull request
May 13, 2020
This commit adds the primordials argument to the comment of arguments passed to bootstrap/node.js. PR-URL: #33318 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
|
Landed in e1b90be. |
codebytere
pushed a commit
that referenced
this pull request
May 16, 2020
This commit adds the primordials argument to the comment of arguments passed to bootstrap/node.js. PR-URL: #33318 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
This commit adds the primordials argument to the comment of arguments passed to bootstrap/node.js. PR-URL: #33318 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
primordialsargument to the comment of argumentspassed to bootstrap/node.js.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes