Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: enable --error-on-warn for POSIX workflows #33357

Merged
merged 2 commits into from May 13, 2020
Merged

build: enable --error-on-warn for POSIX workflows #33357

merged 2 commits into from May 13, 2020

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented May 11, 2020 •
edited

Treat warnings as errors for non-deps code on Linux and macOS workflows.

Refs: #32685

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 11, 2020
@richardlau richardlau added the build Issues and PRs related to build files or the CI. label May 11, 2020
mhdawson
mhdawson approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 11, 2020
@richardlau
Copy link
Member Author

It looks like this hasn't failed on macOS for #33358. Seems like the -Werror flag hasn't made it onto the command line on macOS:

  c++ -o /Users/runner/runners/2.169.1/work/node/node/out/Release/obj.target/libnode/src/large_pages/node_large_page.o ../src/large_pages/node_large_page.cc '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_DARWIN_USE_64_BIT_INODE=1' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DNODE_ARCH="x64"' '-DNODE_WANT_INTERNALS=1' '-DV8_DEPRECATION_WARNINGS=1' '-DNODE_OPENSSL_SYSTEM_CERT_PATH=""' '-DHAVE_INSPECTOR=1' '-DHAVE_DTRACE=1' '-DNODE_ENABLE_LARGE_CODE_PAGES=1' '-D__POSIX__' '-DNODE_USE_V8_PLATFORM=1' '-DNODE_HAVE_I18N_SUPPORT=1' '-DNODE_PLATFORM="darwin"' '-DHAVE_OPENSSL=1' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-DNGHTTP2_STATICLIB' -I../src -I/Users/runner/runners/2.169.1/work/node/node/out/Release/obj/gen -I/Users/runner/runners/2.169.1/work/node/node/out/Release/obj/gen/include -I/Users/runner/runners/2.169.1/work/node/node/out/Release/obj/gen/src -I../deps/histogram/src -I../deps/uvwasi/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common -I../deps/zlib -I../deps/llhttp/include -I../deps/cares/include -I../deps/uv/include -I../deps/nghttp2/lib/includes -I../deps/brotli/c/include -I../deps/openssl/openssl/include  -O3 -gdwarf-2 -mmacosx-version-min=10.13 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -Werror=undefined-inline -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /Users/runner/runners/2.169.1/work/node/node/out/Release/.deps//Users/runner/runners/2.169.1/work/node/node/out/Release/obj.target/libnode/src/large_pages/node_large_page.o.d.raw   -c
...
../src/large_pages/node_large_page.cc:241:14: warning: unused variable 'esize' [-Wunused-variable]
      size_t esize = end - start;
             ^

@richardlau
Copy link
Member Author

richardlau commented May 11, 2020 •
edited

Pushed a commit to (hopefully 🤞) fix --error-on-warn on macOS.

Edit: https://github.com/nodejs/node/pull/33357/checks?check_run_id=664422885 fails as expected.

@richardlau richardlau added the blocked PRs that are blocked by other issues or PRs. label May 11, 2020
@richardlau
Copy link
Member Author

#33358 needs to land before this one otherwise the macOS workflow will start failing.

@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels May 12, 2020
@richardlau
build: fix --error-on-warn for macOS
3aa5152 
XCode builds on macOS do not appear to inherit the `cflags` setting.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: nodejs#33357
Refs: nodejs#32685
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@richardlau
build: enable --error-on-warn for POSIX workflows
fcc183c 
Treat warnings as errors for non-deps code on Linux and macOS workflows.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: nodejs#33357
Refs: nodejs#32685
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@richardlau
Copy link
Member Author

Landed in 365ddb3...fcc183c

@richardlau richardlau merged commit fcc183c into nodejs:master May 13, 2020
@richardlau richardlau mentioned this pull request May 13, 2020
Closed
codebytere pushed a commit that referenced this pull request May 16, 2020
@richardlau @codebytere
build: fix --error-on-warn for macOS
7d4db35 
XCode builds on macOS do not appear to inherit the `cflags` setting.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #33357
Refs: #32685
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
codebytere pushed a commit that referenced this pull request May 16, 2020
@richardlau @codebytere
build: enable --error-on-warn for POSIX workflows
34e7400 
Treat warnings as errors for non-deps code on Linux and macOS workflows.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #33357
Refs: #32685
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@richardlau @codebytere
build: enable --error-on-warn for POSIX workflows
1a154d1 
Treat warnings as errors for non-deps code on Linux and macOS workflows.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #33357
Refs: #32685
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targos targos mentioned this pull request May 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@richardlau @addaleax @targos @cjihrig @gengjiawen @BridgeAR @mhdawson @codebytere @nodejs-github-bot