Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove deprecated FinalizationRegistry hooks #33373

Merged
merged 1 commit into from
May 14, 2020
Merged

src: remove deprecated FinalizationRegistry hooks #33373

merged 1 commit into from
May 14, 2020

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented May 12, 2020 •
edited

Fixes: #33389

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

cc @syg

@devsnek devsnek requested a review from addaleax May 12, 2020 18:27
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels May 12, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31297/

@targos targos mentioned this pull request May 13, 2020
Closed
@targos targos mentioned this pull request May 13, 2020
Closed
@devsnek devsnek mentioned this pull request May 13, 2020
Closed
@targos
Copy link
Member

targos commented May 13, 2020

fast-track to fix #33389?

@targos targos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels May 13, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31310/

@devsnek
src: remove deprecated FinalizationRegistry hooks
eaa16cd 
PR-URL: nodejs#33373
Fixes: nodejs#33389
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@devsnek devsnek merged commit eaa16cd into nodejs:master May 14, 2020
@devsnek
Copy link
Member Author

devsnek commented May 14, 2020

Landed in eaa16cd

@devsnek devsnek deleted the nofg branch May 14, 2020 20:10
codebytere pushed a commit that referenced this pull request May 16, 2020
@devsnek @codebytere
src: remove deprecated FinalizationRegistry hooks
0257386 
PR-URL: #33373
Fixes: #33389
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New build warnings
7 participants
@devsnek @nodejs-github-bot @targos @danbev @addaleax @richardlau @BridgeAR