Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: replace to CHECK_NOT_NULL in node_crypto #33383

Closed
wants to merge 1 commit into from
Closed

src: replace to CHECK_NOT_NULL in node_crypto #33383

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels May 13, 2020
@addaleax
Copy link
Member

LGTM but this might conflict with #33360 and it probably makes more sense to apply this on top of the latter?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31306/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 14, 2020 •
edited by himself65

CI: https://ci.nodejs.org/job/node-test-pull-request/31320/ (✔)

@himself65 himself65 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 15, 2020
addaleax pushed a commit that referenced this pull request May 15, 2020
@himself65 @addaleax
src: replace to CHECK_NOT_NULL in node_crypto
21b5c5f 
PR-URL: #33383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@addaleax
Copy link
Member

Landed in 21b5c5f

@addaleax addaleax closed this May 15, 2020
codebytere pushed a commit that referenced this pull request May 16, 2020
@himself65 @codebytere
src: replace to CHECK_NOT_NULL in node_crypto
8ada953 
PR-URL: #33383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@himself65 @codebytere
src: replace to CHECK_NOT_NULL in node_crypto
1ca6f28 
PR-URL: #33383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 9, 2020
@himself65 @codebytere
src: replace to CHECK_NOT_NULL in node_crypto
a0bc2e3 
PR-URL: #33383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@shisama shisama shisama approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@himself65 @addaleax @nodejs-github-bot @cjihrig @richardlau @shisama @juanarbol