Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs, errors, http, tests: fixed socket.setEncoding fatal error #33405

Closed
wants to merge 1 commit into from
Closed

docs, errors, http, tests: fixed socket.setEncoding fatal error #33405

wants to merge 1 commit into from

Commits on May 14, 2020

  1. docs, errors, http, tests: fixed socket.setEncoding fatal error 

    applied updates from previous pull-requests to disallow
socket.setEncoding before a http connection is parsed.
wrapped socket.setEncoding to throw an error.
previously resulted in a fatal error

Fixes: nodejs#18118
Ref: nodejs#18178
Ref: nodejs#19344
    @iSkore
    iSkore committed May 14, 2020
    Copy the full SHA
    f62bacd View commit details
    Browse the repository at this point in the history