Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 8.5 #34337

Closed
wants to merge 28 commits into from
Closed

deps: update V8 to 8.5 #34337

wants to merge 28 commits into from

Commits on Sep 7, 2020

  1. deps: update V8 to 8.5.210

    targos committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    ce1823e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a8633d2 View commit details
    Browse the repository at this point in the history
  3. src: update NODE_MODULE_VERSION to 88

    Major V8 updates are usually API/ABI incompatible with previous
    versions. This commit adapts NODE_MODULE_VERSION for V8 8.5.
    
    Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
    targos committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    54c70a4 View commit details
    Browse the repository at this point in the history
  4. deps: V8: un-cherry-pick bd019bd

    Original commit message:
    
        [testrunner] delete ancient junit compatible format support
    
        Testrunner has ancient support for JUnit compatible XML output.
    
        This CL removes this old feature.
    
        R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
        CC=​machenbach@chromium.org
    
        Bug: v8:8728
        Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
        Reviewed-on: https://chromium-review.googlesource.com/c/1430065
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
        Commit-Queue: Tamer Tas <tmrts@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#59045}
    
    Refs: v8/v8@bd019bd
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and targos committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    bb7db67 View commit details
    Browse the repository at this point in the history
  5. deps: patch V8 to run on older XCode versions

    Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional
    property, which is a fairly new C++ feature, since that requires a newer
    XCode version than the minimum requirement in BUILDING.md and thus
    breaks CI.
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ryzokuken authored and targos committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    85cc8e0 View commit details
    Browse the repository at this point in the history
  6. deps: V8: patch register-arm64.h

    Fixes a compilation issue on some platforms
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and targos committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    c07a11a View commit details
    Browse the repository at this point in the history
  7. deps: V8: forward declaration of Rtl*FunctionTable

    This should be semver-patch since actual invocation is version
    conditional.
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and targos committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    f16624d View commit details
    Browse the repository at this point in the history
  8. deps: make v8.h compatible with VS2015

    There is a bug in the most recent version of VS2015 that affects v8.h
    and therefore prevents compilation of addons.
    
    Refs: https://stackoverflow.com/q/38378693
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    joaocgreis authored and targos committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    3d310d0 View commit details
    Browse the repository at this point in the history
  9. deps: V8: silence irrelevant warnings

    PR-URL: nodejs#26685
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    
    PR-URL: nodejs#32116
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    targos committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    75ff275 View commit details
    Browse the repository at this point in the history
  10. deps: patch V8 to run on Xcode 8

    Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type
    passed to template call of `OwnedVector::Of`. Xcode 8 can't convert
    'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when
    returning from a function (which is likely a bug on Xcode, considering
    this worked on the prior version of Xcode as well as newer versions).
    This workaround shouldn't affect the application, since the const
    qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_.
    
    There's also a V8 test passing a const-qualified type to ::Of, but since
    we don't test V8 on Xcode 8, it should be fine to leave it as is.
    
    Signed-off-by: Matheus Marchini <mmarchini@netflix.com>
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    mmarchini authored and targos committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    cbc39a6 View commit details
    Browse the repository at this point in the history
  11. deps: update V8 postmortem metadata script

    This commit updates V8's gen-postmortem-metadata.py script
    to fix SmartOS compilation for V8 8.4.
    
    PR-URL: nodejs#33579
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    cjihrig authored and targos committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    b0e014b View commit details
    Browse the repository at this point in the history
  12. deps: V8: cherry-pick 2d5017a0fc02

    Original commit message:
    
        [coverage] remove the last continuation range before synthetic return
    
        Rather than only removing the continuation range for the last return
        statement prior to a synthetic return statement, remove the
        continuation tracking for whatever statement occurs prior to the
        synthetic return.
    
        Bug: v8:10628
        Change-Id: Ieb8e393479c9811cf1b9756840bbfdbe7f44a1b8
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280585
        Commit-Queue: Benjamin Coe <bencoe@google.com>
        Reviewed-by: Toon Verwaest <verwaest@chromium.org>
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#68719}
    
    Refs: v8/v8@2d5017a
    targos committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    9c0fc5b View commit details
    Browse the repository at this point in the history
  13. deps: V8: cherry-pick 4ece1067855b

    Original commit message:
    
        cppgc: fix wrong header name
    
        Change-Id: I9ad6402561f06b4c2069c08f452e52a4d6b533eb
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270402
        Reviewed-by: Anton Bikineev <bikineev@chromium.org>
        Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#68584}
    
    Refs: v8/v8@4ece106
    targos committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    ed14532 View commit details
    Browse the repository at this point in the history
  14. deps: V8: cherry-pick e06ace6b5cdb

    Original commit message:
    
        [api] Fix empty Maybe crash in GetRealNamedPropertyAttributes
    
        `Object::GetRealNamedPropertyAttributes()` can crash if an empty
        `Maybe` is returned by `JSReceiver::GetPropertyAttributes()` because
        it was not checking for that. Fix that.
    
        Refs: nodejs#34606
        Change-Id: Ic83f904ba7134786bcd8f786eb2ce98adb4fea1e
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335057
        Commit-Queue: Leszek Swirski <leszeks@chromium.org>
        Reviewed-by: Leszek Swirski <leszeks@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#69258}
    
    Refs: v8/v8@e06ace6
    
    PR-URL: nodejs#34673
    Fixes: nodejs#34606
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and targos committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    148a8fb View commit details
    Browse the repository at this point in the history
  15. deps: V8: backport 3f071e3e7e15

    Original commit message:
    
        PPC: Optimize clearing higher bits of mulhw/mulhwu
    
        Change-Id: Ie3e14a6ef4531349e81a8ae741bc7470c7e547ca
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349468
        Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
        Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
        Cr-Commit-Position: refs/heads/master@{#69343}
    
    Refs: v8/v8@3f071e3
    
    PR-URL: nodejs#35036
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Milad Farazmand authored and targos committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    65f6fa7 View commit details
    Browse the repository at this point in the history
  16. deps: V8: cherry-pick 6be2f6e26e8d

    Original commit message:
    
        [coverage] IncBlockCounter should not be side-effect
    
        Incrementing coverage counter was triggering EvalError for
        evaluateOnCallFrame when throwOnSideEffect is true.
    
        R=jgruber@chromium.org, sigurds@chromium.org, yangguo@chromium.org
    
        Bug: v8:10856
        Change-Id: I0552e19a3a14ff61a9cb626494fb4a21979d535e
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2384011
        Commit-Queue: Benjamin Coe <bencoe@google.com>
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Yang Guo <yangguo@chromium.org>
        Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#69628}
    
    Refs: v8/v8@6be2f6e
    
    PR-URL: nodejs#35055
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    bcoe authored and targos committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    9f6c30e View commit details
    Browse the repository at this point in the history
  17. deps: V8: cherry-pick e996b743171f

    Original commit message:
    
        cppgc: Make RawHeap noncopyable
    
        This is an attempt to fix a build failure in MSVC14.26.28801.
    
        Bug: v8:10691
        Change-Id: Ic4b994b14e1ac70ab95f3da53bd7be382e38a4b8
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2300540
        Reviewed-by: Omer Katz <omerkatz@chromium.org>
        Commit-Queue: Anton Bikineev <bikineev@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#68884}
    
    Refs: v8/v8@e996b74
    targos committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    d7d6ad4 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. deps: V8: update postmortem metadata script

    This commit updates V8's gen-postmortem-metadata.py script to
    fix SmartOS compilation with V8 8.5.
    cjihrig authored and targos committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    7fe7b90 View commit details
    Browse the repository at this point in the history
  2. tools: update V8 gypfiles for 8.5

    ryzokuken authored and targos committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    f84fa05 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2f9d8a3 View commit details
    Browse the repository at this point in the history
  4. wasi: drop --experimental-wasm-bigint requirement

    After the V8 8.5 update, the WASI APIs no longer require the
    use of --experimental-wasm-bigint. This commit removes its use.
    cjihrig authored and targos committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    7e3a2e4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4f0d08c View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. testing arm64 gyp fix

    targos committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    e0558cf View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2020

  1. tools: use v8_current_cpu

    targos committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    e7e06e8 View commit details
    Browse the repository at this point in the history
  2. ugly try

    targos committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    915dad1 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2020

  1. add log

    targos committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    fceae5a View commit details
    Browse the repository at this point in the history
  2. last try

    targos committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    e390638 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. try fix

    targos committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    d0d56fb View commit details
    Browse the repository at this point in the history