deps: update V8 to 8.5 #34337

targos · 2020-07-13T13:41:02Z

Stable Release: Tue, Aug 25, 2020

nodejs-github-bot · 2020-07-13T13:41:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32312/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3241/

targos · 2020-07-13T14:20:31Z

/cc @gengjiawen related to nodejs/node-v8#161

gengjiawen · 2020-07-13T14:32:12Z

/cc @gengjiawen related to nodejs/node-v8#161

Yeap. Also msvc only report one error, I will give it a try.

BTW, we need to cherrypick v8/v8@4ece106.

cjihrig · 2020-07-23T00:10:26Z

@targos, since --experimental-wasm-bigint is no longer required for the WASI API, would you like to pull cjihrig@dbff5bc into this upgrade, or would you prefer me to PR it separately after the upgrade lands?

gengjiawen · 2020-08-23T15:57:52Z

In case you want patch code for windows, you can get first two commit in https://github.com/gengjiawen/node/commits/v8-8.5-hack before nodejs/gyp-next#60 get fixed. @targos

bricss · 2020-09-04T23:09:07Z

Is there any chance that it may get into Node 14 or 15? 😶

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.5. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59045} Refs: v8/v8@bd019bd PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional property, which is a fairly new C++ feature, since that requires a newer XCode version than the minimum requirement in BUILDING.md and thus breaks CI. PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Fixes a compilation issue on some platforms PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos · 2020-09-26T09:35:13Z

Testing something: https://ci.nodejs.org/job/node-test-commit-arm-fanned/16538/

gengjiawen · 2020-09-26T15:42:00Z

@targos I believe I have find the root cause through the generated mk file. It looks like the assembly file processed both on host and target. So we should limit it only on target (<(V8_ROOT)/src/heap/base/asm/arm/push_registers_asm.cc are valid assembly only for arm, that's why gcc failed on v8_base_without_compiler.host.mk) .

Below is build by removing it in v8_base_without_compiler.host.mk file manully.

Maybe only something like (not quite sure about the syntax)

              ['_toolset == "target" and v8_current_cpu=="arm"', {
                'sources': [
                  '<(V8_ROOT)/src/heap/base/asm/arm/push_registers_asm.cc'
                ],
              }],

targos · 2020-09-27T08:48:10Z

I don't know... My condition seems right. I looked at the Jenkins logs and for cross-compiler-ubuntu1804-armv7-gcc-6, host_arch is ia32 and target_arch is arm, so unless I'm missing something with priority of operators in Python, it should pick up the ia32 file.

targos · 2020-09-27T09:06:12Z

So, with the log I added, we can see that the variables have the following values:

'host_arch': 'ia32'
'target_arch': 'arm'
'_toolset': 'target'

There's no other log where _toolset is host 🤔. I'm trying one last thing.

CI: https://ci.nodejs.org/job/node-test-commit-arm-fanned/16551/

Edit: doesn't work. I'm out of ideas.

mmarchini · 2020-09-27T09:11:16Z

@targos if you want to test locally, you can also try https://github.com/mmarchini/node-arm-cross-builder

mmarchini · 2020-09-27T09:13:44Z

_toolset being always target seems like either a bug, or we're using the wrong variable to test the current toolset.

gengjiawen · 2020-09-27T14:12:58Z

_toolset being always target seems like either a bug, or we're using the wrong variable to test the current toolset.

_toolset seems to be 'target' all the time from what I test. Maybe a bug in gyp.

Looks the generated mk file toolset is set correctly. Where _toolset is set in gyp ?

  1 # This file is generated by gyp; do not edit.
  2 
  3 TOOLSET := host
  4 TARGET := v8_base_without_compiler

sxa · 2020-09-29T11:32:10Z

I realise I'm somewhat "drive-by commenting" here, but is there a reason why we still have to cross compile for arm32? There's some reasonably quick stuff out there now (e.g. Raspberry Pi4 or ODROID-XU4 which I use) and if those could be used to build natively in a reasonable amount of time and don't exhibit the same problems it might be worth switching.

gengjiawen · 2020-09-29T11:34:52Z

So, with the log I added, we can see that the variables have the following values:

'host_arch': 'ia32'

'target_arch': 'arm'

'_toolset': 'target'

There's no other log where _toolset is host 🤔. I'm trying one last thing.

CI: ci.nodejs.org/job/node-test-commit-arm-fanned/16551

Edit: doesn't work. I'm out of ideas.

Tinker v8.gyp like will have '_toolset': 'host' in the log, but I still get v8_base_without_compiler.host.mk have $(obj).host/$(TARGET)/deps/v8/src/heap/base/asm/ia32/push_registers_asm.o, not sure why.

    {
      'target_name': 'v8_cppgc_shared',
      'type': 'none',
      # 'conditions': [
      #   ['want_separate_host_toolset', {
      #     'toolsets': ['host', 'target'],
      #   }],
      # ],
      'toolsets': ['host', 'target']

gengjiawen · 2020-09-29T11:36:13Z

@sxa It's already tier 1 in build. I suppose even if we want to change it. It will be a much more bigger issue.

Context: nodejs/TSC#931 (comment).

sxa · 2020-09-29T11:39:35Z

For completeness, link to a proposed switch to building natively that went stale nodejs/build#1851

gengjiawen · 2020-09-29T11:55:40Z

@targos I think I find the fix, not sure the reason why. I tested in the docker, works fine, you can test it in Jenkins.

Change the part like this

    {
      'target_name': 'v8_cppgc_shared',
      'type': 'none',
      # 'conditions': [
      #   ['want_separate_host_toolset', {
      #     'toolsets': ['host', 'target'],
      #   }],
      # ],
      'toolsets': ['host', 'target'],
      'direct_dependent_settings': {
        'sources': [
          '<(V8_ROOT)/src/heap/base/stack.cc',
          '<(V8_ROOT)/src/heap/base/stack.h',
        ],
        'conditions': [
          ['clang or OS!="win"', {
            'conditions': [
              ['_toolset=="target" and target_arch == "arm"', {
                'sources': [
                  '<(V8_ROOT)/src/heap/base/asm/arm/push_registers_asm.cc',
                ],
              }],
              ['_toolset == "target" and target_arch=="arm64"', {
                'sources': [
                  '<(V8_ROOT)/src/heap/base/asm/arm64/push_registers_asm.cc',
                ],
              }],
            ]
          // other omitted.

targos · 2020-09-29T12:00:30Z

@gengjiawen with the change you propose, does it still work for regular compilation, for example x64?

gengjiawen · 2020-09-29T12:03:24Z

@gengjiawen with the change you propose, does it still work for regular compilation, for example x64?

Not test it yet, give me a second.

gengjiawen · 2020-09-29T12:11:22Z

@gengjiawen with the change you propose, does it still work for regular compilation, for example x64?

@targos Looks like still works (Note: in my snippet I only show two cpus).

PS: the full build without ccache is really long.

targos · 2020-09-29T12:35:02Z

Let's try it!

nodejs-github-bot · 2020-09-29T12:35:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33285/

targos · 2020-09-29T13:41:19Z

It works!!! Thank you @gengjiawen ❤️ . Now I'm going to open a new PR to update directly to 8.6, because it will be stable next week and we need it ASAP for v15.

gengjiawen · 2020-09-29T15:10:33Z

It works!!! Thank you @gengjiawen ❤️ . Now I'm going to open a new PR to update directly to 8.6, because it will be stable next week and we need it ASAP for v15.

You want to land this first or drop it ?

targos · 2020-09-29T15:22:11Z

It's easier for me to drop it.

targos · 2020-09-29T15:25:21Z

PR for 8.6: #35415

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 13, 2020

nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Jul 13, 2020

targos marked this pull request as draft July 13, 2020 13:41

This was referenced Jul 14, 2020

CI Relability 2020-07-14 JaneaSystems/nodejs-reliability#37

Open

CI Relability 2020-07-15 JaneaSystems/nodejs-reliability#38

Open

CI Relability 2020-07-16 JaneaSystems/nodejs-reliability#39

Open

targos mentioned this pull request Jul 16, 2020

Node.js Technical Steering Committee (TSC) Meeting 2020-07-16 nodejs/TSC#893

Closed

This was referenced Jul 17, 2020

CI Relability 2020-07-17 JaneaSystems/nodejs-reliability#40

Open

CI Relability 2020-07-18 JaneaSystems/nodejs-reliability#41

Open

CI Relability 2020-07-19 JaneaSystems/nodejs-reliability#42

Open

CI Relability 2020-07-20 JaneaSystems/nodejs-reliability#43

Open

evanlucas mentioned this pull request Aug 4, 2020

Add initial support for Darwin arm64 #34238

Merged

7 tasks

mmarchini mentioned this pull request Aug 6, 2020

V8 update script broken nodejs/node-v8#166

Closed

Tarnadas mentioned this pull request Aug 10, 2020

Externref/Reference types throwing error in Node rustwasm/wasm-bindgen#2274

Closed

targos force-pushed the v8-85 branch from 428ca3a to 339c5a3 Compare August 18, 2020 13:29

bricss mentioned this pull request Sep 2, 2020

2020-10-20, Version 15.0.0 (Current) #35014

Merged

gengjiawen mentioned this pull request Sep 4, 2020

Implement Promise.any #35045

Closed

targos and others added 6 commits September 7, 2020 09:32

deps: update V8 to 8.5.210

ce1823e

build: reset embedder string to "-node.0"

a8633d2

src: update NODE_MODULE_VERSION to 88

54c70a4

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.5. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

deps: V8: patch register-arm64.h

c07a11a

Fixes a compilation issue on some platforms PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

ugly try

915dad1

targos added 2 commits September 27, 2020 10:55

add log

fceae5a

last try

e390638

This comment has been minimized.

Sign in to view

try fix

d0d56fb

This comment has been minimized.

Sign in to view

targos closed this Sep 29, 2020

targos deleted the v8-85 branch October 18, 2020 18:20

gengjiawen mentioned this pull request Jan 14, 2021

[V8] bring msvc build to upstream v8 #36906

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update V8 to 8.5 #34337

deps: update V8 to 8.5 #34337

targos commented Jul 13, 2020

nodejs-github-bot commented Jul 13, 2020 •

edited by targos

targos commented Jul 13, 2020

gengjiawen commented Jul 13, 2020

cjihrig commented Jul 23, 2020 •

edited

gengjiawen commented Aug 23, 2020 •

edited

bricss commented Sep 4, 2020

targos commented Sep 26, 2020

gengjiawen commented Sep 26, 2020 •

edited

targos commented Sep 27, 2020 •

edited

targos commented Sep 27, 2020 •

edited

mmarchini commented Sep 27, 2020

mmarchini commented Sep 27, 2020

gengjiawen commented Sep 27, 2020 •

edited

This comment has been minimized.

sxa commented Sep 29, 2020

gengjiawen commented Sep 29, 2020 •

edited

gengjiawen commented Sep 29, 2020 •

edited

sxa commented Sep 29, 2020

gengjiawen commented Sep 29, 2020 •

edited

targos commented Sep 29, 2020

gengjiawen commented Sep 29, 2020

gengjiawen commented Sep 29, 2020 •

edited

targos commented Sep 29, 2020

nodejs-github-bot commented Sep 29, 2020

This comment has been minimized.

targos commented Sep 29, 2020

gengjiawen commented Sep 29, 2020

targos commented Sep 29, 2020

targos commented Sep 29, 2020

deps: update V8 to 8.5 #34337

deps: update V8 to 8.5 #34337

Conversation

targos commented Jul 13, 2020

nodejs-github-bot commented Jul 13, 2020 • edited by targos

targos commented Jul 13, 2020

gengjiawen commented Jul 13, 2020

cjihrig commented Jul 23, 2020 • edited

gengjiawen commented Aug 23, 2020 • edited

bricss commented Sep 4, 2020

targos commented Sep 26, 2020

gengjiawen commented Sep 26, 2020 • edited

targos commented Sep 27, 2020 • edited

targos commented Sep 27, 2020 • edited

mmarchini commented Sep 27, 2020

mmarchini commented Sep 27, 2020

gengjiawen commented Sep 27, 2020 • edited

This comment has been minimized.

sxa commented Sep 29, 2020

gengjiawen commented Sep 29, 2020 • edited

gengjiawen commented Sep 29, 2020 • edited

sxa commented Sep 29, 2020

gengjiawen commented Sep 29, 2020 • edited

targos commented Sep 29, 2020

gengjiawen commented Sep 29, 2020

gengjiawen commented Sep 29, 2020 • edited

targos commented Sep 29, 2020

nodejs-github-bot commented Sep 29, 2020

This comment has been minimized.

targos commented Sep 29, 2020

gengjiawen commented Sep 29, 2020

targos commented Sep 29, 2020

targos commented Sep 29, 2020

nodejs-github-bot commented Jul 13, 2020 •

edited by targos

cjihrig commented Jul 23, 2020 •

edited

gengjiawen commented Aug 23, 2020 •

edited

gengjiawen commented Sep 26, 2020 •

edited

targos commented Sep 27, 2020 •

edited

targos commented Sep 27, 2020 •

edited

gengjiawen commented Sep 27, 2020 •

edited

gengjiawen commented Sep 29, 2020 •

edited

gengjiawen commented Sep 29, 2020 •

edited

gengjiawen commented Sep 29, 2020 •

edited

gengjiawen commented Sep 29, 2020 •

edited