Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "src: simplify format in node_file.cc" #34463

Closed
wants to merge 1 commit into from
Closed

Revert "src: simplify format in node_file.cc" #34463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/node_file.cc
View file
Open in desktop
Expand Up @@ -488,9 +488,9 @@ int FileHandle::ReadStart() {

// Push the read wrap back to the freelist, or let it be destroyed
// once we’re exiting the current scope.
constexpr size_t kWantedFreelistFill = 100;
constexpr size_t wanted_freelist_fill = 100;
auto& freelist = handle->binding_data_->file_handle_read_wrap_freelist;
if (freelist.size() < kWantedFreelistFill) {
if (freelist.size() < wanted_freelist_fill) {
read_wrap->Reset();
freelist.emplace_back(std::move(read_wrap));
}
Expand Down Expand Up @@ -758,7 +758,7 @@ void AfterScanDir(uv_fs_t* req) {
int r;
std::vector<Local<Value>> name_v;

for (;;) {
for (int i = 0; ; i++) {
uv_dirent_t ent;

r = uv_fs_scandir_next(req, &ent);
Expand Down Expand Up @@ -799,7 +799,7 @@ void AfterScanDirWithTypes(uv_fs_t* req) {
std::vector<Local<Value>> name_v;
std::vector<Local<Value>> type_v;

for (;;) {
for (int i = 0; ; i++) {
uv_dirent_t ent;

r = uv_fs_scandir_next(req, &ent);
Expand Down