quic: refactor ocsp handling #34498
Closed
quic: refactor ocsp handling #34498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell
changed the title
|
Ping @nodejs/quic ... this is ready for review. Limited the PR to just the OCSP handling for now. Still working through the issues around client hello, SNI, and |
addaleax
approved these changes
Jul 27, 2020
| @@ -1858,7 +1858,6 @@ class QuicSession extends EventEmitter { | |||
|
|
|||
| if (!this[kHandshakePost]()) { | |||
| if (typeof state.handshakeCompletePromiseReject === 'function') { | |||
| // TODO(@jasnell): Proper error | |||
| state.handshakeCompletePromiseReject( | |||
| new ERR_OPERATION_FAILED('Handshake failed')); | |||
| } | |||
There was a problem hiding this comment.
Can I disagree about these TODOs being irrelevant now? ERR_OPERATION_FAILED is too generic imo, because an operation failing is just about the definition of an error :)
There was a problem hiding this comment.
I know we've had a conversation about this before when you mentioned that our errors are too specific in cases. Struggling to find the right balance. Do you have a more concrete suggestion?
jasnell
added
quic
|
Landed in 62198d2...1f94b89 |
jasnell
added a commit
that referenced
this pull request
Jul 27, 2020
PR-URL: #34498 Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
added a commit
that referenced
this pull request
Jul 27, 2020
PR-URL: #34498 Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
added a commit
that referenced
this pull request
Jul 27, 2020
PR-URL: #34498 Reviewed-By: Anna Henningsen <anna@addaleax.net>
3 tasks
This was referenced Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First two commits are cleanup.
Third commit refactors the OCSP handling, converting it from a callback-oriented event to a configuration-based async function, which makes a lot more sense given that it's only ever called once at a very specific point in the
QuicSessionlifecycle.Fourth commit removes the'clientHello'event. Use cases supporting the event are tenuous at best and do not justify the additional machinery necessary for it to work.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes