Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: refactor ocsp handling #34498

Closed
wants to merge 3 commits into from
Closed

quic: refactor ocsp handling #34498

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbe05bf
quic: remove extraneous unused debug property
jasnell Jul 23, 2020
8311f26
quic: remove no-longer relevant TODO statements
jasnell Jul 23, 2020
b3623ae
quic: refactor ocsp to use async function rather than event/callback
jasnell Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/internal/quic/core.js
View file
Open in desktop
Expand Up @@ -1858,7 +1858,6 @@ class QuicSession extends EventEmitter {

if (!this[kHandshakePost]()) {
if (typeof state.handshakeCompletePromiseReject === 'function') {
// TODO(@jasnell): Proper error
state.handshakeCompletePromiseReject(
new ERR_OPERATION_FAILED('Handshake failed'));
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I disagree about these TODOs being irrelevant now? ERR_OPERATION_FAILED is too generic imo, because an operation failing is just about the definition of an error :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we've had a conversation about this before when you mentioned that our errors are too specific in cases. Struggling to find the right balance. Do you have a more concrete suggestion?

Expand Down Expand Up @@ -2005,7 +2004,6 @@ class QuicSession extends EventEmitter {
state.closePromiseResolve();

if (typeof state.handshakeCompletePromiseReject === 'function') {
// TODO(@jasnell): Proper error
state.handshakeCompletePromiseReject(
new ERR_OPERATION_FAILED('Handshake failed'));
}
Expand Down