Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

querystring: manage percent character at unescape #35013

Merged
merged 1 commit into from Sep 4, 2020
Merged

querystring: manage percent character at unescape #35013

merged 1 commit into from Sep 4, 2020

Conversation

watilde
Copy link
Member

@watilde watilde commented Sep 1, 2020

Related: #33892
Fixes: #35012

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@watilde watilde added the querystring Issues and PRs related to the built-in querystring module. label Sep 1, 2020
@watilde watilde mentioned this pull request Sep 2, 2020
Closed
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32997/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33045/

@watilde @Trott
querystring: manage percent character at unescape
3b92521 
Related: nodejs#33892
Fixes: nodejs#35012

PR-URL: nodejs#35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Sep 4, 2020

Landed in 3b92521

@Trott Trott merged commit 3b92521 into nodejs:master Sep 4, 2020
@watilde watilde deleted the fixes-35012 branch September 4, 2020 03:58
@watilde
Copy link
Member Author

watilde commented Sep 4, 2020

Thank you

watilde added a commit to watilde/node that referenced this pull request Sep 4, 2020
@watilde
test: update WPT tests of URL for URLSearchParams parsing %
73eb5e1 
Related: web-platform-tests/wpt#24152
Related: nodejs#35013
Fixes: nodejs#33892
richardlau pushed a commit that referenced this pull request Sep 7, 2020
@watilde @richardlau
querystring: manage percent character at unescape
3367613 
Related: #33892
Fixes: #35012

PR-URL: #35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@richardlau richardlau mentioned this pull request Sep 7, 2020
Merged
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
@watilde @richardlau
querystring: manage percent character at unescape
1bf5d1a 
Related: #33892
Fixes: #35012

PR-URL: #35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@watilde watilde mentioned this pull request Sep 8, 2020
Closed
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@watilde @addaleax
querystring: manage percent character at unescape
bde9fb8 
Related: #33892
Fixes: #35012

PR-URL: #35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@watilde @addaleax
querystring: manage percent character at unescape
6ccacdf 
Related: #33892
Fixes: #35012

PR-URL: #35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@watilde @joesepi
querystring: manage percent character at unescape
5366a2c 
Related: nodejs#33892
Fixes: nodejs#35012

PR-URL: nodejs#35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@Leko Leko Leko approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@yashLadha yashLadha yashLadha approved these changes

@jasnell jasnell Awaiting requested review from jasnell

@lundibundi lundibundi Awaiting requested review from lundibundi

Assignees
No one assigned
Labels
querystring Issues and PRs related to the built-in querystring module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

querystring.unescape does not correctly unescape percent characters
6 participants
@watilde @nodejs-github-bot @Trott @Leko @joyeecheung @yashLadha