Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x] http: add maxTotalSockets to agent class #35396

Closed
wants to merge 2 commits into from
Closed

[v12.x] http: add maxTotalSockets to agent class #35396

wants to merge 2 commits into from

Conversation

rickyes
Copy link
Contributor

@rickyes rickyes commented Sep 28, 2020

Add maxTotalSockets to determine how many sockets an agent can open.
Unlike maxSockets, The maxTotalSockets does not count by per origin.

PR-URL: #33617
PR-URL: #34013
Fixes: #31942
Reviewed-By: @ronag
Reviewed-By: @mcollina
Reviewed-By: @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@rickyes
http: add maxTotalSockets to agent class
6933e00 
Add maxTotalSockets to determine how many sockets an agent can open.
Unlike maxSockets, The maxTotalSockets does not count by per origin.

PR-URL: nodejs#33617
Fixes: nodejs#31942
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rickyes
doc: Add maxTotalSockets option to agent constructor
0a507d1 
PR-URL: nodejs#34013
Refs: nodejs#33617
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rickyes rickyes requested a review from a team as a code owner September 28, 2020 12:57
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. v12.x labels Sep 28, 2020
@rickyes rickyes mentioned this pull request Sep 28, 2020
Closed
4 tasks
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2020
@rickyes rickyes mentioned this pull request Sep 28, 2020
Closed
2 tasks
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 28, 2020 •
edited by rickyes

CI: https://ci.nodejs.org/job/node-test-pull-request/33277/ ✅

@addaleax
Copy link
Member

Landed in b9d0f73...1a8669d

@addaleax addaleax closed this Sep 28, 2020
addaleax pushed a commit that referenced this pull request Sep 28, 2020
@rickyes @addaleax
http: add maxTotalSockets to agent class
3d1bdc2 
Add maxTotalSockets to determine how many sockets an agent can open.
Unlike maxSockets, The maxTotalSockets does not count by per origin.

PR-URL: #33617
Backport-PR-URL: #35396
Fixes: #31942
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 28, 2020
@rickyes @addaleax
doc: Add maxTotalSockets option to agent constructor
1a8669d 
PR-URL: #34013
Backport-PR-URL: #35396
Refs: #33617
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #33617
Fixes: #31942
@rickyes rickyes deleted the backport-maxTotalSockets-to-v12.x branch September 29, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rickyes @nodejs-github-bot @addaleax