Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: make eventTarget.removeAllListeners() return this #35805

Closed
wants to merge 1 commit into from
Closed

events: make eventTarget.removeAllListeners() return this #35805

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Oct 26, 2020

Fixes: #35762

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

targos
targos reviewed Oct 26, 2020
View reviewed changes
test/parallel/test-nodeeventtarget.js Outdated Show resolved Hide resolved
test/parallel/test-nodeeventtarget.js Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 26, 2020 •
edited

Codecov Report

Merging #35805 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #35805   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files         477      477           
  Lines      113172   113174    +2     
  Branches    25425    25426    +1     
=======================================
+ Hits        99480    99486    +6     
+ Misses       7992     7988    -4     
  Partials     5700     5700
Impacted Files Coverage Δ
lib/internal/event_target.js 96.88% <100.00%> (+0.01%) ⬆️
src/node_api.cc 69.64% <0.00%> (-0.56%) ⬇️
src/api/environment.cc 75.60% <0.00%> (-0.28%) ⬇️
lib/internal/main/worker_thread.js 95.65% <0.00%> (ø)
lib/_http_server.js 97.83% <0.00%> (+0.20%) ⬆️
lib/internal/child_process.js 94.91% <0.00%> (+0.27%) ⬆️
src/node_http_parser.cc 81.19% <0.00%> (+0.44%) ⬆️
src/memory_tracker-inl.h 69.62% <0.00%> (+0.74%) ⬆️

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33898/

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 28, 2020
@lpinca @Trott
events: make eventTarget.removeAllListeners() return this
81ba3ae 
Fixes: nodejs#35762

PR-URL: nodejs#35805
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Copy link
Member

Trott commented Oct 28, 2020

Landed in 81ba3ae

@Trott Trott closed this Oct 28, 2020
@lpinca lpinca deleted the fix/issue-35762 branch October 28, 2020 14:10
targos pushed a commit that referenced this pull request Nov 3, 2020
@lpinca @targos
events: make eventTarget.removeAllListeners() return this
438d9de 
Fixes: #35762

PR-URL: #35805
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@lpinca @BethGriggs
events: make eventTarget.removeAllListeners() return this
9c74875 
Fixes: #35762

PR-URL: #35805
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@lpinca @BethGriggs
events: make eventTarget.removeAllListeners() return this
253f65c 
Fixes: #35762

PR-URL: #35805
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@lpinca @BethGriggs
events: make eventTarget.removeAllListeners() return this
8ef4557 
Fixes: #35762

PR-URL: #35805
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v15.0] NodeEventTarget#removeAllListeners has different return type than EventEmitter#removeAllListeners
7 participants
@lpinca @codecov-io @nodejs-github-bot @Trott @addaleax @benjamingr @targos