Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: make eventTarget.removeAllListeners() return this #35805

Closed
wants to merge 1 commit into from
Closed

events: make eventTarget.removeAllListeners() return this #35805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/api/events.md
View file
Open in desktop
Expand Up @@ -1525,6 +1525,8 @@ added: v14.5.0

* `type` {string}

* Returns: {EventTarget} this

Node.js-specific extension to the `EventTarget` class. If `type` is specified,
removes all registered listeners for `type`, otherwise removes all registered
listeners.
Expand Down
2 changes: 2 additions & 0 deletions lib/internal/event_target.js
View file
Open in desktop
Expand Up @@ -476,6 +476,8 @@ class NodeEventTarget extends EventTarget {
} else {
this[kEvents].clear();
}

return this;
}
}

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-nodeeventtarget.js
View file
Open in desktop
Expand Up @@ -117,11 +117,11 @@ const { on } = require('events');
strictEqual(eventTarget.listenerCount('foo'), 2);
strictEqual(eventTarget.listenerCount('bar'), 1);
deepStrictEqual(eventTarget.eventNames(), ['foo', 'bar']);
eventTarget.removeAllListeners('foo');
strictEqual(eventTarget.removeAllListeners('foo'), eventTarget);
strictEqual(eventTarget.listenerCount('foo'), 0);
strictEqual(eventTarget.listenerCount('bar'), 1);
deepStrictEqual(eventTarget.eventNames(), ['bar']);
eventTarget.removeAllListeners();
strictEqual(eventTarget.removeAllListeners(), eventTarget);
strictEqual(eventTarget.listenerCount('foo'), 0);
strictEqual(eventTarget.listenerCount('bar'), 0);
deepStrictEqual(eventTarget.eventNames(), []);
Expand Down