Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: refactor to use more primordials #36348

Merged
merged 0 commits into from Dec 4, 2020

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 1, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 2, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2020
@nodejs-github-bot

This comment has been minimized.

@aduh95
Copy link
Contributor Author

aduh95 commented Dec 2, 2020

Benchmark results didn't show any perf improvement or regression.

                                                                                  confidence improvement accuracy (*)    (**)   (***)
module/module-loader-circular.js n=10000                                                         -1.97 %       ±3.30%  ±4.39%  ±5.72%
module/module-loader-deep.js cache='false' files=1000 ext=''                                      2.10 %       ±4.48%  ±5.96%  ±7.75%
module/module-loader-deep.js cache='false' files=1000 ext='.js'                                   0.05 %       ±4.32%  ±5.76%  ±7.50%
module/module-loader-deep.js cache='true' files=1000 ext=''                                       0.99 %       ±5.66%  ±7.59% ±10.01%
module/module-loader-deep.js cache='true' files=1000 ext='.js'                                    1.25 %       ±9.57% ±12.73% ±16.57%
module/module-loader.js cache='false' n=1000 files=500 dir='abs' name='/'                         1.93 %       ±6.27%  ±8.38% ±10.97%
module/module-loader.js cache='false' n=1000 files=500 dir='abs' name=''                          2.11 %       ±6.32%  ±8.47% ±11.16%
module/module-loader.js cache='false' n=1000 files=500 dir='abs' name='/index.js'                 0.28 %       ±6.06%  ±8.07% ±10.52%
module/module-loader.js cache='false' n=1000 files=500 dir='rel' name='/'                        -2.84 %       ±4.87%  ±6.49%  ±8.48%
module/module-loader.js cache='false' n=1000 files=500 dir='rel' name=''                         -1.01 %       ±5.93%  ±7.95% ±10.45%
module/module-loader.js cache='false' n=1000 files=500 dir='rel' name='/index.js'                 5.07 %       ±5.11%  ±6.83%  ±8.95%
module/module-loader.js cache='false' n=1 files=500 dir='abs' name='/'                           -0.49 %       ±5.60%  ±7.45%  ±9.69%
module/module-loader.js cache='false' n=1 files=500 dir='abs' name=''                            -1.57 %       ±5.43%  ±7.23%  ±9.41%
module/module-loader.js cache='false' n=1 files=500 dir='abs' name='/index.js'                   -1.92 %       ±5.51%  ±7.33%  ±9.54%
module/module-loader.js cache='false' n=1 files=500 dir='rel' name='/'                           -2.10 %       ±6.13%  ±8.16% ±10.62%
module/module-loader.js cache='false' n=1 files=500 dir='rel' name=''                             3.93 %       ±6.34%  ±8.44% ±10.99%
module/module-loader.js cache='false' n=1 files=500 dir='rel' name='/index.js'                   -2.03 %       ±5.78%  ±7.69% ±10.01%
module/module-loader.js cache='true' n=1000 files=500 dir='abs' name='/'                          0.29 %       ±2.50%  ±3.33%  ±4.34%
module/module-loader.js cache='true' n=1000 files=500 dir='abs' name=''                          -0.48 %       ±1.74%  ±2.32%  ±3.02%
module/module-loader.js cache='true' n=1000 files=500 dir='abs' name='/index.js'                  0.65 %       ±5.63%  ±7.49%  ±9.76%
module/module-loader.js cache='true' n=1000 files=500 dir='rel' name='/'                         -1.60 %       ±1.77%  ±2.37%  ±3.10%
module/module-loader.js cache='true' n=1000 files=500 dir='rel' name=''                          -0.46 %       ±2.06%  ±2.74%  ±3.57%
module/module-loader.js cache='true' n=1000 files=500 dir='rel' name='/index.js'                 -1.53 %       ±2.04%  ±2.72%  ±3.54%
module/module-loader.js cache='true' n=1 files=500 dir='abs' name='/'                             0.72 %       ±7.87% ±10.49% ±13.68%
module/module-loader.js cache='true' n=1 files=500 dir='abs' name=''                              3.86 %       ±7.39%  ±9.87% ±12.91%
module/module-loader.js cache='true' n=1 files=500 dir='abs' name='/index.js'                     3.25 %       ±9.04% ±12.08% ±15.81%
module/module-loader.js cache='true' n=1 files=500 dir='rel' name='/'                            -1.31 %       ±3.67%  ±4.88%  ±6.35%
module/module-loader.js cache='true' n=1 files=500 dir='rel' name=''                              0.18 %       ±4.32%  ±5.75%  ±7.49%
module/module-loader.js cache='true' n=1 files=500 dir='rel' name='/index.js'                     4.15 %       ±7.10%  ±9.48% ±12.43%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case there are 29 comparisons, you can thus
expect the following amount of false-positive results:
 1.45 false positives, when considering a   5% risk acceptance (*, **, ***),
 0.29 false positives, when considering a   1% risk acceptance (**, ***),
 0.03 false positives, when considering a 0.1% risk acceptance (***)

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

Trott commented Dec 4, 2020

Landed in 3604fad

@Trott Trott merged commit 3604fad into nodejs:master Dec 4, 2020
@aduh95 aduh95 deleted the module-primordials branch December 4, 2020 14:36
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
PR-URL: #36348
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
PR-URL: nodejs#36348
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 16, 2021
PR-URL: #36348
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #36348
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants