Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15.4.0 proposal #36435

Merged
merged 95 commits into from Dec 9, 2020
Merged

v15.4.0 proposal #36435

merged 95 commits into from Dec 9, 2020

Conversation

danielleadams
Copy link
Member

@danielleadams danielleadams commented Dec 7, 2020

2020-12-09, Version 15.4.0 (Current), @danielleadams

Notable Changes

  • child_processes:
    • add AbortSignal support (Benjamin Gruenbaum) #36308
  • deps:
    • update ICU to 68.1 (Michaël Zasso) #36187
  • events:
    • support signal in EventTarget (Benjamin Gruenbaum) #36258
    • graduate Event, EventTarget, AbortController (James M Snell) #35949
  • http:
    • enable call chaining with setHeader() (pooja d.p) #35924
  • module:
    • add isPreloading indicator (James M Snell) #36263
  • stream:
    • support abort signal (Benjamin Gruenbaum) #36061
    • add FileHandle support to Read/WriteStream (Momtchil Momtchev) #35922
  • worker:
    • add experimental BroadcastChannel (James M Snell) #36271

Commits

  • [e79bdc313a] - assert: refactor to use more primordials (Antoine du Hamel) #36234
  • [2344e3e360] - benchmark: changed fstat to fstatSync (Narasimha Prasanna HN) #36206
  • [ca8db41151] - benchmark,child_process: remove failing benchmark parameter (Antoine du Hamel) #36295
  • [9db9be774b] - buffer: refactor to use primordials instead of Array#reduce (Antoine du Hamel) #36392
  • [8d8d2261a5] - buffer: refactor to use more primordials (Antoine du Hamel) #36166
  • [74adc441c4] - build: fix typo in Makefile (raisinten) #36176
  • [224a6471cc] - (SEMVER-MINOR) child_process: add AbortSignal support (Benjamin Gruenbaum) #36308
  • [4ca1bd8806] - child_process: refactor to use more primordials (Zijian Liu) #36269
  • [841e8f444e] - crypto: fix "Invalid JWK" error messages (Filip Skokan) #36200
  • [278862aeb9] - deps: upgrade npm to 7.0.15 (Ruy Adorno) #36293
  • [66bc2067ce] - deps: V8: cherry-pick 86991d0587a1 (Benjamin Coe) #36254
  • [095cef2c11] - deps: update ICU to 68.1 (Michaël Zasso) #36187
  • [8d69d8387e] - dgram: refactor to use more primordials (Antoine du Hamel) #36286
  • [bef550a50c] - doc: add Powershell oneliner to get Windows version (Michael Bashurov) #30289
  • [2649c384c6] - doc: add version metadata to timers/promises (Colin Ihrig) #36378
  • [0401ffbfb6] - doc: add process for handling premature disclosure (Michael Dawson) #36155
  • [3e5fcda13e] - doc: add table header in intl.md (Rich Trott) #36261
  • [65d89fdd69] - doc: adding example to Buffer.isBuffer method (naortedgi) #36233
  • [03cf8dbc0e] - doc: fix typo in events.md (Luigi Pinca) #36231
  • [b176d61e8c] - doc: fix --experimental-wasm-modules text location (Colin Ihrig) #36220
  • [44c4aaddad] - doc: stabilize subpath patterns (Guy Bedford) #36177
  • [fdf5d851d0] - doc: add missing version to update cmd (Ruy Adorno) #36204
  • [186ad24fdf] - doc: cleanup events.md structure (James M Snell) #36100
  • [c14512b9a5] - errors: display original symbol name (Benjamin Coe) #36042
  • [855a85c124] - (SEMVER-MINOR) events: support signal in EventTarget (Benjamin Gruenbaum) #36258
  • [dc1930923b] - (SEMVER-MINOR) events: graduate Event, EventTarget, AbortController (James M Snell) #35949
  • [537e5cbf51] - fs: move method definition from header (Yash Ladha) #36256
  • [744b8aa807] - fs: pass ERR_DIR_CLOSED asynchronously to dir.close (Zijian Liu) #36243
  • [c04a2df185] - fs: refactor to use more primordials (Antoine du Hamel) #36196
  • [58abdcaceb] - (SEMVER-MINOR) http: enable call chaining with setHeader() (pooja d.p) #35924
  • [cedf51f3ce] - http2: refactor to use more primordials (Antoine du Hamel) #36357
  • [5f41f1b19e] - http2: check write not scheduled in scope destructor (David Halls) #36241
  • [4127eb2405] - https: add abortcontroller test (Benjamin Gruenbaum) #36307
  • [c2938bde6c] - lib: add uncurried accessor properties to primordials (ExE Boss) #36329
  • [f73a0a8069] - lib: fix typo in internal/errors.js (raisinten) #36426
  • [617cb58cc8] - lib: refactor primordials.uncurryThis (Antoine du Hamel) #36221
  • [cc18907ec4] - module: refactor to use more primordials (Antoine du Hamel) #36348
  • [d4de7c7eb9] - (SEMVER-MINOR) module: add isPreloading indicator (James M Snell) #36263
  • [8611b8f98a] - net: refactor to use more primordials (Antoine du Hamel) #36303
  • [2a24096720] - os: refactor to use more primordials (Antoine du Hamel) #36284
  • [0e7f0c6d27] - path: refactor to use more primordials (Antoine du Hamel) #36302
  • [ea46ca8cbf] - perf_hooks: refactor to use more primordials (Antoine du Hamel) #36297
  • [a9ac86d1ee] - policy: refactor to use more primordials (Antoine du Hamel) #36210
  • [39d0ceda48] - process: refactor to use more primordials (Antoine du Hamel) #36212
  • [ab084c199e] - querystring: refactor to use more primordials (Antoine du Hamel) #36315
  • [d29199ef82] - quic: refactor to use more primordials (Antoine du Hamel) #36211
  • [b885409e48] - readline: refactor to use more primordials (Antoine du Hamel) #36296
  • [9cb53f635a] - repl: refactor to use more primordials (Antoine du Hamel) #36264
  • [8dadaa652e] - src: remove some duplication in DeserializeProps (Daniel Bevenius) #36336
  • [a03aa0a6b2] - src: rename AliasedBufferInfo->AliasedBufferIndex (Daniel Bevenius) #36339
  • [e7b2d91e04] - src: use transferred consistently (Daniel Bevenius) #36340
  • [6ebb98af11] - src: use ToLocal in DeserializeProperties (Daniel Bevenius) #36279
  • [47397ffd56] - src: update node.rc file description (devsnek) #36197
  • [cfc8ec18db] - src: fix label indentation (Rich Trott) #36213
  • [197ba21279] - (SEMVER-MINOR) stream: support abort signal (Benjamin Gruenbaum) #36061
  • [6033d30361] - (SEMVER-MINOR) stream: add FileHandle support to Read/WriteStream (Momtchil Momtchev) #35922
  • [a15addc153] - string_decoder: refactor to use more primordials (Antoine du Hamel) #36358
  • [b39d150e60] - test: fix comment misspellings of transferred (Rich Trott) #36360
  • [a7e794d1bf] - test: fix flaky test-http2-respond-file-error-pipe-offset (Rich Trott) #36305
  • [1091a658e1] - test: fix bootstrap test (Benjamin Gruenbaum) #36418
  • [fbcb72a665] - test: increase coverage for readline (Zijian Liu) #36389
  • [22028aae54] - test: skip flaky parts of broadcastchannel test on Windows (Rich Trott) #36386
  • [faca2b829e] - test: fix test-worker-broadcastchannel-wpt (Rich Trott) #36353
  • [ea09da492c] - test: fix typo in comment (inokawa) #36312
  • [b61ca1bfe6] - test: replace anonymous functions by arrows (Aleksandr Krutko) #36125
  • [2c7358ef43] - test: fix flaky sequential/test-fs-watch (Rich Trott) #36249
  • [b613950016] - test: increase coverage for util.inspect() (Rich Trott) #36228
  • [69a8f05488] - test: improve test coverage SourceMap API (Juan José Arboleda) #36089
  • [44d6d0bf0d] - test: fix missed warning for non-experimental AbortController (James M Snell) #36240
  • [29b5236256] - timers: reject with AbortError on cancellation (Benjamin Gruenbaum) #36317
  • [b20409e985] - tls: refactor to use more primordials (Antoine du Hamel) #36266
  • [f317bba034] - tls: permit null as a cipher value (Rich Trott) #36318
  • [9ae59c847a] - tools: upgrade to @babel/eslint-parser 7.12.1 (Antoine du Hamel) #36321
  • [e798770803] - tools: refloat 7 Node.js patches to cpplint.py (Rich Trott) #36324
  • [a8b95cfcb2] - tools: bump cpplint to 1.5.4 (Rich Trott) #36324
  • [754b7a76b1] - tools: remove bashisms from macOS release scripts (Antoine du Hamel) #36121
  • [2868ffb331] - tools: remove bashisms from release script (Antoine du Hamel) #36123
  • [8cf1addaa8] - tools: update stability index linking logic (Rich Trott) #36280
  • [d95ae65986] - tools: update highlight.js to 10.1.2 (Myles Borins) #36309
  • [5935ccc11c] - tools: fix undeclared identifier FALSE (Antoine du Hamel) #36276
  • [a2da7ba914] - tools: use using-declaration consistently (Daniel Bevenius) #36245
  • [82c1e39c4a] - tools: refloat 7 Node.js patches to cpplint.py (Rich Trott) #36235
  • [bcf7393412] - tools: bump cpplint to 1.5.3 (Rich Trott) #36235
  • [be11976407] - tools: enable no-nonoctal-decimal-escape lint rule (Colin Ihrig) #36217
  • [c86c2399a2] - tools: update ESLint to 7.14.0 (Colin Ihrig) #36217
  • [cfadd82cf3] - tools: refloat 7 Node.js patches to cpplint.py (Rich Trott) #36213
  • [03e8aaf613] - tools: bump cpplint.py to 1.5.2 (Rich Trott) #36213
  • [6bc007fc94] - tty: refactor to use more primordials (Zijian Liu) #36272
  • [fbd5652943] - v8: refactor to use more primordials (Antoine du Hamel) #36285
  • [8731a80439] - vm: add SafeForTerminationScopes for SIGINT interruptions (Anna Henningsen) #36344
  • [47345a1f84] - worker: refactor to use more primordials (Antoine du Hamel) #36393
  • [21c4704c7b] - worker: refactor to use more primordials (Antoine du Hamel) #36267
  • [802d44b1a9] - (SEMVER-MINOR) worker: add experimental BroadcastChannel (James M Snell) #36271
  • [4b4caada9f] - zlib: refactor to use more primordials (Antoine du Hamel) #36347

targos and others added 30 commits December 7, 2020 13:44
Refs: https://github.com/unicode-org/icu/releases/tag/release-68-1

PR-URL: #36187
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
In preparation for a cpplint version bump, move labels to be unindented.
The one space indentation we use now is flagged in cpplint 1.5.2.

Refs: https://softwareengineering.stackexchange.com/q/151806/26510

PR-URL: #36213
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
https://github.com/cpplint/cpplint/releases/tag/1.5.2

PR-URL: #36213
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Cherry-pick 12c8b4d
Original commit message:
    This commit is a suggestion for adding a rule for NULL usages in the
    code base. This will currently report a number of errors which could be
    ignored using // NOLINT (readability/null_usage)

    PR-URL: #17373
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Refs: 12c8b4d

Cherry-pick fc81e80
Original commit message:

    Update cpplint.py to check for inline headers when the corresponding
    header is already included.

    PR-URL: #21521
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: fc81e80

Cherry-pick cbc3dd9
Original commit message:

    src, tools: add check for left leaning pointers

    This commit adds a rule to cpplint to check that pointers in the code
    base lean to the left and not right, and also fixes the violations
    reported.

    PR-URL: #21010
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: cbc3dd9

Cherry-pick 9029981
Original commit message:

    tools: fix cpplint.py header rules

    THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT.

    PR-URL: #26306
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

Refs: 9029981

Cherry-pick 0a25ace
Original commit message:

    tools: move cpplint configuration to .cpplint

    PR-URL: #27098
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

Refs: 0a25ace

Cherry-pick afa9a72
Original commit message:

    tools: refloat update link to google styleguide for cpplint

    This commit updates two old links to Google's C++ styleguide which
    currently result in a 404 when accessed.

    PR-URL: #30876
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>

Refs: afa9a72

Cherry-pick e23bf8f
Original commit message:

    tools,src: refloat forbid usage of v8::Persistent

    `v8::Persistent` comes with the surprising catch that it requires
    manual cleanup. `v8::Global` doesn’t, making it easier to use,
    and additionally provides move semantics. New code should always
    use `v8::Global`.

    PR-URL: #31018
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

PR-URL: #35569
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

PR-URL: #35719
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #35866

PR-URL: #36213
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: #36197
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36100
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Graduate these from experimental status

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #35949
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Add to the example of running `./tools/update-npm.sh` the missing
reference to the version number that is required by the command.

PR-URL: #36204
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36177
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Update ESLint to 7.14.0

PR-URL: #36217
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This rule is new in ESLint 7.14.0.

PR-URL: #36217
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
The text for --experimental-wasm-modules had drifted to under the
--force-context-aware text. This commit moves it back to the
proper location.

PR-URL: #36220
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36240
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36089
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36212
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36200
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This is done to avoid creating an array and gain performance.

Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>

PR-URL: #36221
Refs: https://v8.dev/blog/v8-release-80#optimizing-higher-order-builtins
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #36211
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36231
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Adds methods for fetching stack trace information about
enclosing function.

Refs #36042

Original commit message:

    Reland "stack-trace-api: implement getEnclosingLine/Column"

    This reverts commit 5557a63beb5a53c93e9b590eaf2933e21bcb3768.

    Reason for revert: Sheriff's mistake, failing test was previously flaking.

    Original change's description:
    > Revert "stack-trace-api: implement getEnclosingLine/Column"
    >
    > This reverts commit c48ae2d96cbfdc2216706a5e9a79ae1dce5a638b.
    >
    > Reason for revert: Breaks a profiling test:
    > https://ci.chromium.org/p/v8/builders/ci/V8%20Win32/30010
    >
    > Original change's description:
    > > stack-trace-api: implement getEnclosingLine/Column
    > >
    > > Introduces getEnclosingColumn and getEnclosingLine on CallSite
    > > so that the position can be used to lookup the original symbol
    > > for function when source maps are used.
    > >
    > > BUG=v8:11157
    > >
    > > Change-Id: I06c4c374d172d206579abb170c7b7a2bd3bb159f
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2547218
    > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > > Commit-Queue: Benjamin Coe <bencoe@google.com>
    > > Cr-Commit-Position: refs/heads/master@{#71343}
    >
    > TBR=jkummerow@chromium.org,yangguo@chromium.org,bencoe@google.com
    >
    > Change-Id: Iab5c250c1c4fbdab86971f4a7e40abc8f87cf79c
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: v8:11157
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2555384
    > Reviewed-by: Bill Budge <bbudge@chromium.org>
    > Commit-Queue: Bill Budge <bbudge@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#71345}

    TBR=bbudge@chromium.org,jkummerow@chromium.org,yangguo@chromium.org,bencoe@google.com

    # Not skipping CQ checks because this is a reland.

    Bug: v8:11157
    Change-Id: I8dba19ceb29a24594469d2cf79626f741dc4cad3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2555499
    Reviewed-by: Bill Budge <bbudge@chromium.org>
    Commit-Queue: Bill Budge <bbudge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71348}

Refs: v8/v8@86991d0

PR-URL: #36254
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #36233
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #36206
Fixes: #36199
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Confirm that own constructor value displays correctly.

Refs: https://coverage.nodejs.org/coverage-0d468ab200584c3a/lib/internal/util/inspect.js.html#L550

PR-URL: #36228
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #36235
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Cherry-pick 12c8b4d
Original commit message:
    This commit is a suggestion for adding a rule for NULL usages in the
    code base. This will currently report a number of errors which could be
    ignored using // NOLINT (readability/null_usage)

    PR-URL: #17373
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Refs: 12c8b4d

Cherry-pick fc81e80
Original commit message:

    Update cpplint.py to check for inline headers when the corresponding
    header is already included.

    PR-URL: #21521
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: fc81e80

Cherry-pick cbc3dd9
Original commit message:

    src, tools: add check for left leaning pointers

    This commit adds a rule to cpplint to check that pointers in the code
    base lean to the left and not right, and also fixes the violations
    reported.

    PR-URL: #21010
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: cbc3dd9

Cherry-pick 9029981
Original commit message:

    tools: fix cpplint.py header rules

    THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT.

    PR-URL: #26306
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

Refs: 9029981

Cherry-pick 0a25ace
Original commit message:

    tools: move cpplint configuration to .cpplint

    PR-URL: #27098
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

Refs: 0a25ace

Cherry-pick afa9a72
Original commit message:

    tools: refloat update link to google styleguide for cpplint

    This commit updates two old links to Google's C++ styleguide which
    currently result in a 404 when accessed.

    PR-URL: #30876
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>

Refs: afa9a72

Cherry-pick e23bf8f
Original commit message:

    tools,src: refloat forbid usage of v8::Persistent

    `v8::Persistent` comes with the surprising catch that it requires
    manual cleanup. `v8::Global` doesn’t, making it easier to use,
    and additionally provides move semantics. New code should always
    use `v8::Global`.

    PR-URL: #31018
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

PR-URL: #35569
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

PR-URL: #35719
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #35866

PR-URL: #36213
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

PR-URL: #36235
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #36245
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Fixes: #36247

PR-URL: #36249
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #36234
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #36176
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36210
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
ExE-Boss and others added 4 commits December 7, 2020 13:55
Closes: #32127

PR-URL: #36329
Fixes: #32127
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #36393
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #36321
Fixes: https://github.com/ensure
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #36303
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Dec 7, 2020
danielleadams added a commit that referenced this pull request Dec 7, 2020
PR-URL: #36435

Notable changes:

* child_processes:
  * add AbortSignal support (Benjamin Gruenbaum) (#36308)
* deps:
  * update ICU to 68.1 (Michaël Zasso) (#36187)
* events:
  * support signal in EventTarget (Benjamin Gruenbaum) (#36258)
  * graduate Event, EventTarget, AbortController (James M Snell) (#35949)
* http:
  * enable call chaining with setHeader() (pooja d.p) (#35924)
* module:
  * add isPreloading indicator (James M Snell) (#36263)
* stream:
  * support abort signal (Benjamin Gruenbaum) (#36061)
  * add FileHandle support to Read/WriteStream (Momtchil Momtchev) (#35922)
* worker:
  * add experimental BroadcastChannel (James M Snell) (#36271)
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@danielleadams danielleadams changed the title V15.4.0 proposal v15.4.0 proposal Dec 8, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2020

@danielleadams
Copy link
Member Author

The latest build is green, even though some of the checks aren't displaying as passed.

PR-URL: #36435

Notable changes:

* child_processes:
  * add AbortSignal support (Benjamin Gruenbaum) (#36308)
* deps:
  * update ICU to 68.1 (Michaël Zasso) (#36187)
* events:
  * support signal in EventTarget (Benjamin Gruenbaum) (#36258)
  * graduate Event, EventTarget, AbortController (James M Snell) (#35949)
* http:
  * enable call chaining with setHeader() (pooja d.p) (#35924)
* module:
  * add isPreloading indicator (James M Snell) (#36263)
* stream:
  * support abort signal (Benjamin Gruenbaum) (#36061)
  * add FileHandle support to Read/WriteStream (Momtchil Momtchev) (#35922)
* worker:
  * add experimental BroadcastChannel (James M Snell) (#36271)
@danielleadams danielleadams merged commit 5e5927e into v15.x Dec 9, 2020
danielleadams added a commit that referenced this pull request Dec 9, 2020
@danielleadams danielleadams deleted the v15.4.0-proposal branch December 9, 2020 13:45
danielleadams added a commit that referenced this pull request Dec 9, 2020
PR-URL: #36435

Notable changes:

* child_processes:
  * add AbortSignal support (Benjamin Gruenbaum) (#36308)
* deps:
  * update ICU to 68.1 (Michaël Zasso) (#36187)
* events:
  * support signal in EventTarget (Benjamin Gruenbaum) (#36258)
  * graduate Event, EventTarget, AbortController (James M Snell) (#35949)
* http:
  * enable call chaining with setHeader() (pooja d.p) (#35924)
* module:
  * add isPreloading indicator (James M Snell) (#36263)
* stream:
  * support abort signal (Benjamin Gruenbaum) (#36061)
  * add FileHandle support to Read/WriteStream (Momtchil Momtchev) (#35922)
* worker:
  * add experimental BroadcastChannel (James M Snell) (#36271)
danielleadams pushed a commit to danielleadams/nodejs.org that referenced this pull request Dec 9, 2020
danielleadams added a commit to nodejs/nodejs.org that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet