Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add version metadata to timers/promises #36378

Closed
wants to merge 1 commit into from
Closed

doc: add version metadata to timers/promises #36378

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 4, 2020

Refs: #33950

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Dec 4, 2020
@cjihrig cjihrig mentioned this pull request Dec 4, 2020
Closed
4 tasks
benjamingr
benjamingr approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@cjihrig cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 6, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 6, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2020

Landed in 20de5f7...2f49720

nodejs-github-bot pushed a commit that referenced this pull request Dec 6, 2020
@cjihrig @nodejs-github-bot
doc: add version metadata to timers/promises
2f49720 
Refs: #33950

PR-URL: #36378
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@github-actions github-actions bot closed this Dec 6, 2020
@cjihrig cjihrig deleted the doc branch December 6, 2020 15:55
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@cjihrig @danielleadams
doc: add version metadata to timers/promises
2649c38 
Refs: #33950

PR-URL: #36378
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
cjihrig added a commit to cjihrig/node that referenced this pull request Dec 8, 2020
@cjihrig
doc: add version metadata to timers/promises
6ba2dc6 
Refs: nodejs#33950

PR-URL: nodejs#36378
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@baby636 baby636 mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@benjamingr benjamingr benjamingr approved these changes

@watilde watilde watilde approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@cjihrig @styfle @benjamingr @watilde @richardlau @BethGriggs @aduh95 @targos @nodejs-github-bot