Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,doc: fix https agent minVersion/maxVersion test and docs #38202

Closed
wants to merge 3 commits into from
Closed

test,doc: fix https agent minVersion/maxVersion test and docs #38202

wants to merge 3 commits into from

Commits on Apr 11, 2021

  1. test: fix test-https-agent-additional-options.js 

    `value` was always being assigned to an `undefined` property of an
Array. Thus, the assertions that depended on `value` being defined were
never being checked. Assign `value` the correct...er...value.
    @Trott
    Trott committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    543a9a0 View commit details
    Browse the repository at this point in the history

  2. test add tests for missing https agent options 

    Add test that minVersion and maxVersion options are accepted. This
should complete coverage for lib/https.js.

Refs: https://codecov.io/gh/nodejs/node/src/ec0dcd720e10831b3e783b415c5dc011ed5be2f8/lib/https.js
    @Trott
    Trott committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    74d62ff View commit details
    Browse the repository at this point in the history

  3. doc: revise TLS minVersion/maxVersion text 

    Minor changes mostly to improve compliance with our style guide.
    @Trott
    Trott committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    55bada0 View commit details
    Browse the repository at this point in the history