Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,doc: fix https agent minVersion/maxVersion test and docs #38202

Closed
wants to merge 3 commits into from
Closed

test,doc: fix https agent minVersion/maxVersion test and docs #38202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
543a9a0
test: fix test-https-agent-additional-options.js
Trott Apr 11, 2021
74d62ff
test add tests for missing https agent options
Trott Apr 11, 2021
55bada0
doc: revise TLS minVersion/maxVersion text
Trott Apr 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions doc/api/tls.md
View file
Open in desktop
Expand Up @@ -1738,12 +1738,12 @@ changes:
private key in different ways.
* `maxVersion` {string} Optionally set the maximum TLS version to allow. One
of `'TLSv1.3'`, `'TLSv1.2'`, `'TLSv1.1'`, or `'TLSv1'`. Cannot be specified
along with the `secureProtocol` option, use one or the other.
along with the `secureProtocol` option; use one or the other.
**Default:** [`tls.DEFAULT_MAX_VERSION`][].
* `minVersion` {string} Optionally set the minimum TLS version to allow. One
of `'TLSv1.3'`, `'TLSv1.2'`, `'TLSv1.1'`, or `'TLSv1'`. Cannot be specified
along with the `secureProtocol` option, use one or the other. It is not
recommended to use less than TLSv1.2, but it may be required for
along with the `secureProtocol` option; use one or the other. Avoid
setting to less than TLSv1.2, but it may be required for
interoperability.
**Default:** [`tls.DEFAULT_MIN_VERSION`][].
* `passphrase` {string} Shared passphrase used for a single private key and/or
Expand Down
4 changes: 3 additions & 1 deletion test/parallel/test-https-agent-additional-options.js
View file
Open in desktop
Expand Up @@ -36,6 +36,8 @@ const updatedValues = new Map([
['dhparam', fixtures.readKey('dh2048.pem')],
['ecdhCurve', 'secp384r1'],
['honorCipherOrder', true],
['minVersion', 'TLSv1.1'],
['maxVersion', 'TLSv1.3'],
['secureOptions', crypto.constants.SSL_OP_CIPHER_SERVER_PREFERENCE],
['secureProtocol', 'TLSv1_1_method'],
['sessionIdContext', 'sessionIdContext'],
Expand Down Expand Up @@ -63,8 +65,8 @@ function variations(iter, port, cb) {
server.close();
} else {
// Save `value` for check the next time.
value = next.value.val;
const [key, val] = next.value;
value = val;
https.get({ ...getBaseOptions(port), [key]: val },
variations(iter, port, cb));
}
Expand Down